As a developer I would like better cross platform reliability for path handling #52

New Issue

sloum · 2019-10-09T15:47:42Z

sloum commented

2019-10-09 15:47:42 +00:00

PR #50 solved a write to file issue by using the path module. It would be a good idea to comb through the codebase for other areas where this might be of use and implement it in those locations. This will provide better cross platform reliability to the application and will avoid hacked together code.

PR https://tildegit.org/sloum/bombadillo/pulls/50 solved a write to file issue by using the path module. It would be a good idea to comb through the codebase for other areas where this might be of use and implement it in those locations. This will provide better cross platform reliability to the application and will avoid hacked together code.

sloum added the

non-functional

label 2019-10-09 15:49:49 +00:00

sloum added the

non-urgent

label 2019-10-09 15:52:26 +00:00

sloum removed the

non-urgent

label 2019-10-17 20:16:30 +00:00

sloum commented

2019-10-17 20:16:53 +00:00

I have removed non-urgent as I think for compatibility purposes this should be handled before 2.0.0 release. I'll try to work on it this week/weekend.

sloum self-assigned this 2019-10-17 20:17:09 +00:00

asdf added this to the 2.0.0 milestone 2019-10-27 03:51:59 +00:00

sloum commented

2019-11-17 23:14:19 +00:00

I believe this has been solved by the following:

Updates to the local module
Removal of named file writes from client.go
Updates to the existing file writes

@asdf I think this can probably be closed. I'll leave it open for a few days to allow each of us to see if we spot anything while going through other items, but otherwise I think it is pretty good.

I believe this has been solved by the following: - Updates to the `local` module - Removal of named file writes from `client.go` - Updates to the existing file writes @asdf I think this can probably be closed. I'll leave it open for a few days to allow each of us to see if we spot anything while going through other items, but otherwise I think it is pretty good.

asdf commented

2019-11-18 00:17:19 +00:00

I also think this can be closed, I've been unable to find any more areas that can be improved using path or filepath.