As a developer, I'd like linted code to help with quality #65

New Issue

asdf · 2019-10-28T12:45:32Z

asdf commented

2019-10-28 12:45:32 +00:00

There are around 40 warnings currently coming up on the code base from GoMetaLinter. These are things like:

exported functions requiring comments
replace num -= 1 with num--
if block ending with return statement, so drop else and outdent its block

I'd like to clean up some of these warnings for the 2.0.0 release.

I'd also like to ensure that all files are formatted for the release.

Maybe there are other static analysis steps required?

There are around 40 warnings currently coming up on the code base from GoMetaLinter. These are things like: - exported functions requiring comments - replace `num -= 1` with `num--` - if block ending with return statement, so drop else and outdent its block I'd like to clean up some of these warnings for the 2.0.0 release. I'd also like to ensure that all files are formatted for the release. Maybe there are other static analysis steps required?

asdf self-assigned this 2019-10-28 12:45:32 +00:00

sloum was assigned by asdf

2019-10-28 12:45:32 +00:00

asdf added the

non-functional

label 2019-10-28 12:45:32 +00:00

sloum commented

2019-10-28 14:32:00 +00:00

I think this is a good idea. Is GoMetaLinter a vim package? Or provided with the go toolchain? I have generally been running go fmt on things, but that is about it. I definitely agree a consistent code style would be good to have by release time.

EDIT: It seems that GoMetaLinter is deprecated in favor of golangci-lint.

I think this is a good idea. Is GoMetaLinter a vim package? Or provided with the go toolchain? I have generally been running `go fmt` on things, but that is about it. I definitely agree a consistent code style would be good to have by release time. **EDIT**: It seems that GoMetaLinter is deprecated in favor of [golangci-lint](https://github.com/golangci/golangci-lint).

asdf commented

2019-10-29 03:16:22 +00:00

Thanks for the heads up on GoMetaLinter being deprecated. vim-go changed the command :GoMetaLinter to use golangci-lint very recently, so it changed without my noticing...

Thanks for the heads up on GoMetaLinter being deprecated. vim-go changed the command `:GoMetaLinter` to use golangci-lint very recently, so it changed without my noticing...

🎉 1

sloum commented

2019-11-12 02:59:41 +00:00

This, I think, gets closed by #83 but there may be more to do. Not sure. What do you think @asdf ?