As a developer I would like the makefile to follow install variable standards #66

New Issue

sloum · 2019-10-28T20:24:31Z

sloum commented

2019-10-28 20:24:31 +00:00

Having looked at the DESTDIR entry in the GNU make docs, I also started looking at some other documentation and came upon this.

It seems like having DESTDIR is good, but that we may want to make a few other variables available. Particlarly: exec_prefix, bindir, mandir, and man1dir.

Setting things up to allow a user to alter bindir, for example, seems more useful than DESTDIR. If a user uses DESTDIR they end up with a lot more folder structure than they may expect, and there are potential pathing complexities there. I think it is useful for its intended purpose of staging an install for review, but not as much so for an alternate install location.

Having looked at the `DESTDIR` entry in the GNU make docs, I also started looking at some other documentation and came upon [this](https://www.gnu.org/prep/standards/html_node/Directory-Variables.html#Directory-Variables). It seems like having `DESTDIR` is good, but that we may want to make a few other variables available. Particlarly: `exec_prefix`, `bindir`, `mandir`, and `man1dir`. Setting things up to allow a user to alter `bindir`, for example, seems more useful than `DESTDIR`. If a user uses `DESTDIR` they end up with a lot more folder structure than they may expect, and there are potential pathing complexities there. I think it is useful for its intended purpose of staging an install for review, but not as much so for an alternate install location.

sloum added the

non-code

non-functional

build

labels 2019-10-28 20:25:14 +00:00

asdf was assigned by sloum

2019-10-28 20:25:21 +00:00

sloum self-assigned this 2019-10-28 20:25:22 +00:00

asdf referenced this issue from a commit

2019-11-04 03:06:46 +00:00

Amended Makefile to include additional variables as per #66

asdf commented