client display and terminal issues after using telnet #79

New Issue

asdf · 2019-11-07T03:39:26Z

asdf commented

2019-11-07 03:39:26 +00:00

These are similar or the same issues as referenced in #36. Confirmed as still an issue in develop branch.

Telnet sessions can break the state of the terminal, resulting in weird behaviour in the client display:

screen size incorrect, page only drawn to half of the terminal window
mouse movement generates input
possibly colour bleeding as mentioned in #36

Most of these issues can persist even after quitting the client.

client.go has function handleTelnet() which ends with c.Draw(). I've done a quick test to try resetting and reinitialising to handle any possible terminal issues:

func (c *client) handleTelnet(u Url) {
        ...
        cui.Tput("reset")
        cui.InitTerm()
        c.Draw()
}

Let me know what you think - is this the right approach? I can do some more work on this and raise a PR.

These are similar or the same issues as referenced in #36. Confirmed as still an issue in develop branch. Telnet sessions can break the state of the terminal, resulting in weird behaviour in the client display: - screen size incorrect, page only drawn to half of the terminal window - mouse movement generates input - possibly colour bleeding as mentioned in #36 Most of these issues can persist even after quitting the client. `client.go` has function `handleTelnet()` which ends with `c.Draw()`. I've done a quick test to try resetting and reinitialising to handle any possible terminal issues: ```go func (c *client) handleTelnet(u Url) { ... cui.Tput("reset") cui.InitTerm() c.Draw() } ``` Let me know what you think - is this the right approach? I can do some more work on this and raise a PR.

asdf self-assigned this 2019-11-07 03:39:26 +00:00

sloum was assigned by asdf

2019-11-07 03:39:26 +00:00

asdf added the

bug

telnet

labels 2019-11-07 03:39:26 +00:00

sloum commented

2019-11-07 05:42:42 +00:00

I was not familiar with reset as an option for tput (tput being one of those things that I discover more about as I need to, but seemingly never before). This approach seems good to me. If you are getting good results with this, it certainly can't be worse than leaving it in a bad state. I think this is a good call.

I was not familiar with `reset` as an option for tput (tput being one of those things that I discover more about as I need to, but seemingly never before). This approach seems good to me. If you are getting good results with this, it certainly can't be worse than leaving it in a bad state. I think this is a good call.

asdf commented

2019-11-08 05:30:54 +00:00

Fixed in #80

👍 1

asdf closed this issue

2019-11-08 05:30:54 +00:00

Sign in to join this conversation.