Remove unused functions getCurrentPageRawData & getCurrentPageUrl #100

asdf · 2019-11-26T01:31:15Z

asdf commented

2019-11-26 01:31:15 +00:00

Fixes #98

Functions getCurrentPageRawData & getCurrentPageUrl were identified as unused and are to be removed.

Did some minor testing, no issues observed.

This can be held off until after the 2.0.0 release.

Fixes #98 Functions getCurrentPageRawData & getCurrentPageUrl were identified as unused and are to be removed. Did some minor testing, no issues observed. This can be held off until after the 2.0.0 release.

asdf added the

non-functional

non-urgent

labels 2019-11-26 01:31:15 +00:00

asdf referenced this pull request

2019-11-26 01:32:06 +00:00

Linting items for review #98

sloum commented

2019-11-26 15:40:37 +00:00

Looks good. I have not generated the binaries for release yet (I think I should wait and make the release TAG before generating the binaries), so we could merge this in now if you think it would be good to do so. On the other hand there will always be things to come up. Maybe best to respect the code freeze? Let me know. I'm good either way. But if we merge this it really should be the last code change.

sloum closed this pull request

2019-11-28 19:54:20 +00:00

sloum deleted branch remove-getCurrentPage-

2019-11-28 19:54:27 +00:00

Sign in to join this conversation.

No reviewers