Adds an option to set a default scheme #117

sloum · 2019-12-07T06:29:34Z

sloum commented

2019-12-07 06:29:34 +00:00

Issue #58 requested the ability to set the default scheme. This PR adds that, as well as updates to the manpage describing the new option.

Creates config option defaultscheme
Valid values:
- gopher
- gemini
- http
- https
Invalid values:
- finger: highly unlikely to be desired for this purpose and some weirdness in the url file made it trickier than it was worth. Could be revisited if requested.
- telnet: again, highly unlikely to be desired for this purpose.
- local: this already behaves in a default way without the need for this feature. Any url starting with /, ., or ~ will default to local.
- anything not listed in valid values

This provides flexibility to let users use bombadillo however it makes sense for their workflow. They could use it as a web browser if they really wanted this way. But they could also get really into gemini if it gets big enough for that to be a thing to do. In the meantime, gopher is still the provided default in defaults.go.

Issue #58 requested the ability to set the default scheme. This PR adds that, as well as updates to the manpage describing the new option. - Creates config option `defaultscheme` - Valid values: - gopher - gemini - http - https - Invalid values: - finger: highly unlikely to be desired for this purpose and some weirdness in the url file made it trickier than it was worth. Could be revisited if requested. - telnet: again, highly unlikely to be desired for this purpose. - local: this already behaves in a default way without the need for this feature. Any url starting with `/`, `.`, or `~` will default to local. - _anything not listed in valid values_ This provides flexibility to let users use bombadillo however it makes sense for their workflow. They could use it as a web browser if they really wanted this way. But they could also get really into gemini if it gets big enough for that to be a thing to do. In the meantime, `gopher` is still the provided default in `defaults.go`.

sloum added this to the 2.1.0 milestone 2019-12-07 06:29:34 +00:00

sloum added the

labels 2019-12-07 06:29:34 +00:00

asdf approved these changes 2019-12-08 02:52:10 +00:00

asdf left a comment

Did some quick manual testing and found no issues. Also did checks like make test and GoMetaLinter. It all seems fine to me!

Did some quick manual testing and found no issues. Also did checks like `make test` and GoMetaLinter. It all seems fine to me!