Fixes querystring chaining issue #159

Merged
sloum merged 2 commits from querystring into release-2.3.0 2020-05-24 16:40:35 +00:00
Owner

This solves an issue brought up in #157

In short: if a query was followed by another query, rather than replacing the query element ( or ? for gophr and gemini respectively) another was just getting tacked on to the end. THis has been resolved and the prior query element is removed.

There was also a request to escape querystrings before sending to gemini servers. I implemented this but found that none of the search engines worked this way. A look at the spec does not make it clear what the expected behavior is. I am leaving out the querystring escaping for now so that users do not lose the ability to search.

This solves an issue brought up in #157 In short: if a query was followed by another query, rather than replacing the query element (` ` or `?` for gophr and gemini respectively) another was just getting tacked on to the end. THis has been resolved and the prior query element is removed. There was also a request to escape querystrings before sending to gemini servers. I implemented this but found that none of the search engines worked this way. A look at the spec does not make it clear what the expected behavior is. I am leaving out the querystring escaping for now so that users do not lose the ability to search.
sloum added the
bug
gopher
gemini
labels 2020-05-24 14:50:31 +00:00
sloum closed this pull request 2020-05-24 16:40:35 +00:00
sloum deleted branch querystring 2020-05-24 16:40:45 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#159
No description provided.