Uses 'linux' OpenInBrowser settings for any non-darwin and non-windows os #180

Merged
sloum merged 3 commits from fixes-browser-opening-for-bsd into release2.3.2 2020-07-10 04:37:35 +00:00
Owner

This removes the other version of the http.OpenInBrowser function in favor of having linux and all other systems (aside from Darwin and Windows) attempt to use xdg-open. Systems that do not have this avialable will get an error message saying as much. This will allow BSD systems to open http links in their browsers whereas this was previously blocked for no good reason (other than ignorance as to whether BSD supported xdg-open; now that I know it does I would like to be able to use this fature on my FreeBSD system).

This removes the `other` version of the `http.OpenInBrowser` function in favor of having linux and all other systems (aside from Darwin and Windows) attempt to use `xdg-open`. Systems that do not have this avialable will get an error message saying as much. This will allow BSD systems to open http links in their browsers whereas this was previously blocked for no good reason (other than ignorance as to whether BSD supported `xdg-open`; now that I know it does I would like to be able to use this fature on my FreeBSD system).
Author
Owner

It also removes unneeded build tags from the darwin and windows files and replaces them with comments so that there will be no confusion later as to how go knows which to pick.

It also removes unneeded build tags from the darwin and windows files and replaces them with comments so that there will be no confusion later as to how go knows which to pick.
sloum merged commit f8a9465eaf into release2.3.2 2020-07-10 04:37:35 +00:00
sloum deleted branch fixes-browser-opening-for-bsd 2020-07-10 04:37:46 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#180
No description provided.