Uses 'linux' OpenInBrowser settings for any non-darwin and non-windows os #180
No reviewers
Labels
No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sloum/bombadillo#180
Loading…
Reference in New Issue
No description provided.
Delete Branch "fixes-browser-opening-for-bsd"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This removes the
other
version of thehttp.OpenInBrowser
function in favor of having linux and all other systems (aside from Darwin and Windows) attempt to usexdg-open
. Systems that do not have this avialable will get an error message saying as much. This will allow BSD systems to open http links in their browsers whereas this was previously blocked for no good reason (other than ignorance as to whether BSD supportedxdg-open
; now that I know it does I would like to be able to use this fature on my FreeBSD system).It also removes unneeded build tags from the darwin and windows files and replaces them with comments so that there will be no confusion later as to how go knows which to pick.