Removes support for client certificates in Bombadillo #181

Merged
sloum merged 5 commits from remove-client-certs into release2.3.2 2020-07-10 04:46:49 +00:00
Owner

Support for client certs was always kind of only half working as it was. The spec, and the way other clients implement it, has gotten more complex around this concept. I am wanting to keep Bombadillo focused on reading gemini content and not add in overhead for supporting gemini "applications". This is in line with sodlerpunk's view of two branches of clients: readers and application clients (with Bombadilo falling in the former camp).

I believe I removed all references to client certs in the code. If anyone sees anything I missed please let me know. I have tested this build on FreeBSD and Linux and the client, and gemini specifically, seem to work well.

Support for client certs was always kind of only half working as it was. The spec, and the way other clients implement it, has gotten more complex around this concept. I am wanting to keep Bombadillo focused on reading gemini content and not add in overhead for supporting gemini "applications". This is in line with sodlerpunk's view of two branches of clients: readers and application clients (with Bombadilo falling in the former camp). I believe I removed all references to client certs in the code. If anyone sees anything I missed please let me know. I have tested this build on FreeBSD and Linux and the client, and gemini specifically, seem to work well.
Collaborator

I found some references that might need to be removed:

  • The tlscertificate setting is still in defaults.go.
  • The tlscertificate is also still in the config file. I created a new config file and it was still there after it was recreated.

Otherwise everything seems cool.

It's probably not important, but do you think that we should indicate in the manual, or when attempting to visit a place requiring a client certificate, that this functionality is not supported?

I found some references that might need to be removed: - The tlscertificate setting is still in defaults.go. - The tlscertificate is also still in the config file. I created a new config file and it was still there after it was recreated. Otherwise everything seems cool. It's probably not important, but do you think that we should indicate in the manual, or when attempting to visit a place requiring a client certificate, that this functionality is not supported?
Author
Owner

Oh, good call! I knew I had to have missed some.

I have put it into a forthcoming branch for built in help that client certs are not supported (it is in :help gemini). I think updating the messaging in the client is a good idea so someone isnt pulling out their hair trying to figure out how to enable it. I'll get that updated (and the code you mentioned removed) tomorrow.

Oh, good call! I knew I had to have missed some. I have put it into a forthcoming branch for built in help that client certs are not supported (it is in `:help gemini`). I think updating the messaging in the client is a good idea so someone isnt pulling out their hair trying to figure out how to enable it. I'll get that updated (and the code you mentioned removed) tomorrow.
Author
Owner

@asdf I removed the references from defaults.go and added (Unsupported) to the error message about a cert being requested, so users should be able to see that.

I believe now that defaults.go no longer contains those keys that on the next run of the program they should also get removed automatically from .bombadillo.ini.

@asdf I removed the references from `defaults.go` and added `(Unsupported)` to the error message about a cert being requested, so users should be able to see that. I believe now that `defaults.go` no longer contains those keys that on the next run of the program they should also get removed automatically from `.bombadillo.ini`.
sloum merged commit 0e2b80626e into release2.3.2 2020-07-10 04:46:49 +00:00
sloum deleted branch remove-client-certs 2020-07-10 04:46:59 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#181
No description provided.