Removes support for client certificates in Bombadillo #181
No reviewers
Labels
No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sloum/bombadillo#181
Loading…
Reference in New Issue
No description provided.
Delete Branch "remove-client-certs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Support for client certs was always kind of only half working as it was. The spec, and the way other clients implement it, has gotten more complex around this concept. I am wanting to keep Bombadillo focused on reading gemini content and not add in overhead for supporting gemini "applications". This is in line with sodlerpunk's view of two branches of clients: readers and application clients (with Bombadilo falling in the former camp).
I believe I removed all references to client certs in the code. If anyone sees anything I missed please let me know. I have tested this build on FreeBSD and Linux and the client, and gemini specifically, seem to work well.
I found some references that might need to be removed:
Otherwise everything seems cool.
It's probably not important, but do you think that we should indicate in the manual, or when attempting to visit a place requiring a client certificate, that this functionality is not supported?
Oh, good call! I knew I had to have missed some.
I have put it into a forthcoming branch for built in help that client certs are not supported (it is in
:help gemini
). I think updating the messaging in the client is a good idea so someone isnt pulling out their hair trying to figure out how to enable it. I'll get that updated (and the code you mentioned removed) tomorrow.@asdf I removed the references from
defaults.go
and added(Unsupported)
to the error message about a cert being requested, so users should be able to see that.I believe now that
defaults.go
no longer contains those keys that on the next run of the program they should also get removed automatically from.bombadillo.ini
.