sloum/bombadillo
sloum
/
bombadillo
5
27
Fork 7
Code Issues 18 Pull Requests 1 Releases 9 Activity

command-line-cleanup #59

Merged
sloum merged 7 commits from asdf/bombadillo:command-line-cleanup into develop 2019-10-24 01:57:24 +00:00
Conversation 4 Commits 7 Files Changed 3 +24 -6
asdf commented 2019-10-22 04:06:21 +00:00
Collaborator
Copy Link

This change is meant to be completed after the makefile branch is merged in.

The PR contains small enhancements for the command line options -h and -v and associated documentation.

Some wording may be unified in multiple areas, such as the subtitle "a non-web client" being added after the title "Bombadillo".

This change is meant to be completed after the makefile branch is merged in. The PR contains small enhancements for the command line options `-h` and `-v` and associated documentation. Some wording may be unified in multiple areas, such as the subtitle "a non-web client" being added after the title "Bombadillo".
asdf self-assigned this 2019-10-22 04:06:21 +00:00
sloum was assigned by asdf 2019-10-22 04:06:21 +00:00
asdf added the
enhancement
non-functional
non-urgent
 labels 2019-10-22 04:06:21 +00:00
asdf commented 2019-10-22 04:14:07 +00:00
Author
Collaborator
Copy Link

(hoping this can be merged after makefile branch with no issues...)

I don't know if there is much else to change for this PR. Let me know if any suggestions or issues.

(hoping this can be merged after makefile branch with no issues...) I don't know if there is much else to change for this PR. Let me know if any suggestions or issues.
sloum approved these changes 2019-10-22 05:29:50 +00:00
sloum left a comment
Owner
Copy Link

Looks good. A couple small things, but otherwise approved.

Looks good. A couple small things, but otherwise approved.
README.md
@ -21,3 +21,3 @@
git clone https://tildegit.org/sloum/bombadillo.git
cd bombadillo
go install
sudo make install
sloum commented 2019-10-22 05:21:28 +00:00
Owner
Copy Link

This should be:

git clone https://tildegit.org/sloum/bombadillo.git && cd bombadillo
make
sudo make install
This should be: ``` git clone https://tildegit.org/sloum/bombadillo.git && cd bombadillo make sudo make install ```
README.md
@ -32,3 +44,3 @@
#### Troubleshooting
If you run `bombadillo` and get `bombadillo: command not found`, try running `go build` from within the cloned repo. Then try: `./bombadillo`. If that works it means that Go does not install to your path. `go build` added an executable file to the repo directory. Move that file to somewhere on your path. I suggest `/usr/local/bin` on most systems, but that may be a matter of personal preference.
If you run `bombadillo` and get `bombadillo: command not found`, try running `make` from within the cloned repository. Next, try: `./bombadillo`. If this works, it means that the installation was not completed to an area in your `PATH`.
sloum commented 2019-10-22 05:24:44 +00:00
Owner
Copy Link

I'm not sure that this is still relevant. They should be running make as part of the initial install anyway. The path part is still relevant for sure.

Do we want to mention that the standard go commands of build and install are also still valid options for installing the program, but that they are not recommended as they will not also isntall the documentation? Or should we just leave that to people to figure out on their own?

I'm not sure that this is still relevant. They should be running make as part of the initial install anyway. The path part is still relevant for sure. Do we want to mention that the standard go commands of `build` and `install` are also still valid options for installing the program, but that they are not recommended as they will not also isntall the documentation? Or should we just leave that to people to figure out on their own?
asdf added the
blocked
 label 2019-10-23 02:35:54 +00:00
asdf commented 2019-10-23 02:36:45 +00:00
Author
Collaborator
Copy Link

Waiting on #57 before further action is taken.

Waiting on #57 before further action is taken.
asdf removed the
blocked
 label 2019-10-24 01:16:56 +00:00
asdf commented 2019-10-24 01:30:14 +00:00
Author
Collaborator
Copy Link

The changes specific to this PR are now easily visible. Please note that the commits were duplicated because I had to rebase.

The changes specific to this PR are now easily visible. Please note that the commits were duplicated because I had to rebase.
sloum approved these changes 2019-10-24 01:56:40 +00:00
sloum left a comment
Owner
Copy Link

This looks good. I approve. I think the change in the readme may need to get shifted up a bit depending on how the remaining open PR goes, but I think we are good to go merging this in.

This looks good. I approve. I think the change in the readme may need to get shifted up a bit depending on how the remaining open PR goes, but I think we are good to go merging this in.
sloum commented 2019-10-24 01:57:18 +00:00
Owner
Copy Link

Merging in :)

Merging in :)
sloum closed this pull request 2019-10-24 01:57:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Needs clarification

  
bug

Something is not working

  
build

Relating to the build process/toolchain

  
documentation

Relates to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
finger

Relates to the finger module

  
gemini

Relates to the gemini module

  
gopher

Relates to the gopher module

  
help wanted

Need some help

  
http

Relates to the http module

  
in progress

Denotes that a member of the team is actively working on this issue

  
invalid

Something is wrong

  
local

Relates to the local file module

  
needs-info

We do not have enough information for this issue

  
non-code

Does not correpond to code issue

  
non-functional

Code cleanup/refactor

  
non-urgent

Take your time

  
question

A request for comment or open question

  
release

This PR is from develop to master

  
rendering

Relates to visual output

  
suggestion

A suggestion for a feature

  
telnet

Relates to the telnet module

  
terminal

Issues with terminal handling

  
urgent

Handle ASAP

  
wontfix

This won't be fixed

No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
asdf
sloum
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#59
No description provided.
Delete Branch "asdf/bombadillo:command-line-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?