Fixes a glitch that was preventing redirects from getting shown in lynxmode #67

sloum · 2019-10-29T05:16:18Z

sloum commented

2019-10-29 05:16:18 +00:00

This makes it so that if a header check cannot find a content-type header, we assume that whatever we get should be displayed. The specific case that this fixes is redirects (I was having some issues with this).

In the long run we may want more complex header parsing, but I think this is a good call for the time being and solves the issue.

This makes it so that if a header check cannot find a content-type header, we assume that whatever we get should be displayed. The specific case that this fixes is redirects (I was having some issues with this). In the long run we may want more complex header parsing, but I think this is a good call for the time being and solves the issue.

sloum added the

bug

http

labels 2019-10-29 05:16:18 +00:00

asdf commented

2019-10-31 00:48:21 +00:00

I was trying to find an example to test this one, but found a lot of varied behaviour. Some still download because they return 404 for the header request, some redirect differently depending on the browser.

It's clear we won't be able to support every site.

Otherwise, it looks like a good approach to the issue presented, but I can't find a decent place to test it.

I was trying to find an example to test this one, but found a lot of varied behaviour. Some still download because they return 404 for the header request, some redirect differently depending on the browser. It's clear we won't be able to support every site. Otherwise, it looks like a good approach to the issue presented, but I can't find a decent place to test it.

sloum commented

2019-10-31 01:43:20 +00:00

Yeah, it seems that there are a lot of edge cases here. :-/

What do you think? Merge this in as solving at least the redirect issue? Or hold off and try to figure out more edge cases?

Yeah, it seems that there are a lot of edge cases here. :-/ What do you think? Merge this in as solving at least the redirect issue? Or hold off and try to figure out more edge cases?

asdf commented

2019-10-31 03:31:36 +00:00

I'll merge this in. We probably will be best addressing these as they come up naturally.

👍 1

asdf closed this pull request

2019-10-31 03:31:58 +00:00

asdf deleted branch minor-lynxmode-fix

2019-10-31 03:32:12 +00:00

Sign in to join this conversation.

No reviewers