Fix #79 - Prevent changes in telnet breaking terminal display #80

asdf · 2019-11-07T10:33:29Z

asdf commented

2019-11-07 10:33:29 +00:00

Fix for #79. After a telnet session ends, the terminal is reset and reinitialised for Bombadillo.

This fix is different than originally described in #79:

The change was made to telnet/telnet.go and not to client.go. There is already some things in telnet.StartSession() handling terminal settings, so I thought it might fit better there.
This has been implemented as a deferred anonymous function, because there are two statements that need to be executed.
Some changes to comments to document the function and package (as per #65)

If no issues this is ready to go in. It has been tested manually, with Tetris and a few other games, exiting normally as well as abnormally (via ctrl+c) without any impact that I can tell.

Fix for #79. After a telnet session ends, the terminal is reset and reinitialised for Bombadillo. This fix is different than originally described in #79: - The change was made to `telnet/telnet.go` and not to `client.go`. There is already some things in `telnet.StartSession()` handling terminal settings, so I thought it might fit better there. - This has been implemented as a deferred anonymous function, because there are two statements that need to be executed. - Some changes to comments to document the function and package (as per #65) If no issues this is ready to go in. It has been tested manually, with Tetris and a few other games, exiting normally as well as abnormally (via ctrl+c) without any impact that I can tell.

asdf self-assigned this 2019-11-07 10:33:29 +00:00

sloum was assigned by asdf

2019-11-07 10:33:29 +00:00

asdf added the

bug

telnet

labels 2019-11-07 10:33:29 +00:00

sloum commented

2019-11-07 14:43:23 +00:00

This is great! Really solid fix :) Merging in 👍

This is great! Really solid fix :) Merging in :thumbsup:

sloum closed this pull request