bug in oberon when player chooses to play as player 2 #2

Open
opened 2020-01-13 03:24:02 +00:00 by cmccabe · 0 comments

This refers to the following section of code in the oberon file:

if player == '2':
    temp = enemy
    enemy = username
    player = temp
else:
    player = username

q = "INSERT INTO games VALUES (?, ?, ?, ?, ?, ?, ?)"
v = (player, enemy, game_choice, 'playing', json.dumps(game_board), 1, None)
res = db_do(q, v, True)
if res:
    print('Game between {} and {} created!'.format(username, enemy))
    return True
return False

I think that ".format(username, enemy))" should be ".format(player, enemy))". Otherwise, when a user chooses to play as player two, the message printed to the screen looks like "Game between cmccabe and cmccabe created!" rather than "Game between sloum and cmccabe created!"

Sorry, I don't have Oberon running on my own machine so I can't validate this suggested fix.

This refers to the following section of code in the oberon file: ------------------------------------------------------------------ if player == '2': temp = enemy enemy = username player = temp else: player = username q = "INSERT INTO games VALUES (?, ?, ?, ?, ?, ?, ?)" v = (player, enemy, game_choice, 'playing', json.dumps(game_board), 1, None) res = db_do(q, v, True) if res: print('Game between {} and {} created!'.format(username, enemy)) return True return False ------------------------------------------------------------------ I think that ".format(username, enemy))" should be ".format(player, enemy))". Otherwise, when a user chooses to play as player two, the message printed to the screen looks like "Game between cmccabe and cmccabe created!" rather than "Game between sloum and cmccabe created!" Sorry, I don't have Oberon running on my own machine so I can't validate this suggested fix.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/oberon#2
No description provided.