Commit Graph

55 Commits

Author SHA1 Message Date
Mark Smith 69b2698e8c Revert notes conversion
This temporarily reverts the conversion to using the DW::Request->cache
instead of Apache notes. There were some issues when this went live
briefly and I need to spend more time debugging it.
2022-01-01 01:21:34 +00:00
Mark Smith 88785c5137 Get rid of Apache notes
This switches to using a request cache on the DW::Request object instead
of using Apache notes. This also gives us a facility for observing who
is interacting with request cache -- which might please Nick as it would
let us untangle the wilderness that is Apache notes.
2021-08-23 05:34:54 +00:00
Mark Smith df4f4e10ed Move challenge to DW::Auth::Challenge
As part of cleaning up authentication flows to live in one place, I've
moved challenge generation/checking into a submodule of DW::Auth. Also
wrote some crappy unit tests.
2020-04-25 19:57:42 +00:00
Ruth 8177ed01cf Remove MD5 challenge/response login 2020-04-12 11:53:23 -07:00
Kareila 3eb8dabeb4 [#2320] remove LJ::bad_password_redirect 2019-06-23 10:14:20 -07:00
Mark Smith 1d578e8f17 Remove SSL shenanigans
This diff removes IS_SSL, USE_SSL, USE_HTTPS_EVERYWHERE,
ALL_TRAFFIC_IS_SSL, SSLROOT, SSL*PREFIX, and a bunch of other machinery
that was responsible for SSL management.

This used to be necessary when we had some parts of the site that were
SSL and some weren't, but that's no longer true. These days, the
expectation is that all web traffic is encrypted and that is true on
Dreamwidth and should be true on our hacks and anybody else using our
code, so we can truly simplify the code.

The recommended way for running DW is behind something like Cloudflare
or AWS CloudFront or another proxy service that provides cheap, fast SSL
at scale. If you happen to be running it yourself, you can do the same
with Nginx, Varnish, or your reverse proxy of choice.
2019-06-02 21:14:47 +00:00
Kareila 405ce6642b [#2072] remove <?siteroot?> from form action link on /login
Was showing up as http: regardless of requested protocol.

Just use /pagename - that's what we do most other places.
2017-04-14 01:54:24 -05:00
Kareila 3b9f56d136 remove browselang userprop
Was only set in LJ::Lang::set_lang, which was only called by
LJ/Setting/Language.pm, which was unused and removed.

LJ::Lang::set_lang is retained as a stub for future replacement
of BML::set_language as we move away from using BML.
2017-03-14 14:38:39 -05:00
Kareila ca179ae056 remove langpref cookie support
There was no effective way to ever set the cookie, and even
if there were, the code was never implemented to honor the
value of the cookie on non-BML pages.

Can still override the site's default language on a per-request
basis by using the "uselang" GET parameter.
2017-03-14 14:22:54 -05:00
Kareila b8127fb5bf strip trailing whitespace 2017-03-14 14:22:54 -05:00
Afuna 9a39f5be60 [#1246] Check for https as well as http when checking URLs
* in cgi-bin/Apache/LiveJournal::trans, we need only check against the
  current page's protocol (http or https)

* in other files, we check for both http and https

Fixes #1246.
2015-02-25 16:52:10 -08:00
Mark Smith 1ff611e6c1 Remove breadcrumbs
We don't use these anymore, they're dead. Bye code.
2015-01-25 06:35:58 +00:00
Mark Smith 2579e39489 Check in business stats
This was hacked together to provide some quick and dirty 'event count'
metric reporting for Dreamwidth. This was implemented to work with the
Datadog service, but it should be pretty easy to convert the DW::Stats
module to have support for more services.
2014-07-27 17:45:15 +00:00
Afuna 27f730f24a Always use LJ::challenge_check_login 2014-06-09 09:38:59 +08:00
fu 186393085b http://bugs.dwscoalition.org/show_bug.cgi?id=4203
Ahem. Reverse commit.

Patch by fu.
2012-01-27 10:33:26 +08:00
kareila e83f122c6a http://bugs.dwscoalition.org/show_bug.cgi?id=4203
Hush warnings.

Patch by kareila.
2012-01-27 09:40:30 +08:00
fu b04cfa59eb http://bugs.dwscoalition.org/show_bug.cgi?id=3243
Step one in making styling consistent. Consolidate classes as much as possible while only slightly tweaking visual appearance. Also adds a new page under /dev/classes, to help developers.

Patch by fu.
2010-12-28 19:40:54 +08:00
fu 684b811c20 http://bugs.dwscoalition.org/show_bug.cgi?id=2792
Efficiency: use $1 (first group in parentheses) instead of $& (entire matched, which has a performance impact).  Add parentheses where necessary.

Efficiency: use $1 (first group in parentheses) instead of $& (entire matched, which has a performance impact).
2010-12-01 11:40:22 +08:00
fu 0b661aa924 http://bugs.dwscoalition.org/show_bug.cgi?id=1490
Add an empty summary to all tables that are purely for layout, to make it easier to see what they are (and find them later). For some data tables, convert from td+b to th, and tweak styling if necessary.

Patch by fu.
2010-11-17 22:56:06 +08:00
fu d74f20821b http://bugs.dwscoalition.org/show_bug.cgi?id=3149
Block memorial accounts from logging in through the site, and from any activity requiring authentication in the protocol, as a security measure.

Patch by fu.
2010-11-01 22:13:33 +08:00
fu f2b1ad1581 http://bugs.dwscoalition.org/show_bug.cgi?id=712
Enforce ordering on inclusion of resources, so that we can make site scheme CSS come before per-page CSS. Includes a hack to make some pages respect old behavior (so that colors in per-page CSS don't clash with site scheme colors); this is a temporary measure and should be removed as the CSS framework is made consistent.

Patch by fu.
2010-08-26 23:28:16 +08:00
kareila b717881929 http://bugs.dwscoalition.org/show_bug.cgi?id=1207
Rest of cgi-bin, and a few leftover in htdocs.

Patch by kareila.
2010-07-12 18:03:12 +08:00
allen 0634994785 http://bugs.dwscoalition.org/show_bug.cgi?id=2138
New page when viewing a protected entry: if logged in, just present an informative error message. If logged out, show forms to log in via either a Dreamwidth account, or an OpenID account.

Patch by allen.
2010-07-07 12:51:39 +08:00
kareila c529f10f5d http://bugs.dwscoalition.org/show_bug.cgi?id=1788
Remove unused code.

Patch by kareila.
2010-06-25 15:08:51 +08:00
kareila bd32e8295b http://bugs.dwscoalition.org/show_bug.cgi?id=1958
Code cleanup: For cleanliness, remove code that allows site administrators to force users to signify their agreement with the TOS if it changes. Note: new users signing up to the service will still need to say they agree with the TOS.

Patch by kareila.
2010-06-15 15:04:07 +08:00
kareila 47972f3dcf http://bugs.dwscoalition.org/show_bug.cgi?id=2653
Code cleanup -- call the method on the user instead of using a class method, add error-checking

Patch by kareila.
2010-06-07 10:19:38 +08:00
exor674 1cbadf2bab http://bugs.dwscoalition.org/show_bug.cgi?id=2446
Add cookie support to DW::Request, this moves them out of the purview of BML.

Patch by exor674.
2010-04-21 08:48:41 +00:00
denise 846a14d3b4 http://bugs.dwscoalition.org/show_bug.cgi?id=2216
Add appropriate headers to files found in htdocs.

Patch by denise.
2010-02-25 14:49:56 +00:00
denise c9b287091e http://bugs.dwscoalition.org/show_bug.cgi?id=2270
Avoid potential pitfall: top-level htdocs.

Patch by denise.
2010-01-21 15:23:52 +00:00
fu 92a0dd9331 Backed out changeset e4a5fc6f26b1 (misattribution) 2010-01-21 15:18:44 +00:00
kareila 7d45df94bf http://bugs.dwscoalition.org/show_bug.cgi?id=2270
Avoid potential pitfall: top-level htdocs.

Patch by kareila.
2010-01-21 13:22:38 +00:00
mark 351f9daeaa http://bugs.dwscoalition.org/show_bug.cgi?id=2246
Move ljhooks.pl to LJ::Hooks module, update all callers.  All hail find+sed.

Patch by mark.
2009-12-23 17:32:02 +00:00
afuna 418b82b8c5 http://bugs.dwscoalition.org/show_bug.cgi?id=2134
Fix some errors when you view certain pages while logged out.

Patch by afuna.
2009-12-07 04:57:39 +00:00
denise 469f580792 http://bugs.dwscoalition.org/show_bug.cgi?id=1894
Migrate more uses of LJ::get_cap to LJ::User->methods.

Patch by denise.
2009-11-10 04:29:40 +00:00
wyntarvox 5468e5d1af http://bugs.dwscoalition.org/show_bug.cgi?id=1899
Redirect to the homepage if we have a blank referer.

Patch by wyntarvox.
2009-10-21 19:11:20 +00:00
draigwen e3e21592ec http://bugs.dwscoalition.org/show_bug.cgi?id=1557
Replace regexp referer checks with the check_referer function.

Patch by draigwen.
2009-08-13 18:38:11 -05:00
kareila f948f6646a http://bugs.dwscoalition.org/show_bug.cgi?id=1569
Link to /read, not /read/

Patch by kareila.
2009-08-09 01:44:07 +00:00
denise 5f410e1402 http://bugs.dwscoalition.org/show_bug.cgi?id=1552
Check that user object exists.

Patch by denise.
2009-08-04 15:52:13 +00:00
denise 892e72623b http://bugs.dwscoalition.org/show_bug.cgi?id=1464
Remove .bml in links for files in htdocs

Patch by denise.
2009-08-01 14:31:59 +00:00
denise 31f636f494 http://bugs.dwscoalition.org/show_bug.cgi?id=1384
Code cleanup: use journaltype & statusvis methods instead of direct lookups.

Patch by denise.
2009-07-30 11:38:40 -05:00
kareila 5d58c13875 http://bugs.dwscoalition.org/show_bug.cgi?id=1463
Remove the bulk of the FotoBilder code.

Patch by kareila.
2009-07-26 18:27:27 +00:00
denise d33e837c8f http://bugs.dwscoalition.org/show_bug.cgi?id=1399
Clean-up.

Patch by denise.
2009-07-20 18:06:52 +00:00
sophie ac2432169d http://bugs.dwscoalition.org/show_bug.cgi?id=1348
Fix syntax error.

Patch by sophie.
2009-07-11 04:02:07 +00:00
yvi 4144f27f0d http://bugs.dwscoalition.org/show_bug.cgi?id=1348
Replace with Dreamwidth graphics.

Patch by yvi.
2009-06-24 17:02:28 +00:00
denise 235949b3c1 http://bugs.dwscoalition.org/show_bug.cgi?id=1103
Better/more useful error message when the user mistypes their password on login.

Patch by denise.
2009-06-12 21:59:40 +00:00
denise d6ad633312 http://bugs.dwscoalition.org/show_bug.cgi?id=1218
Remove link

Patch by denise.
2009-05-16 05:53:04 +00:00
kareila 18484bf8f0 http://bugs.dwscoalition.org/show_bug.cgi?id=906
Let's be positive! Let's don't not avoid double negatives! Part 1

Patch by kareila.
2009-05-08 13:04:45 +00:00
mark 13dd821389 http://bugs.dwscoalition.org/show_bug.cgi?id=394
Icon swap for Dreamwidth.

All icons in this commit are either taken from or based upon the Silk icon set by Mark James: http://www.famfamfam.com/lab/icons/silk/

They are licensed under the Creative Commons Attribution 2.5 License http://creativecommons.org/licenses/by/2.5/

<user name="nova"> put together the icons and modified them as appropriate.

<user name="rho"> wrote the patch to put them on the site.
2009-04-23 05:23:36 +00:00
denise e18fe5949f http://bugs.dwscoalition.org/show_bug.cgi?id=137
Strip ads from login.bml

Patch by denise.
2009-03-03 14:21:59 +00:00
mark 54dc7ec2f1 http://bugs.dwscoalition.org/show_bug.cgi?id=324
Don't show the 'update journal' box to identity accounts.

Patch by Denise Paolucci <denise@dreamwidth.org>.
2009-02-20 07:10:32 +00:00