solderpunk
/
AV-98
9
21
Fork 15
Code Issues 4 Pull Requests 4 Releases Wiki Activity

Add abbrevs command #13

Merged
solderpunk merged 1 commits from vee/AV-98:vee/abbrevs into master 2020-05-27 18:46:57 +00:00
Conversation 4 Commits 1 Files Changed 1 +9
vee commented 2020-05-27 13:22:45 +00:00
Contributor
Copy Link

It lists all available AV-98 command abbreviations, like we were discussing in #7.

It lists all available AV-98 command abbreviations, like we were discussing in #7.
solderpunk commented 2020-05-27 15:36:44 +00:00
Owner
Copy Link

Thanks, but looks like self.ruler is missing?

Thanks, but looks like self.ruler is missing?
vee commented 2020-05-27 16:17:28 +00:00
Author
Contributor
Copy Link

Oh, that doesn't work for you? That's odd. ruler exists within the base Cmd class and has a default value of = - here is a direct link to its definition in Python 3.8, but I also see it in the other Python versions selectable here (2.7-3.9).

Oh, that doesn't work for you? That's odd. `ruler` exists within the base `Cmd` class and has a default value of `=` - [here](https://github.com/python/cpython/blob/3.8/Lib/cmd.py#L66) is a direct link to its definition in Python 3.8, but I also see it in the other Python versions selectable here (2.7-3.9).
vee commented 2020-05-27 16:20:55 +00:00
Author
Contributor
Copy Link

Also, for more context from the base Cmd class, the reason I implemented this the way I did was to mirror the behavior of the base class' print_topics, which is what prints the output of help.

Also, for more context from the base `Cmd` class, the reason I implemented this the way I did was to [mirror the behavior of the base class](https://github.com/python/cpython/blob/3.8/Lib/cmd.py#L340-L342)' `print_topics`, which is what prints the output of `help`.
solderpunk commented 2020-05-27 18:46:45 +00:00
Owner
Copy Link

Oh, my bad! I just eyeballed the diff and wasn't aware of Cmd.ruler! I've actually tested it now and it works fine. Thank you!

f for fold and fo for forward? What was I thinking?!

Oh, my bad! I just eyeballed the diff and wasn't aware of Cmd.ruler! I've actually tested it now and it works fine. Thank you! `f` for `fold` and `fo` for `forward`? What was I thinking?!
solderpunk closed this pull request 2020-05-27 18:46:57 +00:00
vee deleted branch vee/abbrevs 2020-05-28 12:20:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solderpunk/AV-98#13
No description provided.
Delete Branch "vee/AV-98:vee/abbrevs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?