Certificate validity checks should be using UTC time #14
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: solderpunk/AV-98#14
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hey :)
I discovered that immediately after generating a new server cert and attempting to connect to it with AV-98, I was greeted with a certificate validity error.
Digging into the code, it looks like there is a bug where
returns a datetime in my local timezone, whereas cryptography's
not_valid_before
andnot_valid_before
return datetimes in UTC.The most straightforward fix would probably be to just switch over to using UTC for everything
Thanks so much, I've fixed this now!