Add gemini:// support directly to urllib.parse #16

dancek · 2020-06-01T07:25:05Z

dancek commented

2020-06-01 07:25:05 +00:00

I personally find this monkey-patching method more readable than modifying urls before and after using urljoin. A matter of taste, but I just wanted to let you know this works.

I personally find this monkey-patching method more readable than modifying urls before and after using `urljoin`. A matter of taste, but I just wanted to let you know this works.

solderpunk referenced this issue from a commit

2020-06-02 18:45:49 +00:00

Merge pull request 'Add gemini:// support directly to urllib.parse' (#16) from dancek/AV-98:simplify-urljoin into master Thanks a lot! I've never bothered to poke inside `urljoin` before so didn't realise this was so easy to do. I agree that this is far more readable and maintainable.

solderpunk closed this pull request

2020-06-02 18:45:50 +00:00

solderpunk commented

2020-06-02 18:46:55 +00:00

I'll add you to the list of maintainers - do you want me to include the username dancek, the gmail address you have attached to your tildegit profile, or both?

I'll add you to the list of maintainers - do you want me to include the username `dancek`, the gmail address you have attached to your tildegit profile, or both?

dancek commented

2020-06-02 20:53:18 +00:00

Both is fine, thanks!

Sign in to join this conversation.

No reviewers