Fatal error when server does not return mime in header #20

New Issue

sloum · 2020-06-20T17:42:18Z

sloum commented

2020-06-20 17:42:18 +00:00

I was unsure if molly-brown supported cgi currently or not. So I decided to make a cgi folder in my user folder on rawtext.club and added a simple python script: gemini://rawtext.club/~sloum/cgi/test. All the script does is print 40 The script works to stdout (I did an error code as a part of my debugging this issue, it had formerly been a 20).

In Bombadillo I get the message: "Improperly formatted mimetype received from server". This does ok, but didnt tell me the issue (but does not kill the program). So I tried AV-98 and got the following:

Traceback (most recent call last):
  File "/usr/lib/python3.6/cmd.py", line 214, in onecmd
    func = getattr(self, 'do_' + cmd)
AttributeError: 'GeminiClient' object has no attribute 'do_g'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/av98", line 1008, in <module>
    main()
  File "/usr/local/bin/av98", line 1003, in main
    gc.cmdloop()
  File "/usr/lib/python3.6/cmd.py", line 138, in cmdloop
    stop = self.onecmd(line)
  File "/usr/lib/python3.6/cmd.py", line 216, in onecmd
    return self.default(line)
  File "/usr/local/bin/av98", line 529, in default
    return self.onecmd(expanded)
  File "/usr/lib/python3.6/cmd.py", line 217, in onecmd
    return func(arg)
  File "/usr/local/bin/av98", line 624, in do_go
    self._go_to_gi(GeminiItem(line))
  File "/usr/local/bin/av98", line 269, in _go_to_gi
    status, meta = header.split(maxsplit=1)
ValueError: not enough values to unpack (expected 2, got 1)

I believe what is happening is that molly does not supply a mime if none can be discerned. This means that the response header was likely: 20 \r\n. Neither of our clients like that response. I will open a similar issue for molly to deal with an empty mime (the file test gives no hint as to its type without looking at a shebang, which I guess the go mime library does not do). I would suggest returning text/plain when a mime cannot be discerned.

I was unsure if molly-brown supported cgi currently or not. So I decided to make a `cgi` folder in my user folder on rawtext.club and added a simple python script: `gemini://rawtext.club/~sloum/cgi/test`. All the script does is print `40 The script works` to stdout (I did an error code as a part of my debugging this issue, it had formerly been a 20). In Bombadillo I get the message: "Improperly formatted mimetype received from server". This does ok, but didnt tell me the issue (but does not kill the program). So I tried AV-98 and got the following: ```python3 Traceback (most recent call last): File "/usr/lib/python3.6/cmd.py", line 214, in onecmd func = getattr(self, 'do_' + cmd) AttributeError: 'GeminiClient' object has no attribute 'do_g' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/bin/av98", line 1008, in <module> main() File "/usr/local/bin/av98", line 1003, in main gc.cmdloop() File "/usr/lib/python3.6/cmd.py", line 138, in cmdloop stop = self.onecmd(line) File "/usr/lib/python3.6/cmd.py", line 216, in onecmd return self.default(line) File "/usr/local/bin/av98", line 529, in default return self.onecmd(expanded) File "/usr/lib/python3.6/cmd.py", line 217, in onecmd return func(arg) File "/usr/local/bin/av98", line 624, in do_go self._go_to_gi(GeminiItem(line)) File "/usr/local/bin/av98", line 269, in _go_to_gi status, meta = header.split(maxsplit=1) ValueError: not enough values to unpack (expected 2, got 1) ``` I believe what is happening is that molly does not supply a mime if none can be discerned. This means that the response header was likely: `20 \r\n`. Neither of our clients like that response. I will open a similar issue for molly to deal with an empty mime (the file `test` gives no hint as to its type without looking at a shebang, which I guess the go mime library does not do). I would suggest returning `text/plain` when a mime cannot be discerned.

sloum referenced this issue from solderpunk/molly-brown

2020-06-20 17:47:33 +00:00

Molly sending empty mime type #8

continue referenced this issue

2023-08-27 13:53:56 +00:00

Fix: ValueError if MIME is empty string #41

continue commented

2023-08-27 13:57:49 +00:00

If relevant: fixed in my fork (https://tildegit.org/continue/AV-98).

continue referenced this issue

2023-09-06 20:13:25 +00:00

Fix: ValueError if MIME is empty string (like a #20) #42

solderpunk referenced this issue from a commit

2023-11-12 10:12:39 +00:00

Fix: ValueError if MIME is empty string (like a #20)

solderpunk referenced this issue from a commit

2023-11-12 10:12:39 +00:00

Merge pull request 'Fix: ValueError if MIME is empty string (like a #20)' (#42) from continue/AV-98:fix-empty-mime into master

solderpunk commented

2023-11-12 10:44:17 +00:00

Pretty embarrassed that such a trivial bug stayed open for 3 years, but I'm happy to close this issue now after merging the PR that @continue provided.

solderpunk closed this issue

2023-11-12 10:44:17 +00:00

Sign in to join this conversation.