solderpunk
/
molly-brown
7
29
Fork 10
Code Issues 9 Pull Requests Releases Wiki Activity

molly-brown doesn't respect Port in config #1

New Issue
Closed
opened 2020-05-21 07:04:41 +00:00 by strega-nil · 5 comments
strega-nil commented 2020-05-21 07:04:41 +00:00
Contributor
Copy Link

As I was setting up a beta server for my website, I noticed that, if one sets Port in the config, that option is not respected in molly brown. This should be a simple fix, which I'll PR in a sec.

As I was setting up a beta server for my website, I noticed that, if one sets `Port` in the config, that option is not respected in molly brown. This should be a simple fix, which I'll PR in a sec.
solderpunk commented 2020-05-21 07:11:16 +00:00
Owner
Copy Link

Hey, thanks for the report! But don't worry about the PR - I actually fixed this myself recently but forgot to push the commit here! I've just done it now.

Hey, thanks for the report! But don't worry about the PR - I actually fixed this myself recently but forgot to push the commit here! I've just done it now.
solderpunk commented 2020-05-21 07:11:41 +00:00
Owner
Copy Link

Oh dear, I was six seconds late!

Oh dear, I was six seconds late!
solderpunk commented 2020-05-21 07:52:11 +00:00
Owner
Copy Link

Sorry about the confusion here, I feel bad. :( However, I'm curious about the difference between your PR and my own fix, doesn't tls.Listen need an address string and not a numeric port, or have I missed something? If you tested your version and it worked I might adopt it afterall because it's certainly simpler...

Sorry about the confusion here, I feel bad. :( However, I'm curious about the difference between your PR and my own fix, doesn't `tls.Listen` need an address string and not a numeric port, or have I missed something? If you tested your version and it worked I might adopt it afterall because it's certainly simpler...
strega-nil commented 2020-05-21 20:22:12 +00:00
Author
Contributor
Copy Link

I'm fairly certain my version doesn't work; I pushed when I was tired and didn't test and that is a bad combo.

Otoh, yours does, I think, need an import strconv.

I'm fairly certain my version doesn't work; I pushed when I was tired and didn't test and that is a bad combo. Otoh, yours does, I think, need an `import strconv`.
solderpunk commented 2020-05-21 20:51:54 +00:00
Owner
Copy Link

Whoops, fixed, thanks! Careless use of git add --patch on my part.

Whoops, fixed, thanks! Careless use of `git add --patch` on my part.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
ratelimiting
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solderpunk/molly-brown#1
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?