Support receiving an FQDN version of the domain #20

New Issue

makeworld · 2021-02-04T23:53:35Z

makeworld commented

2021-02-04 23:53:35 +00:00

Source: https://github.com/makeworld-the-better-one/amfora/issues/177

Trying to access gemini://gemini.circumlunar.space./ will return the following error from the server:

Proxy Request Refused: No proxying to other hosts or ports!

The FQDN (domain with dot at the end) should be a valid intepretation of the domain. Ideally Molly Brown would accept a domain with or without an ending dot in the config, and recognize both versions of the domain over the wire.

Source: https://github.com/makeworld-the-better-one/amfora/issues/177 Trying to access `gemini://gemini.circumlunar.space./` will return the following error from the server: > Proxy Request Refused: No proxying to other hosts or ports! The FQDN (domain with dot at the end) should be a valid intepretation of the domain. Ideally Molly Brown would accept a domain with or without an ending dot in the config, and recognize both versions of the domain over the wire.

solderpunk referenced this issue from a commit

2023-01-29 11:30:49 +00:00

Accept requests where the URL has a FQDN hostname with a trailing dot. Closes #20.

solderpunk closed this issue

2023-01-29 11:30:49 +00:00

solderpunk commented

2023-01-29 11:31:46 +00:00

Hi @makeworld, sorry for my absolutely glacial response to this. I've just pushed an update to correct this behaviour.

To my surprise, when I tried to test it in AV-98, I got a weird error from the Python ssl lib. Maybe it is unhappy that the server's certificate has the hostname without the trailing dot in it, not sure. Anyway, I was able to successfully connect to localhost. using Amfora, so I think this is good, please let me know if not.

PS: Testing this was my first time using Amfora in years. Goodness, it looks nice!

Hi @makeworld, sorry for my absolutely glacial response to this. I've just pushed an update to correct this behaviour. To my surprise, when I tried to test it in AV-98, I got a weird error from the Python `ssl` lib. Maybe it is unhappy that the server's certificate has the hostname without the trailing dot in it, not sure. Anyway, I was able to successfully connect to `localhost.` using Amfora, so I think this is good, please let me know if not. PS: Testing this was my first time using Amfora in years. Goodness, it looks nice!

❤️ 1

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solderpunk/molly-brown#20