solderpunk
/
molly-brown
7
29
Fork 10
Code Issues 9 Pull Requests Releases Wiki Activity

TLS close_notify only sent with status code 20 #28

New Issue
Closed
opened 2021-11-10 17:29:23 +00:00 by nervuri · 4 comments
nervuri commented 2021-11-10 17:29:23 +00:00
Copy Link

Tested with Agunua:

$ agunua gemini.circumlunar.space/doesnotexist
Warning, no TLS shutdown received from the server
Problem, Not found (extra message: "Not found!").

$ agunua gemini.circumlunar.space
[all good]
Tested with [Agunua](https://framagit.org/bortzmeyer/agunua): ``` $ agunua gemini.circumlunar.space/doesnotexist Warning, no TLS shutdown received from the server Problem, Not found (extra message: "Not found!"). $ agunua gemini.circumlunar.space [all good] ```
solderpunk commented 2021-11-10 17:57:02 +00:00
Owner
Copy Link

Thanks! I had been meaning to make sure that Molly was doing the right thing here, after the recent spec update. :) I'll look into it.

Thanks! I had been meaning to make sure that Molly was doing the right thing here, after the recent spec update. :) I'll look into it.
nervuri commented 2021-11-20 09:26:57 +00:00
Author
Copy Link

Looks like this is actually wrongly detected by Agunua:

According to portal.mozz.us, Molly does send close_notify on error responses:
https://portal.mozz.us/gemini/gemini.circumlunar.space/doesnotexist?crt=1

The same is reported by openssl s_client:

$ printf "gemini://gemini.circumlunar.space/doesnotexist\r\n" | openssl s_client -ign_eof -connect gemini.circumlunar.space:1965
...
closed
Looks like this is actually wrongly detected by Agunua: * https://framagit.org/bortzmeyer/agunua/-/issues/50 * https://lists.orbitalfox.eu/archives/gemini/2021/007606.html According to portal.mozz.us, Molly does send close_notify on error responses: https://portal.mozz.us/gemini/gemini.circumlunar.space/doesnotexist?crt=1 The same is reported by openssl s_client: ``` $ printf "gemini://gemini.circumlunar.space/doesnotexist\r\n" | openssl s_client -ign_eof -connect gemini.circumlunar.space:1965 ... closed ```
solderpunk commented 2021-11-22 18:22:51 +00:00
Owner
Copy Link

Oh, this is good to know! I had even got to the point of forming a hypothesis about what had gone wrong based on reading the source for Go's TLS library and was starting to feel bad about not having made the time to actually test it yet. Thanks for the update (and for all your TLS-related issues and commentary on the Gitlab repo!).

Oh, this is good to know! I had even got to the point of forming a hypothesis about what had gone wrong based on reading the source for Go's TLS library and was starting to feel bad about not having made the time to actually test it yet. Thanks for the update (and for all your TLS-related issues and commentary on the Gitlab repo!).
nervuri commented 2021-11-26 19:43:25 +00:00
Author
Copy Link

:) Thank you for Gemini! Sorry for wasting your time with this.

:) Thank you for Gemini! Sorry for wasting your time with this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
ratelimiting
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solderpunk/molly-brown#28
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?