solderpunk
/
molly-brown
7
29
Fork 10
Code Issues 9 Pull Requests Releases Wiki Activity

Missing return on error #4

New Issue
Closed
opened 2020-06-12 23:43:52 +00:00 by sloum · 1 comment
sloum commented 2020-06-12 23:43:52 +00:00
Copy Link

At this point in the code there should be a return (right after the log). otherwise more will be written to the response body. Just noticed it while referencing your code to write a server of sorts for myself. Probably not something that comes up a lot in this particular location, but thought you'd want to know.

At [this point](https://tildegit.org/solderpunk/molly-brown/src/branch/master/handler.go#L355) in the code there should be a return (right after the log). otherwise more will be written to the response body. Just noticed it while referencing your code to write a server of sorts for myself. Probably not something that comes up a lot in this particular location, but thought you'd want to know.
solderpunk commented 2020-06-13 07:07:44 +00:00
Owner
Copy Link

Thanks a lot!

Thanks a lot!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
ratelimiting
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solderpunk/molly-brown#4
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?