Don't include port in REMOTE_ADDR #18
Loading…
Reference in New Issue
No description provided.
Delete Branch "makeworld/molly-brown:master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Section 4.1.8 of the CGI RFC (3875) states that
REMOTE_ADDR
should be an IP address.But
conn.RemoteAddr().String()
contains the remote port as well. This broke my CGI application.I've added code so just the IP address will be in
REMOTE_ADDR
. Note the error is ignored, sinceconn.RemoteAddr().String()
will always have a port.Thanks a lot for this fix, makeworld. Have you accidentally committed a compiled executable as well?
d5eb0f9940
to99ba34c2b7
Yikes, thanks for catching that. I'm used to the
.gitignore
keeping it out. I've rewritten the history so the binary was never there, so you should be able to merge without adding it to repo (and increasing its size by several MiBs).Splendid, thanks!