team/site
team
/
site
7
17
Fork 56
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Unnessecary giant javascript libraries are yucky #54

Closed
fosslinux wants to merge 1 commits from fosslinux/tilde.team:remove-js into master
pull from: fosslinux/tilde.team:remove-js
merge into: team:master
Conversation 5 Commits 1 Files Changed 2 -10
fosslinux commented 2020-01-16 06:16:12 +00:00
Contributor
Copy Link

Ignore below unless you need convincing of the title.

Unnecessary giant javascript libraries are yucky like vue and bootstrap and jquery. And also if tilde.team did actually use them (which it didnt) and the CDNs went down the site would break and that would be bad.

So please don't use giant javascript libraries.

Tbh i cant even see why they were there in the first place... they weren't used.

Also very unminimalist and untilde.

Ignore below unless you need convincing of the title. Unnecessary giant javascript libraries are yucky like vue and bootstrap and jquery. And also if tilde.team did actually use them (which it didnt) and the CDNs went down the site would break and that would be bad. So please don't use giant javascript libraries. Tbh i cant even see why they were there in the first place... they weren't used. Also very unminimalist and untilde.
👎 2
ben commented 2020-01-16 13:48:28 +00:00
Owner
Copy Link

This breaks the navbar on mobile. I'd be happy to merge it if we were to pull out the relevant functionality from there.

This breaks the navbar on mobile. I'd be happy to merge it if we were to pull out the relevant functionality from there.
anton commented 2020-01-16 14:16:09 +00:00
Contributor
Copy Link

I think this shouldn't be merged. I like the site working on smaller screen sizes.

I think this shouldn't be merged. I like the site working on smaller screen sizes.
khuxkm commented 2020-01-16 14:45:37 +00:00
Owner
Copy Link

My vote is for not doing that. I really feel like avoiding technology for the sake of "big libraries bad" is kinda stupid.

My vote is for not doing that. I really feel like avoiding technology for the sake of "big libraries bad" is kinda stupid.
👍 1
ben commented 2020-01-16 23:15:23 +00:00
Owner
Copy Link

as of 1f4846e02d i've moved the js files to be loaded directly from tilde.team.

i still don't have an easy solution for getting rid of them and i'd be happy to merge something that's simpler or smaller js.

as of 1f4846e02d i've moved the js files to be loaded directly from tilde.team. i still don't have an easy solution for getting rid of them and i'd be happy to merge something that's simpler or smaller js.
ben commented 2020-06-19 02:37:04 +00:00
Owner
Copy Link

If you have a solution to the navbar menu stuff, feel free to reopen this or start a new PR

If you have a solution to the navbar menu stuff, feel free to reopen this or start a new PR
ben closed this pull request 2020-06-19 02:37:06 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: team/site#54
No description provided.
Delete Branch "fosslinux/tilde.team:remove-js"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?