team/site
team
/
site
7
16
Fork 56
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Add a new stuff section on the homepage to show what users are doing #116

Merged
ben merged 3 commits from :add-newstuff-section-home into master 2022-07-18 19:07:27 +00:00
Conversation 4 Commits 3 Files Changed 1 +20 -1
gtlsgamr commented 2022-07-16 14:42:50 +00:00
Contributor
Copy Link

I have added a static section at this point (which is open for debate). Making it dynamic will only make it sound robotic. The current way of announcing what the users are doing makes it look authentic? Not sure. Let me know what you think.

I have added a static section at this point (which is open for debate). Making it dynamic will only make it sound robotic. The current way of announcing what the users are doing makes it look authentic? Not sure. Let me know what you think.
gtlsgamr added 1 commit 2022-07-16 14:42:51 +00:00
continuous-integration/drone/pr Build encountered an error Details
e7270556a3 Update 'index.php'
ben commented 2022-07-18 02:13:27 +00:00
Owner
Copy Link

what do you think about moving it below the <hr> for the user section

what do you think about moving it below the `<hr>` for the user section
gtlsgamr commented 2022-07-18 02:49:35 +00:00
Author
Contributor
Copy Link

The user section has a LOT of users, so it might not have a lot of visibility. Maybe above the user section, but below the news and links sections in a seperate row? How does that sound?

The user section has a LOT of users, so it might not have a lot of visibility. Maybe above the user section, but below the news and links sections in a seperate row? How does that sound?
ben commented 2022-07-18 03:51:51 +00:00
Owner
Copy Link

sure that works for me

sure that works for me
gtlsgamr added 1 commit 2022-07-18 04:49:09 +00:00
continuous-integration/drone/pr Build encountered an error Details
9fdca3bd86 Update 'index.php'
gtlsgamr commented 2022-07-18 04:51:12 +00:00
Author
Contributor
Copy Link

I have updated it accordingly ben.

I have updated it accordingly ben.
ben reviewed 2022-07-18 17:18:53 +00:00
index.php Outdated
@ -121,6 +121,20 @@ $parser = wiki::factory(true);
</div>
</div>
</div>
<div class="row">
ben commented 2022-07-18 17:18:53 +00:00
Owner
Copy Link

let's add an <hr> above this and change the heading to something like "user spotlight"

also please fix the indentation

let's add an `<hr>` above this and change the heading to something like "user spotlight" also please fix the indentation
gtlsgamr commented 2022-07-18 17:36:15 +00:00
Author
Contributor
Copy Link

Done. Also the indentation seems in line with the neighboring code. not sure what needs fixed. sorry about that. I have still fixed what felt like needed fixing.

Done. Also the indentation seems in line with the neighboring code. not sure what needs fixed. sorry about that. I have still fixed what felt like needed fixing.
gtlsgamr added 1 commit 2022-07-18 17:35:38 +00:00
continuous-integration/drone/pr Build encountered an error Details
b1a6f408a2 Update 'index.php'
ben changed title from WIP: Add a new stuff section on the homepage to show what users are doing to Add a new stuff section on the homepage to show what users are doing 2022-07-18 19:07:18 +00:00
ben merged commit 9c7f1db8ba into master 2022-07-18 19:07:27 +00:00
gtlsgamr deleted branch add-newstuff-section-home 2022-07-19 01:47:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: team/site#116
No description provided.
Delete Branch ":add-newstuff-section-home"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?