Fixes #5444 -- Fix typing on delete request.

This commit is contained in:
Buster "Silver Eagle" Neece 2022-05-31 00:46:45 -05:00
parent 6278bbd53d
commit 3c1bec857b
No known key found for this signature in database
GPG Key ID: F1D2E64A0005E80E
2 changed files with 3 additions and 7 deletions

View File

@ -67,7 +67,7 @@ final class RequestsController
ServerRequest $request,
Response $response,
string $station_id,
int $request_id
string $request_id
): ResponseInterface {
$station = $request->getStation();
$media = $this->requestRepo->getPendingRequest($request_id, $station);

View File

@ -34,7 +34,7 @@ class StationRequestRepository extends AbstractStationBasedRepository
parent::__construct($em, $serializer, $environment, $logger);
}
public function getPendingRequest(int $id, Entity\Station $station): ?Entity\StationRequest
public function getPendingRequest(int|string $id, Entity\Station $station): ?Entity\StationRequest
{
return $this->repository->findOneBy(
[
@ -82,11 +82,7 @@ class StationRequestRepository extends AbstractStationBasedRepository
}
// Verify that Track ID exists with station.
$media_item = $this->mediaRepo->findByUniqueId($trackId, $station);
if (!($media_item instanceof Entity\StationMedia)) {
throw new Exception(__('The song ID you specified could not be found in the station.'));
}
$media_item = $this->mediaRepo->requireByUniqueId($trackId, $station);
if (!$media_item->isRequestable()) {
throw new Exception(__('The song ID you specified cannot be requested for this station.'));