tilderadio/AzuraCast
4
0
Fork 0
mirror of https://github.com/AzuraCast/AzuraCast.git synced 2024-06-12 12:24:33 +00:00
Code Issues Releases Wiki Activity

Add in security checks to flow.

Browse Source
This commit is contained in:
Buster "Silver Eagle" Neece 2017-11-02 23:05:47 -05:00
parent 084d916346
commit 4d06a20630
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/App/Service/Flow.php
View File

@ -58,6 +58,8 @@ class Flow
$chunkBaseDir = sys_get_temp_dir() . '/uploads/' . $flowIdentifier;
$chunkPath = $chunkBaseDir . '/' . $flowIdentifier . '.part' . $flowChunkNumber;
$currentChunkSize = (int)$this->request->getParam('flowCurrentChunkSize', 0);
$targetSize = $this->request->getParam('flowTotalSize', 0);
$targetChunks = (int)$this->request->getParam('flowTotalChunks', 0);
@ -65,7 +67,9 @@ class Flow
if ($this->request->isGet()) {
// Force a reupload of the last chunk if all chunks are uploaded, to trigger processing below.
if ($flowChunkNumber !== $targetChunks && file_exists($chunkPath)) {
if ($flowChunkNumber !== $targetChunks
&& file_exists($chunkPath)
&& filesize($chunkPath) == $currentChunkSize) {
return $this->response->withStatus(200, 'OK');
} else {
return $this->response->withStatus(204, 'No Content');
@ -86,6 +90,10 @@ class Flow
@mkdir($chunkBaseDir, 0777, true);
}
if ($file->getSize() !== $currentChunkSize) {
throw new \App\Exception('File size of '.$file->getSize().' does not match expected size of '.$currentChunkSize);
}
$file->moveTo($chunkPath);
}