From bace4da0827a07f9955a0453c187838830bf5f96 Mon Sep 17 00:00:00 2001
From: Buster Neece <buster@busterneece.com>
Date: Sun, 8 Jan 2023 13:21:51 -0600
Subject: [PATCH] Move more components to Composition API.

---
 .../Admin/Permissions/EditModal.vue           |  10 +-
 .../Admin/StorageLocations/EditModal.vue      | 220 +++++++++---------
 .../Stations/Podcasts/EpisodeEditModal.vue    |   4 +-
 .../Stations/SftpUsers/EditModal.vue          |   2 +-
 .../Stations/Streamers/EditModal.vue          |   2 +-
 frontend/vue/functions/useBaseEditModal.js    |  24 +-
 6 files changed, 140 insertions(+), 122 deletions(-)

diff --git a/frontend/vue/components/Admin/Permissions/EditModal.vue b/frontend/vue/components/Admin/Permissions/EditModal.vue
index a731504b7..88e11dd0a 100644
--- a/frontend/vue/components/Admin/Permissions/EditModal.vue
+++ b/frontend/vue/components/Admin/Permissions/EditModal.vue
@@ -99,8 +99,10 @@ const {
                 }
             };
         },
-        getSubmittableFormData(formValue) {
-            let form = {
+        getSubmittableFormData(formRef) {
+            const formValue = formRef.value;
+
+            let formReturn = {
                 name: formValue.name,
                 permissions: {
                     global: formValue.permissions.global,
@@ -109,10 +111,10 @@ const {
             };
 
             forEach(formValue.permissions.station, (row) => {
-                form.permissions.station[row.station_id] = row.permissions;
+                formReturn.permissions.station[row.station_id] = row.permissions;
             });
 
-            return form;
+            return formReturn;
         },
     }
 );
diff --git a/frontend/vue/components/Admin/StorageLocations/EditModal.vue b/frontend/vue/components/Admin/StorageLocations/EditModal.vue
index 7936c1f91..4db9fe4c0 100644
--- a/frontend/vue/components/Admin/StorageLocations/EditModal.vue
+++ b/frontend/vue/components/Admin/StorageLocations/EditModal.vue
@@ -1,6 +1,6 @@
 <template>
     <modal-form
-        ref="modal"
+        ref="$modal"
         :loading="loading"
         :title="langTitle"
         :error="error"
@@ -12,122 +12,130 @@
     </modal-form>
 </template>
 
-<script>
-import {required} from '@vuelidate/validators';
-import BaseEditModal from '~/components/Common/BaseEditModal';
-import StorageLocationForm from './Form';
-import useVuelidate from "@vuelidate/core";
-import {computed} from "vue";
-import {useResettableRef} from "~/functions/useResettableRef";
+<script setup>
+import {baseEditModalProps, useBaseEditModal} from "~/functions/useBaseEditModal";
+import {computed, ref} from "vue";
+import {required} from "@vuelidate/validators";
+import {useTranslate} from "~/vendor/gettext";
+import ModalForm from "~/components/Common/ModalForm.vue";
+import StorageLocationForm from "./Form.vue";
 
-/* TODO Options API */
+const props = defineProps({
+    ...baseEditModalProps,
+    type: {
+        type: String,
+        required: true
+    }
+});
 
-export default {
-    name: 'AdminStorageLocationsEditModal',
-    components: {StorageLocationForm},
-    mixins: [BaseEditModal],
-    props: {
-        type: {
-            type: String,
-            required: true
-        }
-    },
-    setup() {
-        const blankForm = {
-            'adapter': 'local',
-            'path': '',
-            's3CredentialKey': null,
-            's3CredentialSecret': null,
-            's3Region': null,
-            's3Version': 'latest',
-            's3Bucket': null,
-            's3Endpoint': null,
-            'dropboxAuthToken': null,
-            'sftpHost': null,
-            'sftpPort': '22',
-            'sftpUsername': null,
-            'sftpPassword': null,
-            'sftpPrivateKey': null,
-            'sftpPrivateKeyPassPhrase': null,
-            'storageQuota': ''
-        }
+const emit = defineEmits(['relist']);
 
-        const {record: form, reset: resetForm} = useResettableRef(blankForm);
+const $modal = ref(); // Template Ref
 
-        const validations = computed(() => {
-            let validationRules = {
-                'adapter': {required},
-                'storageQuota': {},
-                'path': {},
-                's3CredentialKey': {},
-                's3CredentialSecret': {},
-                's3Region': {},
-                's3Version': {},
-                's3Bucket': {},
-                's3Endpoint': {},
-                'dropboxAuthToken': {},
-                'sftpHost': {},
-                'sftpPort': {},
-                'sftpUsername': {},
-                'sftpPassword': {},
-                'sftpPrivateKey': {},
-                'sftpPrivateKeyPassPhrase': {}
-            };
-
-            switch (form.value.adapter) {
-                case 'local':
-                    validationRules.path = {required};
-                    break;
-
-                case 'dropbox':
-                    validationRules.dropboxAuthToken = {required};
-                    break;
-
-                case 's3':
-                    validationRules.s3CredentialKey = {required};
-                    validationRules.s3CredentialSecret = {required};
-                    validationRules.s3Region = {required};
-                    validationRules.s3Version = {required};
-                    validationRules.s3Bucket = {required};
-                    validationRules.s3Endpoint = {required};
-                    break;
-
-                case 'sftp':
-                    validationRules.sftpHost = {required};
-                    validationRules.sftpPort = {required};
-                    validationRules.sftpUsername = {required};
-                    break;
-            }
-
-            return validationRules;
-        });
-
-        const v$ = useVuelidate(validations, form);
-
-        return {
-            form,
-            resetForm,
-            v$
+const {
+    loading,
+    error,
+    isEditMode,
+    v$,
+    clearContents,
+    create,
+    edit,
+    doSubmit,
+    close
+} = useBaseEditModal(
+    props,
+    emit,
+    $modal,
+    (formRef) => computed(() => {
+        let validationRules = {
+            'adapter': {required},
+            'storageQuota': {},
+            'path': {},
+            's3CredentialKey': {},
+            's3CredentialSecret': {},
+            's3Region': {},
+            's3Version': {},
+            's3Bucket': {},
+            's3Endpoint': {},
+            'dropboxAuthToken': {},
+            'sftpHost': {},
+            'sftpPort': {},
+            'sftpUsername': {},
+            'sftpPassword': {},
+            'sftpPrivateKey': {},
+            'sftpPrivateKeyPassPhrase': {}
         };
-    },
-    computed: {
-        langTitle() {
-            return this.isEditMode
-                ? this.$gettext('Edit Storage Location')
-                : this.$gettext('Add Storage Location');
+
+        switch (formRef.value.adapter) {
+            case 'local':
+                validationRules.path = {required};
+                break;
+
+            case 'dropbox':
+                validationRules.dropboxAuthToken = {required};
+                break;
+
+            case 's3':
+                validationRules.s3CredentialKey = {required};
+                validationRules.s3CredentialSecret = {required};
+                validationRules.s3Region = {required};
+                validationRules.s3Version = {required};
+                validationRules.s3Bucket = {required};
+                validationRules.s3Endpoint = {required};
+                break;
+
+            case 'sftp':
+                validationRules.sftpHost = {required};
+                validationRules.sftpPort = {required};
+                validationRules.sftpUsername = {required};
+                break;
         }
+
+        return validationRules;
+    }),
+    {
+        'adapter': 'local',
+        'path': '',
+        's3CredentialKey': null,
+        's3CredentialSecret': null,
+        's3Region': null,
+        's3Version': 'latest',
+        's3Bucket': null,
+        's3Endpoint': null,
+        'dropboxAuthToken': null,
+        'sftpHost': null,
+        'sftpPort': '22',
+        'sftpUsername': null,
+        'sftpPassword': null,
+        'sftpPrivateKey': null,
+        'sftpPrivateKeyPassPhrase': null,
+        'storageQuota': ''
     },
-    methods: {
-        getSubmittableFormData() {
-            if (this.isEditMode) {
-                return this.form;
+    {
+        getSubmittableFormData: (formRef, isEditModeRef) => {
+            if (isEditModeRef.value) {
+                return formRef.value;
             }
 
             return {
-                ...this.form,
-                type: this.type
+                ...formRef.value,
+                type: props.type
             };
         }
     }
-};
+);
+
+const {$gettext} = useTranslate();
+
+const langTitle = computed(() => {
+    return isEditMode.value
+        ? $gettext('Edit Storage Location')
+        : $gettext('Add Storage Location');
+});
+
+defineExpose({
+    create,
+    edit,
+    close
+});
 </script>
diff --git a/frontend/vue/components/Stations/Podcasts/EpisodeEditModal.vue b/frontend/vue/components/Stations/Podcasts/EpisodeEditModal.vue
index bba11e95f..97596e70a 100644
--- a/frontend/vue/components/Stations/Podcasts/EpisodeEditModal.vue
+++ b/frontend/vue/components/Stations/Podcasts/EpisodeEditModal.vue
@@ -146,8 +146,8 @@ const {
                 publish_time: publishTime
             });
         },
-        getSubmittableFormData: (formValue) => {
-            let modifiedForm = formValue;
+        getSubmittableFormData: (formRef) => {
+            let modifiedForm = formRef.value;
 
             if (modifiedForm.publish_date.length > 0 && modifiedForm.publish_time.length > 0) {
                 let publishDateTimeString = modifiedForm.publish_date + 'T' + modifiedForm.publish_time;
diff --git a/frontend/vue/components/Stations/SftpUsers/EditModal.vue b/frontend/vue/components/Stations/SftpUsers/EditModal.vue
index 31b74169e..7c5e149e5 100644
--- a/frontend/vue/components/Stations/SftpUsers/EditModal.vue
+++ b/frontend/vue/components/Stations/SftpUsers/EditModal.vue
@@ -45,7 +45,7 @@ const {
     props,
     emit,
     $modal,
-    (formIsEditMode) => computed(() => {
+    (formRef, formIsEditMode) => computed(() => {
         return {
             username: {required},
             password: formIsEditMode.value ? {} : {required},
diff --git a/frontend/vue/components/Stations/Streamers/EditModal.vue b/frontend/vue/components/Stations/Streamers/EditModal.vue
index c72b0ec0d..be1bb17b1 100644
--- a/frontend/vue/components/Stations/Streamers/EditModal.vue
+++ b/frontend/vue/components/Stations/Streamers/EditModal.vue
@@ -76,7 +76,7 @@ const {
     props,
     emit,
     $modal,
-    (formIsEditMode) => computed(() => {
+    (formRef, formIsEditMode) => computed(() => {
         return {
             'streamer_username': {required},
             'streamer_password': (formIsEditMode.value) ? {} : {required},
diff --git a/frontend/vue/functions/useBaseEditModal.js b/frontend/vue/functions/useBaseEditModal.js
index 176cae3d6..7c64e6e00 100644
--- a/frontend/vue/functions/useBaseEditModal.js
+++ b/frontend/vue/functions/useBaseEditModal.js
@@ -1,8 +1,9 @@
 import {computed, ref, toRef} from "vue";
-import {useVuelidateOnForm} from "~/functions/useVuelidateOnForm";
 import mergeExisting from "~/functions/mergeExisting";
 import {useNotify} from "~/vendor/bootstrapVue";
 import {useAxios} from "~/vendor/axios";
+import {useResettableRef} from "~/functions/useResettableRef";
+import useVuelidate from "@vuelidate/core";
 
 export const baseEditModalProps = {
     createUrl: {
@@ -40,15 +41,17 @@ export function useBaseEditModal(
         return editUrl.value !== null;
     });
 
-    const validations = (typeof originalValidations === 'function')
-        ? originalValidations(isEditMode)
-        : originalValidations;
-
     const blankForm = (typeof originalBlankForm === 'function')
         ? originalBlankForm(isEditMode)
         : originalBlankForm;
 
-    const {form, v$, resetForm: originalResetForm, ifValid} = useVuelidateOnForm(validations, blankForm);
+    const {record: form, reset: originalResetForm} = useResettableRef(blankForm);
+
+    const validations = (typeof originalValidations === 'function')
+        ? originalValidations(form, isEditMode)
+        : originalValidations;
+
+    const v$ = useVuelidate(validations, form);
 
     const resetForm = () => {
         if (typeof options.resetForm === 'function') {
@@ -109,7 +112,7 @@ export function useBaseEditModal(
 
     const getSubmittableFormData = () => {
         if (typeof options.getSubmittableFormData === 'function') {
-            return options.getSubmittableFormData(form.value);
+            return options.getSubmittableFormData(form, isEditMode);
         }
 
         return form.value;
@@ -154,7 +157,12 @@ export function useBaseEditModal(
     };
 
     const doSubmit = () => {
-        ifValid(() => {
+        v$.value.$touch();
+        v$.value.$validate().then((isValid) => {
+            if (!isValid) {
+                return;
+            }
+
             error.value = null;
 
             wrapWithLoading(