adds manual stream info and restructures homepage a bit for readability and accessibility #18

tomasino · 2020-10-09T22:39:43Z

tomasino commented

2020-10-09 22:39:43 +00:00

For accessibility purposes it's good to have the contents of a link describe what it is for. Screenreaders extract links and can read through them, but if it just says "Here" that doesn't tell the user anything. Based on this, I restructured the intro text to try and keep the links descriptive and avoid repetition.

I through an empty alt tag on the tilderadio logo, again for accessibility. That tells screen readers they can skip it as it's for presentation only. The title is otherwise plain text so it works fine on its own.

The one change I didn't do here was to fix the h-level heirarchy. H1's can have H2's inside them, but not jump level to H4. Semantically it's meaningless. We're doing it here because of styling though. I'd prefer to make the slogans into a p-tag with a class and the "how to listen" into an H2 and style each, but that would open a can of worms about site styling that seemed a bigger hurdle.

Ultimately the main point of this PR is to add the manual stream info in to the bottom of the page so people looking to drop the URL into VLC will have something to copy & paste.

For accessibility purposes it's good to have the contents of a link describe what it is for. Screenreaders extract links and can read through them, but if it just says "Here" that doesn't tell the user anything. Based on this, I restructured the intro text to try and keep the links descriptive and avoid repetition. I through an empty alt tag on the tilderadio logo, again for accessibility. That tells screen readers they can skip it as it's for presentation only. The title is otherwise plain text so it works fine on its own. The one change I didn't do here was to fix the h-level heirarchy. H1's can have H2's inside them, but not jump level to H4. Semantically it's meaningless. We're doing it here because of styling though. I'd prefer to make the slogans into a p-tag with a class and the "how to listen" into an H2 and style each, but that would open a can of worms about site styling that seemed a bigger hurdle. Ultimately the main point of this PR is to add the manual stream info in to the bottom of the page so people looking to drop the URL into VLC will have something to copy & paste.

deepend referenced this issue from a commit

2020-10-10 02:04:15 +00:00

Merge pull request 'adds manual stream info and restructures homepage a bit for readability and accessibility' (#18) from tomasino/tilderadio-site:homepage-tweaks into master Reviewed-on: https://tildegit.org/tilderadio/site/pulls/18

deepend merged commit 55df3c66fb into master

2020-10-10 02:04:18 +00:00

ben commented

2020-10-10 15:45:40 +00:00

fyi https://tilderadio.org/listen redirects to that ogg url. it works in all the clients ive tested

Sign in to join this conversation.

No reviewers