PHP is annoying and I want to stab whoever designed AzuraCast's API #17

Merged
deepend merged 1 commits from :master into master 9 months ago
khuxkm commented 9 months ago

From the top:

  • gmdate needs an argument of what time to use. this one is on me being tired, but I shouldn't have to do this because
  • IDs are per-DJ, not per-slot, as I mentioned in my last PR. This wasn't the reason behind the issue, but if IDs were per-slot, my original dedupe would have worked perfectly.
  • AzuraCast's API gives weird ISO-8601 date strings instead of just giving us UNIX timestamps. Again, not the reason behind the issue, but it annoyed me when testing the dedupe fix.
From the top: - gmdate needs an argument of what time to use. this one is on me being tired, but I shouldn't have to do this because - IDs are per-DJ, not per-slot, as I mentioned in my last PR. This wasn't the reason behind the issue, but if IDs were per-slot, my original dedupe would have worked *perfectly*. - AzuraCast's API gives weird ISO-8601 date strings instead of just *giving us UNIX timestamps*. Again, not the reason behind the issue, but it annoyed me when testing the dedupe fix.
deepend merged commit eda12ccb4a into master 9 months ago
continuous-integration/drone/pr Build encountered an error
The pull request has been merged as eda12ccb4a.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.