tildeverse
/
cryptpad
4
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hack around a safari bug (for what I'm sure is not the last time)

This commit is contained in:
ansuz 2022-09-19 16:01:45 +05:30
parent 385c0d4d88
commit 3323f09255
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
www/pad/wysiwygarea-plugin.js
View File

@ -39,7 +39,18 @@ define(['/api/config'], function (ApiConfig) {
}
// CryptPad
src = '/pad/ckeditor-inner.html?' + ApiConfig.requireConf.urlArgs;
/*
As of version 16, Safari (Desktop) and all browsers on iOS cannot load rich text.
Their release notes claim they "Fixed incorrect CORP/COEP check in 304 responses",
and it seems whatever they did interacts poorly with our recent (CryptPad@5.1.0)
changes to caching rules in our example NGINX config. Hardcoding a cache-busting string
which does not include "ver=" lets us treat 'ckeditor-inner.html' as a special case,
so that we don't have to revert our minor caching improvements solely for one terrible
browser engine.
*/
// src = '/pad/ckeditor-inner.html?' + ApiConfig.requireConf.urlArgs;
src = ApiConfig.httpSafeOrigin + '/pad/ckeditor-inner.html?0.0.0';
iframe = CKEDITOR.dom.element.createFromHtml( '<iframe src="' + src + '" frameBorder="0"></iframe>' );
iframe.setStyles( { width: '100%', height: '100%' } );