minor text corrections based on my previous contribution #57

Merged
ben merged 14 commits from alexlehm/tilde.chat:minor-corrections into master 2023-02-11 15:34:39 +00:00
Contributor

there was 1 link wrong (nicks), a few typos and I made some text clearer I hope

also I added a note how to preview from a tilde server when running locally

there was 1 link wrong (nicks), a few typos and I made some text clearer I hope also I added a note how to preview from a tilde server when running locally
alexlehm added 12 commits 2023-01-26 00:07:07 +00:00
continuous-integration/drone/pr Build encountered an error Details
27a5527fcc
formatting
continuous-integration/drone/pr Build encountered an error Details
a13374385a
note about settings
continuous-integration/drone/pr Build encountered an error Details
1644f446ce
secure password
continuous-integration/drone/pr Build encountered an error Details
d548e43c00
use irc.tilde.chat and ssl connection
continuous-integration/drone/pr Build encountered an error Details
bc53ed9220
formatting
continuous-integration/drone/pr Build encountered an error Details
bcfd075ec1
minor text corrections, make a few things clearer
add a note to readme how to preview from a tilde server
khuxkm requested changes 2023-01-27 05:11:26 +00:00
khuxkm left a comment
Owner

gave this one a quick readthrough; it seems fine aside from a few things I noticed

gave this one a quick readthrough; it seems fine aside from a few things I noticed
@ -13,3 +13,3 @@
## First connection
Start weechat on your linux shell and type the following commands:
Start **weechat** on your linux shell and type the following commands
Owner

not sure this is necessary; the line as it is is correct

not sure this is necessary; the line as it is is correct
alexlehm marked this conversation as resolved
@ -21,3 +21,1 @@
username used is the same as your linux account, this is should be
unique, if it is not you will be called username1 or similar, then you
should chose another nickname. You do that by using the /nick command
username used is your linux account, this is has to be unique, if
Owner

"this is has to be unique" is still not how the sentence should be phrased; should be "this has to be unique"

"this is has to be unique" is still not how the sentence should be phrased; should be "this has to be unique"
alexlehm marked this conversation as resolved
@ -23,1 +21,3 @@
should chose another nickname. You do that by using the /nick command
username used is your linux account, this is has to be unique, if
someone else registered your name already and is online you will be
called **username1**, then you should chose another nickname. You do
Owner

the "or similar" is important because if you're not the only person trying to use username, you'll be username2 or username3 or whatever.

the "or similar" is important because if you're not the only person trying to use `username`, you'll be `username2` or `username3` or whatever.
alexlehm marked this conversation as resolved
@ -26,3 +27,3 @@
(If you didn't chose a username that is unique in the tilde network,
you had kind of bad luck.)
you have kind of bad luck.)
Owner

"if you didn't chose [sic] a username that is unique in the tilde network, you had kind of bad luck" is correct (except for "chose" instead of "choose"), since both verbs are in the past tense.

"if you didn't chose [sic] a username that is unique in the tilde network, you had kind of bad luck" is correct (except for "chose" instead of "choose"), since both verbs are in the past tense.
alexlehm marked this conversation as resolved
@ -76,3 +77,2 @@
For more information about the program, see the
[manual](https://weechat.org/files/doc/stable/weechat_user.en.html)
For more information about the program, see the [weechat
Owner

meh, I'd rather this sentence be written as "for more information on weechat, see the manual" with manual being the link text, since it's the manual of weechat, which is the focus of this page. no need to clarify in the link text that this is specifically the weechat manual; that's implied by it being on the weechat page (and would be further implied with my suggested phrasing)

meh, I'd rather this sentence be written as "for more information on weechat, see the manual" with manual being the link text, since it's the manual of weechat, which is the focus of this page. no need to clarify in the link text that this is specifically the weechat manual; that's implied by it being on the weechat page (and would be further implied with my suggested phrasing)
alexlehm marked this conversation as resolved
alexlehm added 1 commit 2023-01-27 11:40:16 +00:00
continuous-integration/drone/pr Build encountered an error Details
5a27f6161d
include changed suggested by khuxkm on the PR
alexlehm requested review from khuxkm 2023-01-27 11:40:52 +00:00
khuxkm requested changes 2023-01-27 22:54:52 +00:00
khuxkm left a comment
Owner

Just one more thing and then it should be great!

Just one more thing and then it should be great!
@ -23,1 +21,3 @@
should chose another nickname. You do that by using the /nick command
username used is your linux account, this has to be unique, if
someone else registered your name already and is online you will be
called **username1** or similar, then you should chose another nickname. You do
Owner

chose to choose here too

chose to choose here too
alexlehm marked this conversation as resolved
alexlehm added 1 commit 2023-01-28 00:53:01 +00:00
continuous-integration/drone/pr Build encountered an error Details
eb691f4ab6
chose -> choose
alexlehm requested review from khuxkm 2023-01-28 00:53:59 +00:00
alexlehm changed title from minor text corrections based on my previous contribution to WIP: minor text corrections based on my previous contribution 2023-02-04 23:02:29 +00:00
Author
Contributor

i believe it is not wip anymore

i believe it is not wip anymore
alexlehm changed title from WIP: minor text corrections based on my previous contribution to minor text corrections based on my previous contribution 2023-02-04 23:06:07 +00:00
ben merged commit 6e481daf06 into master 2023-02-11 15:34:39 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tildeverse/tilde.chat#57
No description provided.