Merge pull request #1204 from thiagofportella/master

Display unsave link for previously saved stories

app/views/stories/_listdetail.html.erb

@@ -155,14 +155,15 @@ class="story <%= story.current_upvoted? ? "upvoted" : "" %>
           <% if single_story && story.hider_count > 0 %>
             (hidden by <%= pluralize(story.hider_count, "user") %>)
           <% end %>
-          <% if story.is_saved_by_cur_user %>
-            <span> | </span><%= link_to "unsave", story_unsave_path(story.short_id),
-              :class => "saver" %>
-          <% else %>
+          <% if !story.is_saved_by_cur_user %>
             <span> | </span><%= link_to "save", story_save_path(story.short_id),
-              :class => "saver" %>
+                                       :class => "saver" %>
           <% end %>
         <% end %>
+        <% if story.is_saved_by_cur_user %>
+          <span> | </span><%= link_to "unsave", story_unsave_path(story.short_id),
+                                      :class => "saver" %>
+        <% end %>
         <% if story.url.present? %>
           <span> | </span>
           <span class="dropdown_parent">

spec/features/read_story_spec.rb

@@ -3,10 +3,10 @@
 require "rails_helper"
 
 RSpec.feature "Reading Stories", type: :feature do
-  let!(:story) { create(:story) }
-  let!(:comment) { create(:comment, story: story) }
-
   feature "when logged out" do
+    let!(:story) { create(:story) }
+    let!(:comment) { create(:comment, story:) }
+
     scenario "reading a story" do
       visit "/s/#{story.short_id}"
       expect(page).to have_content(story.title)
@@ -16,6 +16,8 @@ RSpec.feature "Reading Stories", type: :feature do
 
   feature "when logged in" do
     let(:user) { create(:user) }
+    let!(:story) { create(:story) }
+    let!(:comment) { create(:comment, story:) }
 
     before(:each) { stub_login_as user }
 
@@ -32,6 +34,8 @@ RSpec.feature "Reading Stories", type: :feature do
   end
 
   feature "reading merged stories" do
+    let!(:story) { create(:story) }
+    let!(:comment) { create(:comment, story:) }
     let!(:merged) { create(:story, merged_into_story: story) }
 
     it "redirects links" do
@@ -59,4 +63,43 @@ RSpec.feature "Reading Stories", type: :feature do
       expect(page).to have_selector("span.merge")
     end
   end
+
+  feature "reading saved stories" do
+    let(:user) { create(:user) }
+    let!(:user_edited_story) { create(:story, editor: user) }
+
+    before do
+      stub_login_as user
+      SavedStory.save_story_for_user(user_edited_story.id, user.id)
+    end
+
+    scenario "when story is deleted" do
+      visit "/saved"
+
+      expect(page).not_to have_css("a.saver", text: "save", exact_text: true)
+      expect(page).to have_link("unsave")
+    end
+
+    scenario "when story is available" do
+      visit "/saved"
+
+      expect(page).not_to have_css("a.saver", text: "save", exact_text: true)
+      expect(page).to have_link("unsave")
+    end
+  end
+
+  feature "reading deleted stories" do
+    let(:user) { create(:user) }
+    let!(:deleted_story) { create(:story, is_deleted: true) }
+
+    before do
+      stub_login_as user
+      visit "/"
+    end
+
+    it "does not display saver links" do
+      expect(page).not_to have_css("a.saver", text: "save", exact_text: true)
+      expect(page).not_to have_link("unsave")
+    end
+  end
 end