rubocop: Lint/UselessAssignment, 685

app/controllers/comments_controller.rb

@@ -266,10 +266,7 @@ class CommentsController < ApplicationController
       @cur_url = "/threads"
     end
 
-    thread_ids = @showing_user.recent_threads(
-      20,
-      include_submitted_stories = !!(@user && @user.id == @showing_user.id)
-    )
+    thread_ids = @showing_user.recent_threads(20, !!(@user && @user.id == @showing_user.id))
 
     comments = Comment.where(
       :thread_id => thread_ids

app/models/search.rb

@@ -173,7 +173,7 @@ class Search
       end
     end
 
-  rescue ActiveRecord::StatementInvalid => e
+  rescue ActiveRecord::StatementInvalid
     # this is most likely bad boolean chars
     self.results = []
     self.total_results = -1

extras/sponge.rb

@@ -201,7 +201,7 @@ class Sponge
           res = host.get(path, send_headers)
         end
       end
-    rescue Timeout::Error => e
+    rescue Timeout::Error
       dputs "timed out during #{method}"
       return nil
     end
@@ -216,8 +216,6 @@ class Sponge
       end
     end
 
-    last_res = res
-
     case res
     when Net::HTTPSuccess
       return res.body

script/mail_new_activity

@@ -77,8 +77,7 @@ Story.where("id > ? AND is_expired = ?", last_story_id, false).order(:id).each d
       next
     end
 
-    domain = Rails.application.domain
-    list = "#{Rails.application.shortname}-#{u.mailing_list_token}@#{ails.application.domain}"
+    list = "#{Rails.application.shortname}-#{u.mailing_list_token}@#{Rails.application.domain}"
 
     IO.popen([{}, "/usr/sbin/sendmail", "-i", "-f", "nobody@#{Rails.application.domain}", u.email],
              "w") do |mail|

script/parse_inbound_mail

@@ -17,7 +17,7 @@ while !STDIN.eof?
   message += STDIN.gets.to_s
 end
 
-parser = EmailParser.new(sender = ARGV[1], recipient = ARGV[0], message)
+parser = EmailParser.new(ARGV[1], ARGV[0], message)
 
 if parser.been_here?
   # avoid looping, quietly