tildeverse
/
tilde.news
mirror of https://github.com/tildeverse/lobsters
5
3
Fork 3
Code Issues 2 Releases Wiki Activity

Fix duplicate url check bug + flag scrolling to top (#1124)

This commit is contained in:
William Karsten 2022-08-24 08:38:26 -05:00 committed by GitHub
parent f15bf560fe
commit f0edc44d33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/assets/javascripts/application.js.erb
View File

@ -172,8 +172,9 @@ class _LobstersFunction {
checkStoryDuplicate(form) {
const formData = new FormData(form);
const action = '/stories/check_url_dupe';
fetch(action, {
method: 'POST',
fetchWithCSRF(action, {
method: 'post',
headers: new Headers({'X-Requested-With': 'XMLHttpRequest'}),
body: formData,
}).then (response => {
response.text().then(text => {
@ -259,7 +260,7 @@ class _LobstersFunction {
const action = form.getAttribute('action');
formData.append('show_tree_lines', true);
fetchWithCSRF (action, {
method: 'POST',
method: 'post',
headers: new Headers({'X-Requested-With': 'XMLHttpRequest'}),
body: formData
})
@ -274,7 +275,7 @@ class _LobstersFunction {
formData.append('preview', 'true');
formData.append('show_tree_lines', 'true');
fetchWithCSRF(action, {
method: 'POST',
method: 'post',
headers: new Headers({'X-Requested-With': 'XMLHttpRequest'}),
body: formData
})
@ -287,12 +288,16 @@ class _LobstersFunction {
}
previewStory(formElement) {
if(!Lobster.curUser)
return Lobster.bounceToLogin();
const formData = new FormData(formElement);
const previewElement = document.getElementById('inside');
fetchWithCSRF('/stories/preview', {
method: 'post',
headers: new Headers({'X-Requested-With': 'XMLHttpRequest'}),
body: formData
}).then (response => {
}).then(response => {
response.text().then(text => {
previewElement.innerHTML = text;
Lobsters.runSelect2();
@ -515,10 +520,11 @@ onPageLoad(() => {
on('change', '#story_title', Lobster.checkStoryTitle);
on('click', '.story #flag_dropdown a', (event) => {
event.preventDefault();
if (event.target.getAttribute('data') != '') {
Lobster.voteStory(parentSelector(event.target, '.story'), -1, event.target.getAttribute('data'));
}
Lobster.removeFlagModal()
Lobster.removeFlagModal();
});
on('click', '#story_fetch_title', (event) => {
@ -570,7 +576,7 @@ onPageLoad(() => {
}
// check for dupe if there's a URL, but not when editing existing
if (document.getElementById('story_url').getAttribute('value') !== "" &&
if (document.getElementById('story_url').value !== "" &&
(!document.querySelector('input[name="_method"]') ||
document.querySelector('input[name="_method"]').getAttribute('value') === 'put')) {
Lobster.checkStoryDuplicate(parentSelector(document.getElementById('story_url'), 'form'));