Commit Graph

2728 Commits

Author SHA1 Message Date
Peter Bhat Harkins 726ae9d1cb several 1 + n queries on mod view of user profile 2023-08-30 16:16:13 -05:00
Peter Bhat Harkins 5bfe500696 use url generators 2023-08-30 11:50:35 -05:00
Peter Bhat Harkins 7298381360 don't log changes to normalized_url 2023-08-30 11:10:59 -05:00
Peter Bhat Harkins 4dd0fe865c fix #1196 mailing list comments 2023-08-30 08:51:33 -05:00
Peter Bhat Harkins fe09e5aa31 replace indent_level with depth in json, discussion in #1195 2023-08-30 08:03:25 -05:00
Peter Bhat Harkins 510fd3cc47 fill in id part of confidence_order immediately on create
Fix #1195
2023-08-29 22:39:25 -05:00
Peter Bhat Harkins 361823e00d less brittle parent tree lines 2023-08-29 22:39:25 -05:00
Peter Bhat Harkins 07bfde6634 fix 500 if user has no threads because they've never commented 2023-08-29 08:09:14 -05:00
Peter Bhat Harkins 73f4c0cab6 alignment fix 2023-08-29 08:03:02 -05:00
Peter Bhat Harkins 9fff6ae927 enable mod_userdir
diff of `rails routes`:

12,13d11
<                              GET      /newest/:user(.:format)                        home#newest_by_user
<                              GET      /newest/:user/page/:page(.:format)             home#newest_by_user
32d29
<                 user_threads GET      /threads/:user(.:format)                       comments#user_threads
120,122c117,132
<                            u GET      /u(.:format)                                   users#tree
<                         user GET      /u/:username(.:format)                         users#show
<                user_standing GET      /u/:username/standing(.:format)                users#standing
---
>                   users_tree GET      /users(.:format)                               users#tree
>                         user GET      /~:username(.:format)                          users#show
>                user_standing GET      /~:username/standing(.:format)                 users#standing
>                              GET      /~:user/stories(/page/:page)(.:format)         home#newest_by_user
>                 user_threads GET      /~:user/threads(.:format)                      comments#user_threads
>                     user_ban POST     /~:username/ban(.:format)                      users#ban
>                   user_unban POST     /~:username/unban(.:format)                    users#unban
>          user_disable_invite POST     /~:username/disable_invitation(.:format)       users#disable_invitation
>           user_enable_invite POST     /~:username/enable_invitation(.:format)        users#enable_invitation
>                            u GET      /u(.:format)                                   redirect(302, /users)
>                              GET      /u/:username(.:format)                         redirect(302, /~%{username})
>                              GET      /@:username(.:format)                          redirect(302, /~%{username})
>                              GET      /u/:username/standing(.:format)                redirect(302, ~%{username}/standing)
>                              GET      /newest/:user(.:format)                        redirect(302, ~%{user}/stories)
>                              GET      /newest/:user(/page/:page)(.:format)           redirect(302, ~%{user}/stories/page/%{page})
>                              GET      /threads/:user(.:format)                       redirect(302, ~%{user}/threads)
125,128d134
<                     user_ban POST     /users/:username/ban(.:format)                 users#ban
<                   user_unban POST     /users/:username/unban(.:format)               users#unban
<          user_disable_invite POST     /users/:username/disable_invitation(.:format)  users#disable_invitation
<           user_enable_invite POST     /users/:username/enable_invitation(.:format)   users#enable_invitation
2023-08-29 07:49:02 -05:00
Peter Bhat Harkins f66f01c9fd
Merge pull request #1193 from lobsters/dependabot/bundler/puma-6.3.1
Bump puma from 6.2.2 to 6.3.1
2023-08-29 07:41:46 -05:00
dependabot[bot] 6c96457654
Bump puma from 6.2.2 to 6.3.1
Bumps [puma](https://github.com/puma/puma) from 6.2.2 to 6.3.1.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v6.2.2...v6.3.1)

---
updated-dependencies:
- dependency-name: puma
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-08-29 12:37:17 +00:00
Peter Bhat Harkins b3d4d48299
~90% perf improvement for rendering comment threads (PR #1190) 2023-08-29 07:35:49 -05:00
Peter Bhat Harkins ce6d39fe69 and one more thing 2023-08-29 07:31:54 -05:00
Peter Bhat Harkins acd4b8fd31 explain the clever bit 2023-08-29 07:27:10 -05:00
Peter Bhat Harkins d7d36af389 whitespace 2023-08-29 07:11:15 -05:00
Peter Bhat Harkins a0edf9cf3b explain the huge savings of the awful kludge 2023-08-28 22:24:55 -05:00
Peter Bhat Harkins 7463e444fb perf: rm two queries for counting similar stories on story show
also cleans out the last of the work scripts for the branch
2023-08-28 17:40:13 -05:00
Peter Bhat Harkins 482e49c1ec fix to match action name 2023-08-28 17:35:11 -05:00
Peter Bhat Harkins 42d3ad4c30 find similar_stories by normalizing, not regexping
Big performance win to drop a query that regexps every URL in stories (400-650ms
in prod).

Fix #931
Relates to #932
2023-08-28 17:35:11 -05:00
Peter Bhat Harkins e37984dec9 fix for stories without comments 2023-08-28 16:59:39 -05:00
Peter Bhat Harkins c24fabfc38 again fix the parent line 2023-08-28 13:31:36 -05:00
Peter Bhat Harkins d3c67f544f fix parent and sibling lines 2023-08-28 12:31:23 -05:00
Peter Bhat Harkins 2acb185f88 thread rendering: story show, user threads, reply 2023-08-24 14:40:03 -05:00
Peter Bhat Harkins ed5be7a41a fix comment replying, improve depth message 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins a175e4b111 test bitpacking fundamentals for recursive cte 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins 9c7f7d751c start for normalizing urls to similar_stories 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins 45dd096406 rate-limit per thread, not per individual comment 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins f489c8ae3b Separate merged_comments from sorting + preloading 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins b2ddcc9a35 limit max reply depth 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins 26b09392b2 rubocop 2023-08-24 03:13:30 -05:00
Peter Bhat Harkins 994ae917c7 fix extra closing tags 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins ace23832fe rm dead calls to arrange_for_user 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 4dd3d66fcd rm TODO
actually a bunch of controllers touch current_vote and I don't want a big refactor
2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 0f9ddbfa69 materialize confidence_order column 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 1e874622ce less bad name for ordering 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins bc0e132071 1 + n in Comment#gone_text 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins dacbbb86fa heinous_inline_partial for story show perf 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 8dd88017a8 fixed paste 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins daaf1ee086 setup for selected bytepack w cache 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 835f1acd6e setup for selected w cache 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins beab5b8e0c setup for selected perf test 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 786d13e9a3 ActiveRecord hackery to access depth and ordpath from Rails 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins ae121bb07a clear cache before run 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins ef571dfd31 integration perf test 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins ea9bd69b26 todo, fix depth warning 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 689461afc2 bytepacked per notes in test_bitpacking
'diff selected selected_bytepack' is ~10k changes, lots of stories have several
top-level 1-score comments whose ids cross the mod 256 boundary
2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 1c49d35800 test of building ordpaths 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 9da1ca10ed finding workaround to concat binary strings, which are fixed-length 2023-08-24 02:54:26 -05:00
Peter Bhat Harkins 60fb9947ca mask to grab lowest byte 2023-08-24 02:54:26 -05:00