Commit Graph

102 Commits

Author SHA1 Message Date
Thomas Dziedzic 7a5fe3d7a9
Update to Rails 7.0 (#1100) 2022-07-06 14:01:46 +00:00
Peter Bhat Harkins 60e86da8cd bump for potential vulnerability 2022-06-01 06:04:06 -05:00
Peter Bhat Harkins aed68f34b5 bump to Rails 6.1.6 for cve 2022-05-18 21:11:36 -05:00
Peter Bhat Harkins e49e1672d7 bump deps for cve, rubocop 2022-03-23 09:35:50 -05:00
Peter Bhat Harkins dff910dda6 bump commonmarker; rubocop 2022-03-04 07:57:27 -06:00
Peter Bhat Harkins be2ccecca1 bump nokogiri for cve 2022-02-26 13:11:00 -06:00
Peter Bhat Harkins fa5e78646e bump puma for cve 2022-02-14 20:00:41 -06:00
Peter Bhat Harkins c543dd5ea6 bump rails for cve; note backup domain 2022-02-13 09:39:52 -06:00
Peter Bhat Harkins e797af2cb3 rm good_migrations
My opinion has changed over the years; I don't see value in maintaining
migrations when prod must be the single source of truth on the schema. Better
to pull the schema from prod than maintain a brittle set of scripts to
reproduce it.
2022-01-04 05:47:36 -06:00
Peter Bhat Harkins 431e67aec3 bump to Rails 6.1.4 2021-10-26 20:54:45 -05:00
Hunter Madison b8d91ca3c3 Configure Rack::Attack to block misbehaving clients 2021-05-23 23:32:18 -05:00
Peter Bhat Harkins 3b6b4eed80 bump nokogiri for GHSA-vr8q-g5c7-m54m 2021-01-16 12:19:55 -06:00
Peter Bhat Harkins b1048fa7c9 update for cve 2020-09-10 07:42:53 -05:00
Peter Bhat Harkins 3ee84d4a47 replace bullet with mini_profiler 2020-08-27 18:48:45 -05:00
Gabriel Baldão 36677b1d06
add simplecov (#862)
100% test coverage is not a goal in and of itself.
2020-08-19 23:24:04 +00:00
Alessandro Minali 142edb664e
Remove 'dynamic_form' (#888)
Old, unmaintained dep for trivial code.
2020-08-19 13:58:43 +00:00
Peter Bhat Harkins 8f2f91ab9a bump Rails version for CVE 2020-08-18 20:38:06 -05:00
Thomas Dziedzic 89d6d84f9c
Rails 6 (#723) 2020-08-19 01:24:25 +00:00
Peter Bhat Harkins 0a5b1b1023 add stats page 2020-07-03 18:29:24 -05:00
Thomas Dziedzic b32bac90b4 fix keybase spec 2020-06-13 02:12:49 +00:00
Peter Bhat Harkins 77c483fe64 rm scout 2020-06-02 22:05:40 -05:00
Peter Bhat Harkins b5f3ed8de5 pin old sprockets
As is traditional for every Rails point release, the asset pipeline broke in a
new and obtuse way. In this case, by hanging puma indefinitely after serving
any page, requiring a kill -9. Pinning an old version; I'll burn 20 hours
unfucking whatever new wrong thing it's doing later.

The asset pipeline is nine years old.
2020-05-19 18:22:52 -05:00
Peter Bhat Harkins 87f2404c08 Ruby 2.7 and bundle update 2020-05-18 23:20:03 -05:00
Peter Bhat Harkins 2d374f01d0 match ruby version for byebug 2020-05-18 19:44:46 -05:00
Peter Bhat Harkins 0105930afa bump rails; rubocop cleanup 2020-05-18 19:28:26 -05:00
Peter Bhat Harkins f09aba2ad8 bump rails 2020-05-16 09:13:44 -05:00
Peter Bhat Harkins 8a46f78cf6 bump for DOS CVE 2020-03-02 20:37:21 -06:00
Peter Bhat Harkins 5f50c79a20 PDF parsing support for fetch title
Merge #707
2020-03-02 20:34:45 -06:00
Peter Bhat Harkins aa5b0788e7 bump to Rails 5.2.4.1 2020-02-05 08:27:32 -06:00
Matthew Chigira 2b6a569a3b Update Scout gem to 2.6.2 for timeline (#773) 2019-10-21 20:46:17 -07:00
Peter Bhat Harkins 21c69e29bf test transaction_retry gem for mitigating deadlocks
https://github.com/lobsters/lobsters-ansible/issues/39
2019-10-17 21:29:36 -05:00
Peter Bhat Harkins 1b448d916e
bump rubocop (#690) 2019-06-18 06:54:27 -07:00
Thomas Dziedzic d0d2c9b1f9 silence warning about git vs https (#689) 2019-06-18 06:00:17 -07:00
Peter Bhat Harkins 1989831e72 rm sqlite
We haven't attempted to maintain support for it as we've increased our custom
SQL, and it's long been best practice in Rails to use the same database system
in dev as prod.
2019-06-14 09:24:12 -05:00
Thomas Dziedzic a075903a2f use rubocop-rails
the next version of rubocop 0.72 will remove the rails cops

https://github.com/rubocop-hq/rubocop/blob/master/manual/migrate_rails_cops.md
2019-06-13 09:19:32 -05:00
Casey R 5288928056 add scout gem for perf study (#674)
https://lobste.rs/s/5hshvd/proposal_lobste_rs_performance_analysis

Sister sites, you probably want to just ignore/revert this commit.
2019-05-08 22:22:04 +00:00
Abdullah Samman 089f3475ba Migrate deprecated form_tag and form_for to form_with
See next commit for note on running view style checks.
2018-12-09 09:51:30 -06:00
ur5us ff5b7373b5 Switch to database cleaner approach for cleaning up test data
While the previous approach of hand-rolling test data cleanup + setup works
it’s prone to become insufficient with regards to future test scenarios. Recent
commits 6a6da094 and later 4620a9221 highlight the issue.

Using the database cleaner gem provides a cleaner (pun intended) approach to
setup a clean room environment before and after each specific test.

Annotating specs with with `:js` or `truncate` will switch from a transaction
based cleanup strategy to a truncation based one to enable feature/request specs
for which a web server is spun up in separate process by RSpec, in other words
the process executing the spec is not the same as the process handling the
request so RSpec/DatabaseCleaner wouldn’t know when to rollback the transaction.

The downside of this approach might be that RSpec takes a few more seconds to
run all specs.
2018-11-07 07:45:02 -06:00
Peter Bhat Harkins 864e853572 add good_migrations to catch model use 2018-10-17 11:20:28 -05:00
Thomas Dziedzic 4aa925a87b bump factory_bot_rails
also fix deprecations:

```
To automatically update from static attributes to dynamic ones,
install rubocop-rspec and run:

rubocop \
  --require rubocop-rspec \
  --only FactoryBot/AttributeDefinedStatically \
  --auto-correct
```
2018-08-16 13:00:44 +00:00
David Wolgemuth c1681a4063 filter by tag and domain when searching for comments 2018-08-15 08:39:01 -05:00
Peter Bhat Harkins 614f63c658 unpin mysql2 and update
I can't see a reason for us to pin a specific version of this gem.

Closes #532
2018-08-15 07:36:59 -05:00
Peter Bhat Harkins c05becb0fe generate sitemaps
Google's indexing of the site is very spotty, and this seems a lot easier than
improving our builtin search engine.
2018-07-31 22:05:11 -05:00
Peter Bhat Harkins 87b8966ca6 rails complains that this is missing 2018-06-22 20:17:02 -05:00
Peter Bhat Harkins ffc054f207 Revert "add bootsnap"; see #512
This reverts commit e5417d539b.
2018-06-20 08:51:51 -05:00
thomasdziedzic-pd e5417d539b add bootsnap
PR #513, #512
2018-06-20 07:38:21 -05:00
thomasdziedzic-pd 94d9549d5b rails 5.2 upgrade
PR #498, leaves some tasks in #508 and #509
2018-06-14 10:17:19 -05:00
David Wolgemuth 6799938325 replace abandoned Machinist gem with FactoryBot
PR #507
2018-06-14 08:34:59 -05:00
Hunter Madison 7a8497420e Use `scenic-mysql_adapter` over `senic-mysql`
Fixes an irritating bug that kept prefixing the prod database name onto the view, which didn't work in dev.
2018-06-14 08:32:52 -05:00
David Wolgemuth 440c932d63 add byebug to development env 2018-06-13 09:57:45 -05:00