Commit Graph

48 Commits

Author SHA1 Message Date
Peter Bhat Harkins b45d175083 add brakeman
Wrote ignore notes and specs for the security assumptions implied.
Removed TZ from moderations table; everything is Chicago time, best time.
2023-12-17 20:22:47 -06:00
Peter Bhat Harkins 237e219116 standardrb: add standard-sorbet 2023-09-14 08:45:21 -05:00
Peter Bhat Harkins b3d6903f05 standardrb: standard-rails 2023-09-14 08:45:21 -05:00
Peter Bhat Harkins c3f8625788 standardrb
I can't take Rubocop any more. Moving up to Ruby 3 forces us to update RuboCop,
and it comes with dozens of linters that I'd have to evaluate, none of which is
a marginal improvement. I'm done having opinions.
2023-09-08 15:39:50 -05:00
Peter Bhat Harkins a475d9b593 tests, frontend for previous 2022-05-25 09:31:16 -05:00
Peter Bhat Harkins d6cb285df0 only show title h1 on useful pages
Most pages don't need a big h1 because it's clear from the subnav, clear from
the content, or users use them frequently enough to learn and be comfortable.
2022-02-26 13:08:07 -06:00
Peter Bhat Harkins d68f1c4c6d remove @heading and legend; some subnav 2022-02-19 18:01:20 -06:00
Peter Bhat Harkins 7a670a948c sloppy 2022-01-22 08:54:08 -06:00
Peter Bhat Harkins ae7114765c redundant 2022-01-22 08:15:04 -06:00
Peter Bhat Harkins a250c2513c redir user pages with wrong case
Fix #1005
2022-01-22 08:04:14 -06:00
Rishabh Budhiraja 0d4cf82fe6
downcase username in only_user_or_moderator (#1007) 2021-06-19 04:38:11 +00:00
Peter Bhat Harkins 21524de9ed better flash + error messages
We had a confused meta thread today when a screenshot of a user deleting their
account was thought to be a ban.
2020-10-13 21:02:17 -05:00
Peter Bhat Harkins 20c1590753 memoize story/comment score/flags more efficiently 2020-08-08 16:40:28 -05:00
Peter Bhat Harkins 2faf43091e show flagged users their standing against other users 2020-06-01 20:27:55 -05:00
Peter Bhat Harkins 3f69c0eb60 warn heavily flagged users 2020-01-20 17:40:11 -08:00
Peter Bhat Harkins 441786e4c1 typo 2019-08-17 19:02:00 -05:00
Peter Bhat Harkins d8b27bf3df user lists: only pull attributes actually used
These pages change rarely, and with 10k+ users * 23 fields this adds up to
significant memory pressure to fetch/instantiate/gc unused data.
2019-05-09 09:21:23 -05:00
Peter Bhat Harkins aad6f521cf finish rounding out notes 2018-07-19 11:05:19 -05:00
Peter Bhat Harkins bf4327de49 rubocop: Layout/AlignParameters, 708
Seriously considered renaming vote_thusly_on_story_or_comment_for_user_because
just becaues of how many weird linewraps it causes.
2018-03-17 14:06:21 -05:00
Peter Bhat Harkins 8138d9e7a4 rubocop: Style/FrozenStringLiteralComment, 1396
It's a transitional thing, let future me suffer with Ruby 3.0.
2018-03-17 14:04:59 -05:00
Peter Bhat Harkins fda61bb676 rubocop: Layout/DotPosition, 4750 2018-03-01 23:01:39 -06:00
joshua stein dc998b54d4 unbreak rendering html from controllers in rails 5
render :plain was not including the layout, and sending a text/plain
mime type
2017-06-18 17:41:11 -05:00
Adam Hess 28c8217652 Upgrade rails 5 1 (#367)
* Upgrade to rails 5.1

- Update versions of dependencies
- Switch before_filter to before_action
- Use render plain rather than render text

* Generate new rails 5.1 scripts
2017-06-18 11:04:32 -05:00
joshua stein 522b894dd9 users: indentation 2017-03-24 15:34:14 -05:00
joshua stein f397ab1d54 users: don't cache full page, just inner content
otherwise the previous user's header is cached and shown to the next
user
2017-01-16 12:27:19 -06:00
joshua stein c24bb107a0 users: do dumb caching of these big user trees 2017-01-05 15:44:58 -06:00
nyanpasu 39b911963e Remove redundant return 2016-05-16 11:55:16 +08:00
nyanpasu aa0ffeb37b Allow admin/moderator to disable user from inviting 2016-05-16 02:40:46 +08:00
Peter Bhat Harkins b886ea1413 Clean up mysqlism (booleans are also usable as int(1)) (#285)
Clean up mysqlism (booleans are also usable as int(1))
2016-04-23 21:20:10 -04:00
joshua stein cbc1c50cd2 add user banning/unbanning from user view page 2015-07-24 00:51:11 -05:00
joshua stein 8f8ad57135 export a json version of user page, include karma and about text 2015-04-09 21:05:50 -05:00
joshua stein 620389ab95 add /u/?moderators=1 to list all moderators and admins 2015-02-23 16:56:06 -06:00
joshua stein 1eb9413f8a user tree: show newest 10 users 2015-01-27 12:14:26 -06:00
joshua stein 1af0edd268 add a flat version of the user tree, ordered by karma 2014-05-06 21:29:45 -05:00
joshua stein 68a1f02a1c name /u/:username route 2014-01-12 14:22:47 -06:00
Serge Paquet b8652d80cc simplify user tree controller action and template 2014-01-04 03:14:41 -05:00
Serge Paquet 3757b279ff add karma column to users table 2014-01-01 16:03:01 -05:00
Serge Paquet 00228bc120 quote column name for mysql 2013-12-27 18:05:38 -05:00
Serge Paquet 8fbf76b484 use activerecord query interface instead of deprecated finder methods 2013-12-25 16:43:50 -05:00
joshua stein 0aa330d106 user tree: show new users in green 2013-12-02 10:45:21 -06:00
joshua stein 1c0a8dfd03 move after-signup invite page into signup controller 2013-02-25 11:13:44 -06:00
joshua stein de1dc1d430 after a new user signs up, nag them to invite someone 2013-02-22 14:52:22 -06:00
joshua stein 857f2964d7 issue#18: show admin/moderator status on user tree 2012-09-16 15:14:05 -05:00
joshua stein 1987a24a2a properly set @title/@heading everywhere 2012-09-07 09:18:15 -05:00
joshua stein 543f5c12bc user tree 2012-08-24 11:41:35 -05:00
joshua stein 473a026a0e how did all of these tabs get here 2012-08-24 10:57:10 -05:00
joshua stein 578c96d653 more work 2012-06-30 14:14:35 -05:00
joshua stein 093747b796 initial work on conversion from php tree 2012-06-16 20:15:46 -05:00