Commit Graph

114 Commits

Author SHA1 Message Date
Peter Bhat Harkins c3f8625788 standardrb
I can't take Rubocop any more. Moving up to Ruby 3 forces us to update RuboCop,
and it comes with dozens of linters that I'd have to evaluate, none of which is
a marginal improvement. I'm done having opinions.
2023-09-08 15:39:50 -05:00
Peter Bhat Harkins 7f82650795 show merged stories on newest_by_user, deleted to submitter 2023-08-30 17:47:41 -05:00
Peter Bhat Harkins b731305b94 tweak new domain controller - copy, var names, spec 2022-09-01 07:45:18 -05:00
Peter Bhat Harkins a92e9988bd missed using Story.base here 2022-05-06 08:38:40 -05:00
Peter Bhat Harkins 03480e4789 tag pages: show metadata and related tags 2022-03-17 21:37:54 -05:00
Peter Bhat Harkins 7dc65ab173 nav fixups: highlight current page, subnav right edge 2022-03-04 08:48:49 -06:00
Peter Bhat Harkins b52f95bd1e show stories subnav on /recent 2022-03-04 08:12:28 -06:00
Peter Bhat Harkins 0437cc7b4a keep Recent and Threads in top nav 2022-03-02 08:12:38 -06:00
Peter Bhat Harkins 0fb15e4057 clean up app/views/home/index 2022-02-26 21:13:56 -06:00
Peter Bhat Harkins 8be82a4d9e rm @cur_url
This has always made views too informed about controller context instead of the
controller directing the view to render properly, and it was cargo-culted to
many places it wasn't used.
2022-02-26 21:13:05 -06:00
Peter Bhat Harkins d6cb285df0 only show title h1 on useful pages
Most pages don't need a big h1 because it's clear from the subnav, clear from
the content, or users use them frequently enough to learn and be comfortable.
2022-02-26 13:08:07 -06:00
Peter Bhat Harkins 03cbb60d66 stop accepting comments after 90d to avoid /active promoting thread necro 2022-02-19 22:05:10 -06:00
Peter Bhat Harkins 6a84f47205 /active 2022-02-19 20:37:13 -06:00
Peter Bhat Harkins bb0cb2b0d2 extract about pgaes to own controller 2022-02-19 18:45:30 -06:00
Peter Bhat Harkins 91891dc214 saved subnav 2022-02-19 18:18:15 -06:00
Peter Bhat Harkins d68f1c4c6d remove @heading and legend; some subnav 2022-02-19 18:01:20 -06:00
Peter Bhat Harkins 3952d43c65 Fix RSS encoding (#1052) 2022-01-24 07:08:12 -06:00
Peter Bhat Harkins 10bab4a7da fix domain pages showing removed stories 2021-06-23 07:00:30 -05:00
Peter Bhat Harkins 5341d7a067 add tag categories 2020-08-09 08:41:20 -05:00
Alex Pounds 3cdae3fae5 Bugfix: support token-based access for RSS feed of upvoted stories. 2020-06-30 17:17:43 +00:00
Peter Bhat Harkins 52fe5c0d7d encourage sister sites to write own about page 2020-05-15 16:49:20 -05:00
Peter Bhat Harkins 630ace42f8 domain banning 2020-02-10 07:29:02 -06:00
Peter Bhat Harkins 13be6ecb1f sort 2020-01-27 22:15:47 -06:00
Hunter Madison 9aa5828634 fix domain page routing (#811) 2020-01-27 20:10:03 -08:00
Hunter Madison f718da1820 break out Domain model from story, index story text (#797) 2020-01-22 09:33:21 -06:00
Michele Bologna 6e9c98462d Add RSS feed to /top (#805) 2020-01-22 06:17:55 -08:00
Peter Bhat Harkins 07b4804394 we don't do much my/your 2019-07-03 07:52:05 -05:00
Peter Bhat Harkins e88fe0bc80 add /upvoted/comments
On the date - previous anniversary posts use both, but the public announcement
was on the 3rd so I'm going with that.
2019-07-03 06:25:58 -05:00
Brian Kung 6104b13500 multi-tag pages and feeds
PR #664 
Close #525 
Close #542
2019-05-01 13:59:58 +00:00
Jason Schweier 18167b36a5 better handling of deleted stories + comments on user views 2018-11-07 08:28:50 -06:00
Peter Bhat Harkins 4dec19d089 Move tag description on top tagged pages to above stories
It's easy to miss up in the header.
2018-07-29 12:40:31 -05:00
Peter Bhat Harkins 8db5de9265 add mod dashboard: other mods' activity, story + comment hotspots 2018-06-23 09:06:24 -05:00
Peter Bhat Harkins f278565e09 cache full pages for logged-out visitors without tag filters 2018-05-17 09:46:28 -05:00
Peter Bhat Harkins c79fc4f582 include tag name in feed 2018-05-02 07:45:18 -05:00
Peter Bhat Harkins 0ebe0663d2 move StoryRepository#recent to a Story scope and redefine
Redefines /recent to show only low-scoring stories, respect per-user hidden
stories, filtered tags, and to paginate rather than fall back to /newest for
pages after the first.

Close #388
2018-04-26 10:24:03 -05:00
Peter Bhat Harkins 0749e5241b fix from rubocop 2018-03-21 15:57:31 -05:00
Peter Bhat Harkins 604713e97c Merge branch 'rubocop' 2018-03-21 15:19:48 -05:00
avi 905d4c9597 Bugfix: render privacy page properly 2018-03-21 14:15:46 -05:00
Peter Bhat Harkins 449f14787b rubocop: Style/IdenticalConditionalBranches, 62 2018-03-19 16:15:24 -05:00
Peter Bhat Harkins 1bbc0b2f5d rubocop: Layout/SpaceAroundEqualsInParameterDefault, 96 2018-03-19 14:30:49 -05:00
Peter Bhat Harkins 56d8f1a9bf rubocop: Layout/MultilineBlockLayout, 166
Except in user.rb, these were all oddities of 80-char line length.
2018-03-19 10:00:27 -05:00
Peter Bhat Harkins 5b3478dee9 rubocop: Layout/SpaceAfterComma, 189
We had a space after comma in block args the same number of times as not (11),
and having this on enforces where we're consistent in args, arrays, and hashes.
2018-03-19 10:00:27 -05:00
Peter Bhat Harkins eec801d5aa rubocop: Rails/Presence, 248 2018-03-18 19:43:57 -05:00
Peter Bhat Harkins bf1885d87c rubocop: Style/SymbolProc, 374
There were 18 &:foo and 19 {|x| x.foo}, so I updated to the new idiom.
2018-03-18 01:07:08 -05:00
Peter Bhat Harkins a896094b85 rubocop: Style/MutableConstant, 513
We didn't do this anywhere, but it's a cheap way to prevent some bugs.
2018-03-17 19:37:50 -05:00
Peter Bhat Harkins 8b08484a3e rubocop: Style/StringLiteralsInInterpolation, 576
Tidied up with pluralize and adding a helper.
2018-03-17 19:00:47 -05:00
Peter Bhat Harkins fb0a4424e5 rubocop: Lint/AssignmentInCondition, 669 2018-03-17 14:07:35 -05:00
Peter Bhat Harkins 113bb5e9cc rubocop: Layout/MultilineOperationIndentation, 1208 2018-03-17 14:05:32 -05:00
Peter Bhat Harkins 8138d9e7a4 rubocop: Style/FrozenStringLiteralComment, 1396
It's a transitional thing, let future me suffer with Ruby 3.0.
2018-03-17 14:04:59 -05:00
Peter Bhat Harkins 7a4a4a738f rubocop: Style/Documentation, 2270 2018-03-17 14:04:07 -05:00