Using the base URL in path.Join caused it to remove the two slashes (because /////tmp == /tmp):
Then, using that in URL.Parse causes it to see a `https:` scheme, and the / right afterwards means "start a path here", not a hostname, because hostnames begin with two slashes. That's a valid URL, with no hostname. Then it gets turned back into a string:
That's another way of expressing the same URL with no hostname: //<empty hostname>/<path>.
curl, Firefox and Chromium all fix the triple slash automatically, but fasthttp doesn't, and it tries to look up the empty string as a DNS host!
move forward with refactoring:
- initial implementation of a smal "gitea client for fasthttp"
- move constant into const.go
Co-authored-by: 6543 <firstname.lastname@example.org>
Reviewed-by: Otto Richter <email@example.com>
The header is not only necessary on the OPTIONS request, but on any method, so I removed the condition.
Serving any workadventure map was broken BTW. We should have tested this :-(
Reviewed-by: Andreas Shimokawa <firstname.lastname@example.org>
Co-authored-by: Otto Richter <email@example.com>
Co-committed-by: Otto Richter <firstname.lastname@example.org>
The command was using parts from the old os.Args approach and parts from the cli package, and together they didn't work at all. This fixes that and makes the command `pages-server certs remove [domain...]`.
Co-authored-by: Moritz Marquardt <email@example.com>
Co-authored-by: Moritz Marquardt <firstname.lastname@example.org>
Co-committed-by: Moritz Marquardt <email@example.com>
I hope this makes it more inviting to collaborate with us on this project. I'd like to promote the software a little more.
Co-authored-by: fnetx <firstname.lastname@example.org>
Co-authored-by: Otto Richter <email@example.com>
Co-committed-by: Otto Richter <firstname.lastname@example.org>