Using the base URL in path.Join caused it to remove the two slashes (because /////tmp == /tmp):
`https:/tildegit.org/api/v1/repos/owner/name`
Then, using that in URL.Parse causes it to see a `https:` scheme, and the / right afterwards means "start a path here", not a hostname, because hostnames begin with two slashes. That's a valid URL, with no hostname. Then it gets turned back into a string:
`https:///tildegit.org/api/v1/repos/owner/name`
That's another way of expressing the same URL with no hostname: //<empty hostname>/<path>.
curl, Firefox and Chromium all fix the triple slash automatically, but fasthttp doesn't, and it tries to look up the empty string as a DNS host!
move forward with refactoring:
- initial implementation of a smal "gitea client for fasthttp"
- move constant into const.go
Co-authored-by: 6543 <6543@obermui.de>
Reviewed-on: https://codeberg.org/Codeberg/pages-server/pulls/34
Reviewed-by: Otto Richter <otto@codeberg.org>
The header is not only necessary on the OPTIONS request, but on any method, so I removed the condition.
Serving any workadventure map was broken BTW. We should have tested this :-(
Reviewed-on: https://codeberg.org/Codeberg/pages-server/pulls/69
Reviewed-by: Andreas Shimokawa <ashimokawa@noreply.codeberg.org>
Co-authored-by: Otto Richter <otto@codeberg.org>
Co-committed-by: Otto Richter <otto@codeberg.org>
Ben Harris
~lucidiot
6543
Moritz Marquardt
6543
Otto Richter