tildeverse
/
uucp
Archived
7
3
Fork 13
Code Issues 1 Pull Requests 1 Releases Wiki Activity

Small fixes to make the scripts work better #6

Merged
praetor merged 1 commits from jeffallen/uucp:fixes into master 2019-03-26 15:33:53 +00:00
Conversation 6 Commits 1 Files Changed 2 +14 -8
jeffallen commented 2019-03-26 13:34:33 +00:00
Contributor
Copy Link
No description provided.
jeffallen commented 2019-03-26 13:38:35 +00:00
Author
Contributor
Copy Link

When making this pull request I noticed that you've just changed these from >> to >, but I don't see why. It makes it so that each file ends up with only the last node in it, instead of all nodes.

Anyway, I needed ">>" in order to get my UUCP config files created.

When making this pull request I noticed that you've *just* changed these from >> to >, but I don't see why. It makes it so that each file ends up with only the last node in it, instead of all nodes. Anyway, I needed ">>" in order to get my UUCP config files created.
ben commented 2019-03-26 13:45:38 +00:00
Owner
Copy Link

I needed the >> for the generated files for /etc/uucp since I was ending up with many duplicated entries. There was also a bit of discussion re: using stow to get the generated files into /etc/uucp. >> also makes the script not re-runnable.

Thoughts?

I needed the `>>` for the generated files for /etc/uucp since I was ending up with many duplicated entries. There was also a bit of discussion re: using stow to get the generated files into /etc/uucp. `>>` also makes the script *not* re-runnable. Thoughts?
jeffallen commented 2019-03-26 14:00:02 +00:00
Author
Contributor
Copy Link

My understanding is that all the other files are derived from the nodes file. So it should be possible to run ./bootsrtap.pl any time, and the right config files will be generated. As it is currently written, the config files end up with only to information related to the last line of the nodes file.

My understanding is that all the other files are derived from the nodes file. So it should be possible to run ./bootsrtap.pl any time, and the right config files will be generated. As it is currently written, the config files end up with only to information related to the last line of the nodes file.
ben commented 2019-03-26 14:11:53 +00:00
Owner
Copy Link

Ahh ok I see what you're saying. My problem was that the generated files (sys, call, config, etc) were being appended to in subsequent runs rather than being recreated. (I copied instead of moved them to /etc/uucp)

Ahh ok I see what you're saying. My problem was that the generated files (sys, call, config, etc) were being appended to in subsequent runs rather than being recreated. (I copied instead of moved them to /etc/uucp)
ben commented 2019-03-26 14:12:25 +00:00
Owner
Copy Link

Would like to get @praetor's opinion, but it looks good to me

Would like to get @praetor's opinion, but it looks good to me
praetor commented 2019-03-26 15:33:31 +00:00
Collaborator
Copy Link

I like it. It's more consice and does what i imagined it doing. merged

I like it. It's more consice and does what i imagined it doing. *merged*
praetor closed this pull request 2019-03-26 15:33:53 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tildeverse/uucp#6
No description provided.
Delete Branch "jeffallen/uucp:fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?