issue 3, articles, named for easy ordering #6

Merged
ben merged 1 commits from terris/zine:master into master 1 year ago
terris commented 2 years ago

issues/3/ created
2 articles in issue 3
files named with numbers for easy ordering of articles in issue.
Can rename as necessary, insert article before/between/after
these by using appropriate number prefix.
test build at: https://terris.tilde.team/zine/
comments and questions welcomed!

issues/3/ created 2 articles in issue 3 files named with numbers for easy ordering of articles in issue. Can rename as necessary, insert article before/between/after these by using appropriate number prefix. test build at: https://terris.tilde.team/zine/ comments and questions welcomed!
ben commented 2 years ago
Owner

I'm happy to merge this when you are. A couple notes/thoughts:

  • did you mean to use the heading "a fistful of drones" more than once?
  • why did drone try to run a build? it hasn't been deployed to master yet. (though it seems that the PR is based on your master branch)
I'm happy to merge this when you are. A couple notes/thoughts: - did you mean to use the heading "a fistful of drones" more than once? - why did drone try to run a build? it hasn't been deployed to master yet. (though it seems that the PR is based on your master branch)
Poster

did mean to use same hading more than once, assuming there'd be more articles to break up the flow, or wether one would be moved to another issue.

no idea about why drone tried to build it. i don't have drone active with my fork, could it be the master branch trigger condition?

did mean to use same hading more than once, assuming there'd be more articles to break up the flow, or wether one would be moved to another issue. no idea about why drone tried to build it. i don't have drone active with my fork, could it be the master branch trigger condition?
ben commented 2 years ago
Owner

I'm guessing it's because your PR is also based on a branch called master.

I'm happy to merge this as soon as you feel it's ready and remove the WIP: from the title

I'm guessing it's because your PR is also based on a branch called master. I'm happy to merge this as soon as you feel it's ready and remove the WIP: from the title
ben commented 1 year ago
Owner

Any movement on this? I can't merge until the WIP: is removed from the title?

Any movement on this? I can't merge until the WIP: is removed from the title?
terris changed title from WIP: issue 3, articles, named for easy ordering to issue 3, articles, named for easy ordering 1 year ago
Poster

forgot this existed.

forgot this existed.
ben closed this pull request 1 year ago
ben commented 1 year ago
Owner
deployed: https://zine.tildeverse.org/issue-3.html
continuous-integration/drone/pr Build encountered an error
The pull request has been merged as 57abf32e5c.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.