xfnw
/
solanum
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
solanum/modules/m_grant.c

179 lines
4.6 KiB
C
Raw Normal View History

modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
/*
* Copyright (C) 2006 Jilles Tjoelker
* Copyright (C) 2006 Stephen Bennett <spb@gentoo.org>
*/
#include "stdinc.h"
#include "modules.h"
#include "numeric.h"
#include "client.h"
#include "ircd.h"
#include "send.h"
#include "s_user.h"
#include "s_serv.h"
#include "s_conf.h"
#include "s_newconf.h"
charybdise m_grant
2019-07-27 14:20:49 +00:00
#include "msgbuf.h"
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
m_grant: use AV2
2019-07-30 22:18:22 +00:00
static void mo_grant(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[]);
static void me_grant(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[]);
Move module description headers to the top This is cleaner. Note this was broken out of a much larger piece of work I did, so if there's any problems, I apologise!
2016-03-09 07:29:41 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
static int do_grant(struct Client *source_p, struct Client *target_p, const char *new_privset);
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
struct Message grant_msgtab = {
charybdise m_grant
2019-07-27 14:20:49 +00:00
"GRANT", 0, 0, 0, 0,
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
{ mg_ignore, mg_not_oper, mg_ignore, mg_ignore, {me_grant, 3}, {mo_grant, 3}}
};
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
mapi_clist_av1 grant_clist[] = { &grant_msgtab, NULL };
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
m_grant: use AV2
2019-07-30 22:18:22 +00:00
static const char grant_desc[] = "Allows operators to set or remove operator privileges on other users";
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
m_grant: use AV2
2019-07-30 22:18:22 +00:00
DECLARE_MODULE_AV2(grant, NULL, NULL, grant_clist, NULL, NULL, NULL, NULL, grant_desc);
static void
charybdise m_grant
2019-07-27 14:20:49 +00:00
mo_grant(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
struct Client *target_p;
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
charybdise m_grant
2019-07-27 14:20:49 +00:00
if(!HasPrivilege(source_p, "oper:grant"))
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
sendto_one(source_p, form_str(ERR_NOPRIVS), me.name, source_p->name, "grant");
m_grant: use AV2
2019-07-30 22:18:22 +00:00
return;
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
target_p = find_named_person(parv[1]);
if (target_p == NULL)
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
sendto_one_numeric(source_p, ERR_NOSUCHNICK,
form_str(ERR_NOSUCHNICK), parv[1]);
m_grant: use AV2
2019-07-30 22:18:22 +00:00
return;
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
m_grant: rewrite.
2016-07-27 05:40:26 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
if (MyClient(target_p))
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
do_grant(source_p, target_p, parv[2]);
}
else
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
sendto_one(target_p, ":%s ENCAP %s GRANT %s %s",
get_id(source_p, target_p), target_p->servptr->name,
get_id(target_p, target_p), parv[2]);
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
m_grant: rewrite.
2016-07-27 05:40:26 +00:00
}
m_grant: use AV2
2019-07-30 22:18:22 +00:00
static void
charybdise m_grant
2019-07-27 14:20:49 +00:00
me_grant(struct MsgBuf *msgbuf_p, struct Client *client_p, struct Client *source_p, int parc, const char *parv[])
m_grant: rewrite.
2016-07-27 05:40:26 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
struct Client *target_p;
target_p = find_person(parv[1]);
if (target_p == NULL)
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
sendto_one_numeric(source_p, ERR_NOSUCHNICK,
form_str(ERR_NOSUCHNICK), parv[1]);
m_grant: use AV2
2019-07-30 22:18:22 +00:00
return;
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
do_grant(source_p, target_p, parv[2]);
}
m_grant: rewrite.
2016-07-27 05:40:26 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
static int do_grant(struct Client *source_p, struct Client *target_p, const char *new_privset)
{
int dooper = 0, dodeoper = 0;
struct PrivilegeSet *privset = 0;
m_grant: match "deoper" case-insensitively
2019-09-14 23:16:00 +00:00
if (!strcasecmp(new_privset, "deoper"))
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
{
charybdise m_grant
2019-07-27 14:20:49 +00:00
if (!IsOper(target_p))
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
{
sendto_one_notice(source_p, ":You can't deoper someone who isn't an oper.");
return 0;
}
dodeoper = 1;
sendto_one_notice(target_p, ":%s is deopering you.", source_p->name);
sendto_realops_snomask(SNO_GENERAL, L_NETWIDE, "%s is deopering %s.", get_oper_name(source_p), target_p->name);
}
else
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
if (!(privset = privilegeset_get(new_privset)))
{
sendto_one_notice(source_p, ":There is no privilege set named '%s'.", new_privset);
return 0;
}
if (privset == target_p->user->privset)
{
sendto_one_notice(source_p, ":%s already has privilege set %s.", target_p->name, target_p->user->privset->name);
return 0;
}
add ConfigFileEntry.oper_secure_only, to require TLS to oper up (#76)
2020-11-18 14:29:08 +00:00
if (ConfigFileEntry.oper_secure_only && !IsSecureClient(target_p))
{
sendto_one_notice(source_p, ":Cannot GRANT %s, opers must be using secure connections.", target_p->name);
return 0;
}
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
if (!dodeoper)
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
charybdise m_grant
2019-07-27 14:20:49 +00:00
if (!IsOper(target_p))
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
{
sendto_one_notice(target_p, ":%s is opering you with privilege set %s", source_p->name, privset->name);
sendto_realops_snomask(SNO_GENERAL, L_NETWIDE, "%s is opering %s with privilege set %s", get_oper_name(source_p), target_p->name, privset->name);
dooper = 1;
}
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
else
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
{
sendto_one_notice(target_p, ":%s is changing your privilege set to %s", source_p->name, privset->name);
sendto_realops_snomask(SNO_GENERAL, L_NETWIDE, "%s is changing the privilege set of %s to %s", get_oper_name(source_p), target_p->name, privset->name);
}
if (!IsOper(target_p))
{
dooper = 1;
}
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
if (dodeoper)
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
{
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
const char *modeparv[4];
modeparv[0] = modeparv[1] = target_p->name;
modeparv[2] = "-o";
modeparv[3] = NULL;
user_mode(target_p, target_p, 3, modeparv);
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
if (dooper)
m_grant: rewrite.
2016-07-27 05:40:26 +00:00
{
m_grant: zero-initialize struct oper_conf bug noticed by @xnrand
2020-07-16 16:50:27 +00:00
struct oper_conf oper = {0};
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
oper.name = "<grant>";
oper.privset = privset;
oper_up(target_p, &oper);
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
}
m_grant: maintain privilegeset refcounts
2019-07-27 14:42:36 +00:00
else if (privset != NULL)
{
privilegeset_ref(privset);
}
if (target_p->user->privset != NULL)
privilegeset_unref(target_p->user->privset);
modules: add missing m_grant.c
2016-01-12 05:52:04 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
target_p->user->privset = privset;
m_grant: propagate privset changes
2019-07-27 14:43:33 +00:00
if (privset != NULL)
sendto_server(NULL, NULL, CAP_TS6, NOCAPS, ":%s OPER %s %s",
use_id(target_p), target_p->user->opername, privset->name);
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
const char *modeparv[4];
modeparv[0] = modeparv[1] = target_p->name;
modeparv[2] = "+";
modeparv[3] = NULL;
user_mode(target_p, target_p, 3, modeparv);
m_grant: rewrite.
2016-07-27 05:40:26 +00:00
Use the m_grant from ircd-seven Charybdis' rewritten m_grant introduces at least one serious bug without providing any apparent benefit. I think the best solution here is the easiest one. The bug in question is that an empty mode change is triggered after seven's grant has done its work, and this is necessary in order to give umodes granted by oper privileges a chance to update. The rewrite removes this, generating a mode change only if it wants to change the state of +o, which means the grant victim can keep privileged modes they no longer have access to, or fail to gain new ones.
2019-07-27 12:50:10 +00:00
return 0;
}