2014-02-26 04:57:31 +00:00
package hugolib
import (
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
"fmt"
"github.com/spf13/hugo/helpers"
"github.com/spf13/viper"
"reflect"
"regexp"
"sort"
2014-02-26 04:57:31 +00:00
"strings"
"testing"
)
func pageFromString ( in , filename string ) ( * Page , error ) {
2014-05-01 18:11:56 +00:00
return NewPageFrom ( strings . NewReader ( in ) , filename )
2014-02-26 04:57:31 +00:00
}
2014-04-24 16:18:47 +00:00
func CheckShortCodeMatch ( t * testing . T , input , expected string , template Template ) {
2014-02-26 04:57:31 +00:00
p , _ := pageFromString ( SIMPLE_PAGE , "simple.md" )
output := ShortcodesHandle ( input , p , template )
if output != expected {
t . Fatalf ( "Shortcode render didn't match. Expected: %q, Got: %q" , expected , output )
}
}
func TestNonSC ( t * testing . T ) {
2014-04-24 16:18:47 +00:00
tem := NewTemplate ( )
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
// notice the syntax diff from 0.12, now comment delims must be added
CheckShortCodeMatch ( t , "{{%/* movie 47238zzb */%}}" , "{{% movie 47238zzb %}}" , tem )
2014-02-26 04:57:31 +00:00
}
func TestPositionalParamSC ( t * testing . T ) {
2014-04-24 16:18:47 +00:00
tem := NewTemplate ( )
2014-02-26 04:57:31 +00:00
tem . AddInternalShortcode ( "video.html" , ` Playing Video {{ .Get 0 }} ` )
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
CheckShortCodeMatch ( t , "{{< video 47238zzb >}}" , "Playing Video 47238zzb" , tem )
CheckShortCodeMatch ( t , "{{< video 47238zzb 132 >}}" , "Playing Video 47238zzb" , tem )
CheckShortCodeMatch ( t , "{{<video 47238zzb>}}" , "Playing Video 47238zzb" , tem )
CheckShortCodeMatch ( t , "{{<video 47238zzb >}}" , "Playing Video 47238zzb" , tem )
CheckShortCodeMatch ( t , "{{< video 47238zzb >}}" , "Playing Video 47238zzb" , tem )
2014-02-26 04:57:31 +00:00
}
func TestNamedParamSC ( t * testing . T ) {
2014-04-24 16:18:47 +00:00
tem := NewTemplate ( )
2014-02-26 04:57:31 +00:00
tem . AddInternalShortcode ( "img.html" , ` <img {{ with .Get "src" }} src=" {{ . }} " {{ end }} {{ with .Get "class" }} class=" {{ . }} " {{ end }} > ` )
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
CheckShortCodeMatch ( t , ` {{ < img src = "one" > }} ` , ` <img src="one"> ` , tem )
CheckShortCodeMatch ( t , ` {{ < img class = "aspen" > }} ` , ` <img class="aspen"> ` , tem )
CheckShortCodeMatch ( t , ` {{ < img src = "one" > }} ` , ` <img src="one"> ` , tem )
CheckShortCodeMatch ( t , ` {{ < img src = "one" > }} ` , ` <img src="one"> ` , tem )
CheckShortCodeMatch ( t , ` {{ < img src = "one" > }} ` , ` <img src="one"> ` , tem )
CheckShortCodeMatch ( t , ` {{ < img src = "one" class = "aspen grove" > }} ` , ` <img src="one" class="aspen grove"> ` , tem )
2014-02-26 04:57:31 +00:00
}
func TestInnerSC ( t * testing . T ) {
2014-04-24 16:18:47 +00:00
tem := NewTemplate ( )
2014-02-26 04:57:31 +00:00
tem . AddInternalShortcode ( "inside.html" , ` <div {{ with .Get "class" }} class=" {{ . }} " {{ end }} > {{ .Inner }} </div> ` )
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
CheckShortCodeMatch ( t , ` {{ < inside class = "aspen" > }} ` , ` <div class="aspen"></div> ` , tem )
CheckShortCodeMatch ( t , ` {{ < inside class = "aspen" > }} More Here {{ < / inside > }} ` , "<div class=\"aspen\">More Here</div>" , tem )
CheckShortCodeMatch ( t , ` {{ < inside > }} More Here {{ < / inside > }} ` , "<div>More Here</div>" , tem )
2014-08-28 16:48:31 +00:00
}
func TestInnerSCWithMarkdown ( t * testing . T ) {
tem := NewTemplate ( )
tem . AddInternalShortcode ( "inside.html" , ` <div {{ with .Get "class" }} class=" {{ . }} " {{ end }} > {{ .Inner }} </div> ` )
CheckShortCodeMatch ( t , ` { { % inside % } }
# More Here
[ link ] ( http : //spf13.com) and text
{ { % / inside % } } ` , "<div><h1>More Here</h1>\n\n<p><a href=\"http://spf13.com\">link</a> and text</p>\n</div>" , tem )
2014-02-26 04:57:31 +00:00
}
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
func TestInnerSCWithAndWithoutMarkdown ( t * testing . T ) {
tem := NewTemplate ( )
tem . AddInternalShortcode ( "inside.html" , ` <div {{ with .Get "class" }} class=" {{ . }} " {{ end }} > {{ .Inner }} </div> ` )
CheckShortCodeMatch ( t , ` { { % inside % } }
# More Here
[ link ] ( http : //spf13.com) and text
{ { % / inside % } }
And then :
{ { < inside > } }
# More Here
This is * * plain * * text .
{ { < / inside > } }
` , "<div><h1>More Here</h1>\n\n<p><a href=\"http://spf13.com\">link</a> and text</p>\n</div>\n\nAnd then:\n\n<div>\n# More Here\n\nThis is **plain** text.\n\n</div>\n" , tem )
}
2014-02-26 04:57:31 +00:00
func TestEmbeddedSC ( t * testing . T ) {
2014-04-24 16:18:47 +00:00
tem := NewTemplate ( )
2014-02-26 04:57:31 +00:00
CheckShortCodeMatch ( t , "{{% test %}}" , "This is a simple Test" , tem )
2014-10-30 15:37:00 +00:00
CheckShortCodeMatch ( t , ` {{ % figure src = "/found/here" class = "bananas orange" % }} ` , "\n<figure class=\"bananas orange\">\n \n <img src=\"/found/here\" />\n \n \n</figure>\n" , tem )
2014-02-26 04:57:31 +00:00
CheckShortCodeMatch ( t , ` {{ % figure src = "/found/here" class = "bananas orange" caption = "This is a caption" % }} ` , "\n<figure class=\"bananas orange\">\n \n <img src=\"/found/here\" alt=\"This is a caption\" />\n \n \n <figcaption>\n <p>\n This is a caption\n \n \n \n </p> \n </figcaption>\n \n</figure>\n" , tem )
}
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
func TestNestedSC ( t * testing . T ) {
tem := NewTemplate ( )
tem . AddInternalShortcode ( "scn1.html" , ` <div>Outer, inner is {{ .Inner }} </div> ` )
tem . AddInternalShortcode ( "scn2.html" , ` <div>SC2</div> ` )
CheckShortCodeMatch ( t , ` {{ % scn1 % }} {{ % scn2 % }} {{ % / scn1 % }} ` , "<div>Outer, inner is <div>SC2</div>\n</div>" , tem )
}
func TestNestedComplexSC ( t * testing . T ) {
tem := NewTemplate ( )
tem . AddInternalShortcode ( "row.html" , ` -row- {{ .Inner }} -rowStop- ` )
tem . AddInternalShortcode ( "column.html" , ` -col- {{ .Inner }} -colStop- ` )
tem . AddInternalShortcode ( "aside.html" , ` -aside- {{ .Inner }} -asideStop- ` )
CheckShortCodeMatch ( t , ` {{ < row > }} 1-s {{ % column % }} 2-**s** {{ < aside > }} 3-**s** {{ < / aside > }} 4-s {{ % / column % }} 5-s {{ < / row > }} 6-s ` ,
"-row-1-s-col-<p>2-<strong>s</strong>-aside-3-**s**-asideStop-4-s</p>\n-colStop-5-s-rowStop-6-s" , tem )
// turn around the markup flag
CheckShortCodeMatch ( t , ` {{ % row % }} 1-s {{ < column > }} 2-**s** {{ % aside % }} 3-**s** {{ % / aside % }} 4-s {{ < / column > }} 5-s {{ % / row % }} 6-s ` ,
"-row-<p>1-s-col-2-**s**-aside-<p>3-<strong>s</strong></p>\n-asideStop-4-s-colStop-5-s</p>\n-rowStop-6-s" , tem )
}
2014-10-08 14:54:50 +00:00
func TestFigureImgWidth ( t * testing . T ) {
tem := NewTemplate ( )
2014-10-30 15:37:00 +00:00
CheckShortCodeMatch ( t , ` {{ % figure src = "/found/here" class = "bananas orange" alt = "apple" width = "100px" % }} ` , "\n<figure class=\"bananas orange\">\n \n <img src=\"/found/here\" alt=\"apple\" width=\"100px\" />\n \n \n</figure>\n" , tem )
2014-10-08 14:54:50 +00:00
}
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
func TestHighlight ( t * testing . T ) {
if ! helpers . HasPygments ( ) {
t . Skip ( "Skip test as Pygments is not installed" )
}
defer viper . Set ( "PygmentsStyle" , viper . Get ( "PygmentsStyle" ) )
viper . Set ( "PygmentsStyle" , "bw" )
2014-04-24 16:18:47 +00:00
tem := NewTemplate ( )
2014-02-26 04:57:31 +00:00
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
code := `
{ { < highlight java > } }
void do ( ) ;
{ { < / highlight > } } `
CheckShortCodeMatch ( t , code , "\n<div class=\"highlight\" style=\"background: #ffffff\"><pre style=\"line-height: 125%\"><span style=\"font-weight: bold\">void</span> do();\n</pre></div>\n" , tem )
}
const testScPlaceholderRegexp = "<div>HUGOSHORTCODE-\\d+</div>"
func TestExtractShortcodes ( t * testing . T ) {
for i , this := range [ ] struct {
name string
input string
expectShortCodes string
expect interface { }
expectErrorMsg string
} {
{ "text" , "Some text." , "map[]" , "Some text." , "" } ,
{ "invalid right delim" , "{{< tag }}" , "" , false , "simple:4:.*unrecognized character.*}" } ,
{ "invalid close" , "\n{{< /tag >}}" , "" , false , "simple:5:.*got closing shortcode, but none is open" } ,
{ "invalid close2" , "\n\n{{< tag >}}{{< /anotherTag >}}" , "" , false , "simple:6: closing tag for shortcode 'anotherTag' does not match start tag" } ,
{ "unterminated quote 1" , ` {{ < figure src = "im caption=" S " > }} ` , "" , false , "simple:4:.got pos.*" } ,
{ "unterminated quote 1" , ` {{ < figure src = "im" caption = " S > }} ` , "" , false , "simple:4:.*unterm.*}" } ,
{ "one shortcode, no markup" , "{{< tag >}}" , "" , testScPlaceholderRegexp , "" } ,
{ "one shortcode, markup" , "{{% tag %}}" , "" , testScPlaceholderRegexp , "" } ,
{ "one pos param" , "{{% tag param1 %}}" , ` tag([\"param1\"], true) { []}"] ` , testScPlaceholderRegexp , "" } ,
{ "two pos params" , "{{< tag param1 param2>}}" , ` tag([\"param1\" \"param2\"], false) { []}"] ` , testScPlaceholderRegexp , "" } ,
2014-11-18 09:20:52 +00:00
{ "one named param" , ` {{ % tag param1 = "value" % }} ` , ` tag([\"param1:value\"], true) { []} ` , testScPlaceholderRegexp , "" } ,
{ "two named params" , ` {{ < tag param1 = "value1" param2 = "value2" > }} ` , ` tag([\"param1:value1\" \"param2:value2\"], false) { []}"] ` ,
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
testScPlaceholderRegexp , "" } ,
{ "inner" , ` Some text. {{ < inner > }} Inner Content {{ < / inner > }} . Some more text. ` , ` inner([], false) { [Inner Content]} ` ,
fmt . Sprintf ( "Some text. %s. Some more text." , testScPlaceholderRegexp ) , "" } ,
{ "close, but not inner" , "{{< tag >}}foo{{< /tag >}}" , "" , false , "Shortcode 'tag' has no .Inner.*" } ,
{ "nested inner" , ` Inner-> {{ < inner > }} Inner Content-> {{ % inner2 param1 % }} inner2txt {{ % / inner2 % }} Inner close-> {{ < / inner > }} <-done ` ,
` inner([], false) { [Inner Content-> inner2([\"param1\"], true) { [inner2txt]} Inner close->]} ` ,
fmt . Sprintf ( "Inner->%s<-done" , testScPlaceholderRegexp ) , "" } ,
{ "nested, nested inner" , ` Inner-> {{ < inner > }} inner2-> {{ % inner2 param1 % }} inner2txt->inner3 {{ < inner3 > }} inner3txt {{ < / inner3 > }} {{ % / inner2 % }} final close-> {{ < / inner > }} <-done ` ,
` inner([], false) { [inner2-> inner2([\"param1\"], true) { [inner2txt->inner3 inner3(%!q(<nil>), false) { [inner3txt]}]} final close-> ` ,
fmt . Sprintf ( "Inner->%s<-done" , testScPlaceholderRegexp ) , "" } ,
{ "two inner" , ` Some text. {{ % inner % }} First **Inner** Content {{ % / inner % }} {{ < inner > }} Inner **Content** {{ < / inner > }} . Some more text. ` ,
` map["<div>HUGOSHORTCODE-1</div>:inner([], true) { [First **Inner** Content]}" "<div>HUGOSHORTCODE-2</div>:inner([], false) { [Inner **Content**]}"] ` ,
fmt . Sprintf ( "Some text. %s %s. Some more text." , testScPlaceholderRegexp , testScPlaceholderRegexp ) , "" } ,
{ "closed without content" , ` Some text. {{ < inner param1 > }} {{ < / inner > }} . Some more text. ` , ` inner([\"param1\"], false) { []} ` ,
fmt . Sprintf ( "Some text. %s. Some more text." , testScPlaceholderRegexp ) , "" } ,
{ "two shortcodes" , "{{< sc1 >}}{{< sc2 >}}" ,
` map["<div>HUGOSHORTCODE-1</div>:sc1([], false) { []}" "<div>HUGOSHORTCODE-2</div>:sc2([], false) { []}"] ` ,
testScPlaceholderRegexp + testScPlaceholderRegexp , "" } ,
{ "mix of shortcodes" , ` Hello {{ < sc1 > }} world {{ % sc2 p2 = "2" % }} . And that's it. ` ,
2014-11-18 09:20:52 +00:00
` map["<div>HUGOSHORTCODE-1</div>:sc1([], false) { []}" "<div>HUGOSHORTCODE-2</div>:sc2([\"p2:2\"] ` ,
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
fmt . Sprintf ( "Hello %sworld%s. And that's it." , testScPlaceholderRegexp , testScPlaceholderRegexp ) , "" } ,
{ "mix with inner" , ` Hello {{ < sc1 > }} world {{ % inner p2 = "2" % }} Inner {{ % / inner % }} . And that's it. ` ,
2014-11-18 09:20:52 +00:00
` map["<div>HUGOSHORTCODE-1</div>:sc1([], false) { []}" "<div>HUGOSHORTCODE-2</div>:inner([\"p2:2\"], true) { [Inner]}"] ` ,
Shortcode rewrite, take 2
This commit contains a restructuring and partial rewrite of the shortcode handling.
Prior to this commit rendering of the page content was mingled with handling of the shortcodes. This led to several oddities.
The new flow is:
1. Shortcodes are extracted from page and replaced with placeholders.
2. Shortcodes are processed and rendered
3. Page is processed
4. The placeholders are replaced with the rendered shortcodes
The handling of summaries is also made simpler by this.
This commit also introduces some other chenges:
1. distinction between shortcodes that need further processing and those who do not:
* `{{< >}}`: Typically raw HTML. Will not be processed.
* `{{% %}}`: Will be processed by the page's markup engine (Markdown or (infuture) Asciidoctor)
The above also involves a new shortcode-parser, with lexical scanning inspired by Rob Pike's talk called "Lexical Scanning in Go",
which should be easier to understand, give better error messages and perform better.
2. If you want to exclude a shortcode from being processed (for documentation etc.), the inner part of the shorcode must be commented out, i.e. `{{%/* movie 47238zzb */%}}`. See the updated shortcode section in the documentation for further examples.
The new parser supports nested shortcodes. This isn't new, but has two related design choices worth mentioning:
* The shortcodes will be rendered individually, so If both `{{< >}}` and `{{% %}}` are used in the nested hierarchy, one will be passed through the page's markdown processor, the other not.
* To avoid potential costly overhead of always looking far ahead for a possible closing tag, this implementation looks at the template itself, and is branded as a container with inner content if it contains a reference to `.Inner`
Fixes #565
Fixes #480
Fixes #461
And probably some others.
2014-10-27 20:48:30 +00:00
fmt . Sprintf ( "Hello %sworld%s. And that's it." , testScPlaceholderRegexp , testScPlaceholderRegexp ) , "" } ,
} {
p , _ := pageFromString ( SIMPLE_PAGE , "simple.md" )
tem := NewTemplate ( )
tem . AddInternalShortcode ( "tag.html" , ` tag ` )
tem . AddInternalShortcode ( "sc1.html" , ` sc1 ` )
tem . AddInternalShortcode ( "sc2.html" , ` sc2 ` )
tem . AddInternalShortcode ( "inner.html" , ` {{ .Inner }} ` )
tem . AddInternalShortcode ( "inner2.html" , ` {{ .Inner }} ` )
tem . AddInternalShortcode ( "inner3.html" , ` {{ .Inner }} ` )
content , shortCodes , err := extractShortcodes ( this . input , p , tem )
if b , ok := this . expect . ( bool ) ; ok && ! b {
if err == nil {
t . Fatalf ( "[%d] %s: ExtractShortcodes didn't return an expected error" , i , this . name )
} else {
r , _ := regexp . Compile ( this . expectErrorMsg )
if ! r . MatchString ( err . Error ( ) ) {
t . Fatalf ( "[%d] %s: ExtractShortcodes didn't return an expected error message, expected %s got %s" ,
i , this . name , this . expectErrorMsg , err . Error ( ) )
}
}
continue
} else {
if err != nil {
t . Fatalf ( "[%d] %s: failed: %q" , i , this . name , err )
}
}
var expected string
av := reflect . ValueOf ( this . expect )
switch av . Kind ( ) {
case reflect . String :
expected = av . String ( )
}
r , err := regexp . Compile ( expected )
if err != nil {
t . Fatalf ( "[%d] %s: Failed to compile regexp %q: %q" , i , this . name , expected , err )
}
if strings . Count ( content , shortcodePlaceholderPrefix ) != len ( shortCodes ) {
t . Fatalf ( "[%d] %s: Not enough placeholders, found %d" , i , this . name , len ( shortCodes ) )
}
if ! r . MatchString ( content ) {
t . Fatalf ( "[%d] %s: Shortcode extract didn't match. Expected: %q, Got: %q" , i , this . name , expected , content )
}
for placeHolder , sc := range shortCodes {
if ! strings . Contains ( content , placeHolder ) {
t . Fatalf ( "[%d] %s: Output does not contain placeholder %q" , i , this . name , placeHolder )
}
if sc . params == nil {
t . Fatalf ( "[%d] %s: Params is nil for shortcode '%s'" , i , this . name , sc . name )
}
}
if this . expectShortCodes != "" {
shortCodesAsStr := fmt . Sprintf ( "map%q" , collectAndShortShortcodes ( shortCodes ) )
if ! strings . Contains ( shortCodesAsStr , this . expectShortCodes ) {
t . Fatalf ( "[%d] %s: Short codes not as expected, got %s - expected to contain %s" , i , this . name , shortCodesAsStr , this . expectShortCodes )
}
}
}
}
func collectAndShortShortcodes ( shortcodes map [ string ] shortcode ) [ ] string {
var asArray [ ] string
for key , sc := range shortcodes {
asArray = append ( asArray , fmt . Sprintf ( "%s:%s" , key , sc ) )
}
sort . Strings ( asArray )
return asArray
}
func TestReplaceShortcodeTokens ( t * testing . T ) {
for i , this := range [ ] struct {
input [ ] byte
prefix string
replacements map [ string ] string
numReplacements int
wrappedInDiv bool
expect interface { }
} {
{ [ ] byte ( "Hello PREFIX-1." ) , "PREFIX" ,
map [ string ] string { "PREFIX-1" : "World" } , - 1 , false , [ ] byte ( "Hello World." ) } ,
{ [ ] byte ( "A <div>A-1</div> asdf <div>A-2</div>." ) , "A" ,
map [ string ] string { "<div>A-1</div>" : "v1" , "<div>A-2</div>" : "v2" } , - 1 , true , [ ] byte ( "A v1 asdf v2." ) } ,
{ [ ] byte ( "Hello PREFIX2-1. Go PREFIX2-2, Go, Go PREFIX2-3 Go Go!." ) , "PREFIX2" ,
map [ string ] string { "PREFIX2-1" : "Europe" , "PREFIX2-2" : "Jonny" , "PREFIX2-3" : "Johnny" } ,
- 1 , false , [ ] byte ( "Hello Europe. Go Jonny, Go, Go Johnny Go Go!." ) } ,
{ [ ] byte ( "A PREFIX-2 PREFIX-1." ) , "PREFIX" ,
map [ string ] string { "PREFIX-1" : "A" , "PREFIX-2" : "B" } , - 1 , false , false } ,
{ [ ] byte ( "A PREFIX-1 PREFIX-2" ) , "PREFIX" ,
map [ string ] string { "PREFIX-1" : "A" } , - 1 , false , [ ] byte ( "A A PREFIX-2" ) } ,
{ [ ] byte ( "A PREFIX-1 but not the second." ) , "PREFIX" ,
map [ string ] string { "PREFIX-1" : "A" , "PREFIX-2" : "B" } , - 1 , false , false } ,
{ [ ] byte ( "An PREFIX-1." ) , "PREFIX" ,
map [ string ] string { "PREFIX-1" : "A" , "PREFIX-2" : "B" } , 1 , false , [ ] byte ( "An A." ) } ,
{ [ ] byte ( "An PREFIX-1 PREFIX-2." ) , "PREFIX" ,
map [ string ] string { "PREFIX-1" : "A" , "PREFIX-2" : "B" } , 1 , false , [ ] byte ( "An A PREFIX-2." ) } ,
} {
results , err := replaceShortcodeTokens ( this . input , this . prefix , this . numReplacements , this . wrappedInDiv , this . replacements )
if b , ok := this . expect . ( bool ) ; ok && ! b {
if err == nil {
t . Errorf ( "[%d] replaceShortcodeTokens didn't return an expected error" , i )
}
} else {
if err != nil {
t . Errorf ( "[%d] failed: %s" , i , err )
continue
}
if ! reflect . DeepEqual ( results , this . expect ) {
t . Errorf ( "[%d] replaceShortcodeTokens, got %q but expected %q" , i , results , this . expect )
}
}
}
2014-02-26 04:57:31 +00:00
}
