zerica/hugo
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hugolib: Do not set RSS as Kind in RSS output

Browse Source 
Before Hugo this commit  we set the pseudo page kind RSS on the page when output to RSS. This had some unintended side effects, esp. when the only output format for that page  was RSS.

For the page kinds that can have multiple output formats, the Kind should be one of the standard home, page etc.

Fixes #5138
This commit is contained in:
Bjørn Erik Pedersen 2018-09-14 11:04:33 +02:00
parent 75e54345f9
commit 555a5612b2
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hugolib/rss_test.go
View File

@ -57,3 +57,21 @@ func TestRSSOutput(t *testing.T) {
t.Errorf("incorrect RSS item count: expected %d, got %d", rssLimit, c)
}
}
// Before Hugo 0.49 we set the pseudo page kind RSS on the page when output to RSS.
// This had some unintended side effects, esp. when the only output format for that page
// was RSS.
// For the page kinds that can have multiple output formats, the Kind should be one of the
// standard home, page etc.
// This test has this single purpose: Check that the Kind is that of the source page.
// See https://github.com/gohugoio/hugo/issues/5138
func TestRSSKind(t *testing.T) {
t.Parallel()
b := newTestSitesBuilder(t)
b.WithSimpleConfigFile().WithTemplatesAdded("index.rss.xml", `RSS Kind: {{ .Kind }}`)
b.Build(BuildCfg{})
b.AssertFileContent("public/index.xml", "RSS Kind: home")
}

2
hugolib/site_render.go
View File

@ -248,8 +248,6 @@ func (s *Site) renderRSS(p *PageOutput) error {
return nil
}
p.Kind = kindRSS
limit := s.Cfg.GetInt("rssLimit")
if limit >= 0 && len(p.Pages) > limit {
p.Pages = p.Pages[:limit]