Peter Bhat Harkins
6c7f6677ba
housekeeping
...
If you don't want color in rspec output, you can add it to your ~/.rspec.
2018-04-19 05:37:18 -05:00
Peter Bhat Harkins
60c7a9cc3a
more tests for Story#domain
2018-04-18 18:48:42 -05:00
Peter Bhat Harkins
828758bb17
memoize Story#domain
2018-04-18 17:38:18 -05:00
Jack Klika
22ed4f4663
Added link to tags list on story submission page
2018-04-18 15:22:47 -05:00
Peter Bhat Harkins
49e678ea39
Story: allow nonstandard ports in urls
...
Refectors url setter and adds a bunch of tests.
2018-04-18 15:13:44 -05:00
Peter Bhat Harkins
ff1dc75523
high-value end-to-end happy path specs
...
Viewing homepage, ubmitting a story, viewing a story as a logged-in or
logged-out user, and submitting a comment. Also allows posting comments
without JavaScript.
I wanted smoke tests for the highest-traffic endpoints that tend to throw me a
few hundred emails if they hit exceptions in production.
2018-04-18 10:13:34 -05:00
Peter Bhat Harkins
bf6bc8c2c5
bugfix a0aca1e
2018-04-16 15:11:55 -05:00
Peter Bhat Harkins
a0aca1ea15
fix join for recent votes, helps for voting rings
2018-04-16 10:08:36 -05:00
Peter Bhat Harkins
5e8d57b618
Revert skylight
...
Closes #454
2018-04-12 16:00:47 -05:00
Peter Bhat Harkins
9cff9aa3ba
Merge branch 'talklittle-settings-account-deletion-sure-checkbox'
2018-04-11 10:04:21 -05:00
Peter Bhat Harkins
f02b571a82
Merge branch 'settings-account-deletion-sure-checkbox' of git://github.com/talklittle/lobsters into talklittle-settings-account-deletion-sure-checkbox
2018-04-11 10:00:37 -05:00
Philip K
e11fd19cd4
Fixed padding issue for some dialogs on mobile
2018-04-11 09:59:13 -05:00
Peter Bhat Harkins
494d8f9940
save tag_id in after_save
2018-04-11 09:50:08 -05:00
Peter Bhat Harkins
e9deaabae7
ignore prod skylight config
...
For #454
2018-04-11 09:25:12 -05:00
Peter Bhat Harkins
c500f89e7f
fixup tag
2018-04-11 09:02:05 -05:00
Peter Bhat Harkins
bd89ef3834
Merge branch 'chancancode-skylight'
2018-04-11 08:39:56 -05:00
Peter Bhat Harkins
7b91cd0ac5
production group
2018-04-11 08:38:32 -05:00
Peter Bhat Harkins
3907e66bdf
Merge branch 'skylight' of git://github.com/chancancode/lobsters into chancancode-skylight
2018-04-11 08:35:57 -05:00
Peter Bhat Harkins
93fe0fdd74
link tags from modlog
2018-04-11 08:31:10 -05:00
Peter Bhat Harkins
2105656d8f
Merge branch 'masongup-feature/add-tag-management'
2018-04-11 08:05:47 -05:00
Peter Bhat Harkins
978c1e360e
Merge branch 'master' into masongup-feature/add-tag-management
2018-04-11 08:04:53 -05:00
Peter Bhat Harkins
3993d63883
Fix feed validation errors
...
W3C's feed validator service said:
1. Author should be an email address
2. Don't use relative links in <description>
3. Include a link with rel="self"
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
0a6a97df64
only load rubocop rake tasks in dev/test
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
fc0fcaa341
tz fix
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
dba939bce2
dead routes for comment dragoning
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
c0e94f688e
Fix count of unread replies in header
...
Pushed the memoization down into the models.
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
62df8e87e1
Revert "rename password for account deletion so Firefox doesn't autofill"
...
This reverts commit 8da472c231
.
Doesn't work, see discussion in #446
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
c8b8f9fbc0
need writer
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
3418bb081d
precedence
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
adb212010d
we don't use yarn
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
eb094b2e23
Note docker-lobsters project
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
48a218e3e5
not quite inverses, apparently
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
a9d5afea5c
add bullet to catch 1 + n queries and unused eager loading
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
dcd848f00d
rubocop: Lint/DuplicateMethods could have been clearer
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
f8166d128e
bug from rubocop
2018-04-11 07:43:52 -05:00
Hunter Madison
4fa936a8bb
Ignore vendor directory
...
Travis puts all the gems into vendor/ and then rubocop sees and complains about them.
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
f16d3747ac
rubocop recommends not requiring it in Gemfile
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
7ffea0d597
rename password for account deletion so Firefox doesn't autofill
...
Fixes #466
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
ed0dc993f0
fix from rubocop
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
0bdd1fdb60
travis: test suite is rubocop + rspec
2018-04-11 07:43:52 -05:00
Peter Bhat Harkins
571ae4c68a
update to current rspec-rails integration style
2018-04-11 07:43:52 -05:00
avinassh
c8295cfbcb
Feature: Configurable open signups
...
Set the environment variable (or tweak config/application.rb) to enable.
2018-04-11 07:43:52 -05:00
avi
8a0360b795
Bugfix: render privacy page properly
2018-04-11 07:43:52 -05:00
Andrew Shu
aca21d18ba
fix migration datetime value
2018-04-11 07:43:37 -05:00
Peter Bhat Harkins
2adfd16d65
fix mysql/AR version incompatibility
2018-04-11 07:43:37 -05:00
Peter Bhat Harkins
7c23d3337a
don't give author bump without an author link
2018-04-11 07:43:22 -05:00
Andrew Shu
1df48ee6a7
comments: fix tree lines on edit
2018-04-11 07:43:03 -05:00
Grey Baker
cb0bc7d7c3
Update dependencies
...
* Bump rspec-rails from 3.6.0 to 3.7.2
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 3.6.0 to 3.7.2.
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.6.0...v3.7.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump activerecord-typedstore from 1.1.1 to 1.1.3
Bumps [activerecord-typedstore](https://github.com/byroot/activerecord-typedstore ) from 1.1.1 to 1.1.3.
- [Commits](https://github.com/byroot/activerecord-typedstore/compare/v1.1.1...v1.1.3 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump nokogiri from 1.8.1 to 1.8.2
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.8.1 to 1.8.2.
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.8.1...v1.8.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump scenic from 1.4.0 to 1.4.1
Bumps [scenic](https://github.com/thoughtbot/scenic ) from 1.4.0 to 1.4.1.
- [Changelog](https://github.com/thoughtbot/scenic/blob/master/NEWS.md )
- [Commits](https://github.com/thoughtbot/scenic/compare/v1.4.0...v1.4.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump exception_notification from 4.2.1 to 4.2.2
Bumps [exception_notification](https://github.com/smartinez87/exception_notification ) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/smartinez87/exception_notification/blob/master/CHANGELOG.rdoc )
- [Commits](https://github.com/smartinez87/exception_notification/compare/v4.2.1...v4.2.2 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump oauth from 0.5.3 to 0.5.4
Bumps oauth from 0.5.3 to 0.5.4.
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump uglifier from 3.2.0 to 4.1.7
Bumps [uglifier](https://github.com/lautis/uglifier ) from 3.2.0 to 4.1.7.
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md )
- [Commits](https://github.com/lautis/uglifier/compare/v3.2.0...v4.1.7 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump rotp from 3.3.0 to 3.3.1
Bumps [rotp](https://github.com/mdp/rotp ) from 3.3.0 to 3.3.1.
- [Changelog](https://github.com/mdp/rotp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mdp/rotp/commits )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump rails from 5.1.1 to 5.1.5
Bumps [rails](https://github.com/rails/rails ) from 5.1.1 to 5.1.5.
- [Commits](https://github.com/rails/rails/compare/v5.1.1...v5.1.5 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump faker from 1.7.3 to 1.8.7
Bumps [faker](https://github.com/stympy/faker ) from 1.7.3 to 1.8.7.
- [Changelog](https://github.com/stympy/faker/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stympy/faker/compare/v1.7.3...v1.8.7 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump unicorn from 5.3.0 to 5.4.0
Bumps [unicorn](https://bogomips.org/unicorn/ ) from 5.3.0 to 5.4.0.
Signed-off-by: dependabot[bot] <support@dependabot.com>
* Bump mysql2 from 0.4.6 to 0.4.10
Bumps [mysql2](https://github.com/brianmario/mysql2 ) from 0.4.6 to 0.4.10.
- [Release notes](https://github.com/brianmario/mysql2/releases )
- [Changelog](https://github.com/brianmario/mysql2/blob/master/CHANGELOG.md )
- [Commits](https://github.com/brianmario/mysql2/compare/0.4.6...0.4.10 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-04-11 07:42:17 -05:00
Peter Bhat Harkins
b70873a45c
rubocop: Style, 0
2018-04-11 07:41:46 -05:00
Peter Bhat Harkins
ee2adc67cd
rubocop: Style/AndOr, 42
2018-04-11 07:41:46 -05:00