akkartik
/
mu
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

make fake screens more realistic 

The real screen silently clips coordinates out of bounds.
This commit is contained in:
Kartik K. Agaram 2021-06-06 22:52:59 -07:00
parent b6e1cffd9b
commit b3869987da
1 changed files with 33 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
500fake-screen.mu
View File

@ -18,8 +18,10 @@ type screen {
data: (handle array screen-cell) data: (handle array screen-cell)
cursor-x: int # [0..width) cursor-x: int # [0..width)
cursor-y: int # [0..height) cursor-y: int # [0..height)
invalid-cell-index: int
# pixel graphics # pixel graphics
pixels: (handle array byte) pixels: (handle array byte)
invalid-pixel-index: int
} }
type screen-cell { type screen-cell {
@ -45,7 +47,14 @@ fn initialize-screen _screen: (addr screen), width: int, height: int, pixel-grap
var data-ah/edi: (addr handle array screen-cell) <- get screen, data var data-ah/edi: (addr handle array screen-cell) <- get screen, data
var capacity/eax: int <- copy width var capacity/eax: int <- copy width
capacity <- multiply height capacity <- multiply height
# add 1 for sentinel
capacity <- increment
#
populate data-ah, capacity populate data-ah, capacity
# save sentinel index
capacity <- decrement
var dest/ecx: (addr int) <- get screen, invalid-cell-index
copy-to *dest, capacity
} }
# if necessary, populate screen->pixels # if necessary, populate screen->pixels
{ {
@ -56,7 +65,14 @@ fn initialize-screen _screen: (addr screen), width: int, height: int, pixel-grap
capacity <- shift-left 3/log2-font-width capacity <- shift-left 3/log2-font-width
capacity <- multiply height capacity <- multiply height
capacity <- shift-left 4/log2-font-height capacity <- shift-left 4/log2-font-height
# add 1 for sentinel
capacity <- increment
#
populate pixels-ah, capacity populate pixels-ah, capacity
# save sentinel index
capacity <- decrement
var dest/ecx: (addr int) <- get screen, invalid-pixel-index
copy-to *dest, capacity
} }
# screen->cursor-x = 0 # screen->cursor-x = 0
dest <- get screen, cursor-x dest <- get screen, cursor-x
@ -119,30 +135,34 @@ fn draw-code-point screen: (addr screen), c: code-point, x: int, y: int, color:
# fake screens only # fake screens only
fn screen-cell-index _screen: (addr screen), x: int, y: int -> _/ecx: int { fn screen-cell-index _screen: (addr screen), x: int, y: int -> _/ecx: int {
var screen/esi: (addr screen) <- copy _screen var screen/esi: (addr screen) <- copy _screen
# some bounds checks that aren't needed for a real screen, but might help catch problems # if out of bounds, silently return a pixel that's never checked
{ {
compare x, 0 compare x, 0
break-if->= break-if->=
abort "screen-cell-index: negative x" var invalid/eax: (addr int) <- get screen, invalid-cell-index
return *invalid
} }
{ {
var xmax/eax: (addr int) <- get screen, width var xmax/eax: (addr int) <- get screen, width
var xcurr/ecx: int <- copy x var xcurr/ecx: int <- copy x
compare xcurr, *xmax compare xcurr, *xmax
break-if-< break-if-<
abort "screen-cell-index: x too high" var invalid/eax: (addr int) <- get screen, invalid-cell-index
return *invalid
} }
{ {
compare y, 0 compare y, 0
break-if->= break-if->=
abort "screen-cell-index: negative y" var invalid/eax: (addr int) <- get screen, invalid-cell-index
return *invalid
} }
{ {
var ymax/eax: (addr int) <- get screen, height var ymax/eax: (addr int) <- get screen, height
var ycurr/ecx: int <- copy y var ycurr/ecx: int <- copy y
compare ycurr, *ymax compare ycurr, *ymax
break-if-< break-if-<
abort "screen-cell-index: y too high" var invalid/eax: (addr int) <- get screen, invalid-cell-index
return *invalid
} }
var width-addr/eax: (addr int) <- get screen, width var width-addr/eax: (addr int) <- get screen, width
var result/ecx: int <- copy y var result/ecx: int <- copy y
@ -487,7 +507,8 @@ fn pixel-index _screen: (addr screen), x: int, y: int -> _/ecx: int {
{ {
compare x, 0 compare x, 0
break-if->= break-if->=
abort "screen-cell-index: negative x" var invalid/eax: (addr int) <- get screen, invalid-pixel-index
return *invalid
} }
{ {
var xmax-a/eax: (addr int) <- get screen, width var xmax-a/eax: (addr int) <- get screen, width
@ -495,12 +516,14 @@ fn pixel-index _screen: (addr screen), x: int, y: int -> _/ecx: int {
xmax <- shift-left 3/log2-font-width xmax <- shift-left 3/log2-font-width
compare x, xmax compare x, xmax
break-if-< break-if-<
abort "screen-cell-index: x too high" var invalid/eax: (addr int) <- get screen, invalid-pixel-index
return *invalid
} }
{ {
compare y, 0 compare y, 0
break-if->= break-if->=
abort "screen-cell-index: negative y" var invalid/eax: (addr int) <- get screen, invalid-pixel-index
return *invalid
} }
{ {
var ymax-a/eax: (addr int) <- get screen, height var ymax-a/eax: (addr int) <- get screen, height
@ -508,7 +531,8 @@ fn pixel-index _screen: (addr screen), x: int, y: int -> _/ecx: int {
ymax <- shift-left 4/log2-font-height ymax <- shift-left 4/log2-font-height
compare y, ymax compare y, ymax
break-if-< break-if-<
abort "screen-cell-index: y too high" var invalid/eax: (addr int) <- get screen, invalid-pixel-index
return *invalid
} }
var width-addr/eax: (addr int) <- get screen, width var width-addr/eax: (addr int) <- get screen, width
var result/ecx: int <- copy y var result/ecx: int <- copy y