Remove wx/textctrl.h from headers

src/AudacityLogger.h

@@ -21,7 +21,8 @@
 #include "MemoryX.h"
 #include <wx/log.h>
 #include <wx/frame.h>
-#include <wx/textctrl.h>
+
+class wxTextCtrl;
 
 class AudacityLogger final : public wxEvtHandler, public wxLog {
  public:

src/FFmpeg.h

@@ -156,7 +156,6 @@ extern "C" {
 #include "widgets/LinkingHtmlWindow.h"
 #include "ShuttleGui.h"
 #include "Prefs.h"
-#include <wx/textctrl.h>
 
 #include "audacity/Types.h"
 

src/FreqWindow.h

@@ -25,13 +25,13 @@
 #include <wx/scrolbar.h>
 #include <wx/sizer.h>
 #include <wx/statusbr.h>
-#include <wx/textctrl.h>
 #include <wx/utils.h>
 #include "SampleFormat.h"
 #include "widgets/wxPanelWrapper.h"
 
 class wxSlider;
 class wxStatusBar;
+class wxTextCtrl;
 class wxButton;
 class wxChoice;
 

src/HistoryWindow.h

@@ -15,10 +15,10 @@
 #include <wx/frame.h>
 #include <wx/listctrl.h>
 #include <wx/spinctrl.h>
-#include <wx/textctrl.h>
 
 #include "widgets/wxPanelWrapper.h"
 
+class wxTextCtrl;
 class AudacityProject;
 class ShuttleGui;
 class UndoManager;

src/Lyrics.h

@@ -15,7 +15,7 @@
 #include "Audacity.h"
 
 #include <vector>
-#include <wx/textctrl.h>
+#include <wx/textctrl.h> // to inherit
 #include "commands/CommandManagerWindowClasses.h"
 #include "widgets/wxPanelWrapper.h"
 

src/TimerRecordDialog.h

@@ -17,7 +17,7 @@
 #define __AUDACITY_TIMERRECORD_DIALOG__
 
 #include <wx/dialog.h>
-#include <wx/textctrl.h>
+#include <wx/textctrl.h> // to inherit
 #include <wx/datectrl.h>
 #include <wx/calctrl.h>
 #include <wx/timer.h>

src/commands/Demo.h

@@ -11,8 +11,6 @@
 #ifndef __AUDACITY_DEMO_COMMAND__
 #define __AUDACITY_DEMO_COMMAND__
 
-#include <wx/textctrl.h>
-
 #include "AudacityCommand.h"
 #include "../SampleFormat.h"
 

src/effects/Amplify.h

@@ -16,13 +16,13 @@
 #define __AUDACITY_EFFECT_AMPLIFY__
 
 #include <wx/checkbox.h>
-#include <wx/textctrl.h>
 
 #include "Effect.h"
 
 #define AMPLIFY_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Amplify") }
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 class EffectAmplify final : public Effect

src/effects/AutoDuck.h

@@ -13,11 +13,11 @@
 
 #include <wx/bitmap.h>
 #include <wx/gdicmn.h>
-#include <wx/textctrl.h>
 
 #include "Effect.h"
 #include "../widgets/wxPanelWrapper.h"
 
+class wxTextCtrl;
 class EffectAutoDuckPanel;
 class ShuttleGui;
 

src/effects/BassTreble.h

@@ -12,12 +12,12 @@
 #ifndef __AUDACITY_EFFECT_BASS_TREBLE__
 #define __AUDACITY_EFFECT_BASS_TREBLE__
 
-#include <wx/textctrl.h>
 #include <wx/checkbox.h>
 
 #include "Effect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define BASSTREBLE_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Bass and Treble") }

src/effects/ChangePitch.h

@@ -28,11 +28,11 @@ the pitch without changing the tempo.
 
 #include <wx/choice.h>
 #include <wx/spinctrl.h>
-#include <wx/textctrl.h>
 
 #include "SoundTouchEffect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define CHANGEPITCH_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Change Pitch") }

src/effects/ChangeSpeed.h

@@ -14,13 +14,13 @@
 #define __AUDACITY_EFFECT_CHANGESPEED__
 
 #include <wx/choice.h>
-#include <wx/textctrl.h>
 
 #include "../widgets/NumericTextCtrl.h"
 
 #include "Effect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define CHANGESPEED_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Change Speed") }

src/effects/ChangeTempo.h

@@ -22,11 +22,10 @@
 #include <wx/checkbox.h>
 #endif
 
-#include <wx/textctrl.h>
-
 #include "SoundTouchEffect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define CHANGETEMPO_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Change Tempo") }

src/effects/ClickRemoval.h

@@ -16,11 +16,10 @@
 #ifndef __AUDACITY_EFFECT_CLICK_REMOVAL__
 #define __AUDACITY_EFFECT_CLICK_REMOVAL__
 
-#include <wx/textctrl.h>
-
 #include "Effect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class Envelope;
 class ShuttleGui;
 

src/effects/Distortion.h

@@ -11,7 +11,6 @@
 #ifndef __AUDACITY_EFFECT_DISTORTION__
 #define __AUDACITY_EFFECT_DISTORTION__
 
-#include <wx/textctrl.h>
 #include <wx/checkbox.h>
 
 #include <queue>
@@ -20,6 +19,7 @@
 
 class wxSlider;
 class wxStaticText;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define DISTORTION_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Distortion") }

src/effects/DtmfGen.h

@@ -20,6 +20,7 @@
 
 class wxSlider;
 class wxStaticText;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define DTMFTONES_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("DTMF Tones") }

src/effects/Echo.h

@@ -12,8 +12,6 @@
 #ifndef __AUDACITY_EFFECT_ECHO__
 #define __AUDACITY_EFFECT_ECHO__
 
-#include <wx/textctrl.h>
-
 #include "Effect.h"
 #include "../SampleFormat.h"
 

src/effects/Normalize.h

@@ -16,12 +16,12 @@
 #include "../Experimental.h"
 
 #include <wx/checkbox.h>
-#include <wx/textctrl.h>
 
 #include "Effect.h"
 #include "Biquad.h"
 
 class wxStaticText;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define NORMALIZE_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Normalize") }

src/effects/Phaser.h

@@ -16,11 +16,10 @@
 #ifndef __AUDACITY_EFFECT_PHASER__
 #define __AUDACITY_EFFECT_PHASER__
 
-#include <wx/textctrl.h>
-
 #include "Effect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define NUM_STAGES 24

src/effects/Repeat.h

@@ -11,10 +11,9 @@
 #ifndef __AUDACITY_EFFECT_REPEAT__
 #define __AUDACITY_EFFECT_REPEAT__
 
-#include <wx/textctrl.h>
-
 #include "Effect.h"
 
+class wxTextCtrl;
 class ShuttleGui;
 
 #define REPEAT_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Repeat") }

src/effects/TimeScale.h

@@ -15,11 +15,10 @@
 
 #if USE_SBSMS
 
-#include <wx/textctrl.h>
-
 #include "SBSMSEffect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 // two strings here

src/effects/Wahwah.h

@@ -16,11 +16,10 @@
 #ifndef __AUDACITY_EFFECT_WAHWAH__
 #define __AUDACITY_EFFECT_WAHWAH__
 
-#include <wx/textctrl.h>
-
 #include "Effect.h"
 
 class wxSlider;
+class wxTextCtrl;
 class ShuttleGui;
 
 #define WAHWAH_PLUGIN_SYMBOL ComponentInterfaceSymbol{ XO("Wahwah") }

src/effects/lv2/LV2Effect.h

@@ -19,7 +19,6 @@ class wxArrayString;
 #include <vector>
 #include <wx/checkbox.h>
 #include <wx/dialog.h>
-#include <wx/textctrl.h>
 
 #include "lv2/lv2plug.in/ns/ext/atom/forge.h"
 #include "lv2/lv2plug.in/ns/ext/data-access/data-access.h"
@@ -39,6 +38,7 @@ class wxArrayString;
 #include <unordered_map>
 
 class wxSlider;
+class wxTextCtrl;
 
 #define LV2EFFECTS_VERSION wxT("1.0.0.0")
 /* i18n-hint: abbreviates

src/effects/nyquist/Nyquist.h

@@ -18,7 +18,6 @@
 #include <wx/intl.h>
 #include <wx/sizer.h>
 #include <wx/textbuf.h>
-#include <wx/textctrl.h>
 #include <wx/tokenzr.h>
 
 #include "../Effect.h"
@@ -26,6 +25,7 @@
 #include "nyx.h"
 
 class wxArrayString;
+class wxTextCtrl;
 
 #define NYQUISTEFFECTS_VERSION wxT("1.0.0.0")
 /* i18n-hint: "Nyquist" is an embedded interpreted programming language in

src/effects/vamp/VampEffect.h

@@ -17,7 +17,6 @@
 
 #include <wx/checkbox.h>
 #include <wx/choice.h>
-#include <wx/textctrl.h>
 
 #include <vamp-hostsdk/PluginLoader.h>
 
@@ -26,6 +25,7 @@
 
 class wxStaticText;
 class wxSlider;
+class wxTextCtrl;
 class LabelTrack;
 
 #define VAMPEFFECTS_VERSION wxT("1.0.0.0")

src/export/ExportFFmpegDialogs.h

@@ -29,6 +29,7 @@ class wxArrayStringEx;
 
 class wxArrayString;
 class wxStaticText;
+class wxTextCtrl;
 
 /// Identifiers for pre-set export types.
 enum FFmpegExposedFormat

src/prefs/DirectoriesPrefs.h

@@ -11,13 +11,12 @@
 #ifndef __AUDACITY_DIRECTORIES_PREFS__
 #define __AUDACITY_DIRECTORIES_PREFS__
 
-#include <wx/textctrl.h>
-
 #include "PrefsPanel.h"
 
 class ShuttleGui;
 
 class wxStaticText;
+class wxTextCtrl;
 
 class DirectoriesPrefs final : public PrefsPanel
 {

src/prefs/KeyConfigPrefs.h

@@ -20,7 +20,6 @@ class ShuttleGui;
 #include <wx/listctrl.h>
 #include <wx/radiobut.h>
 #include <wx/srchctrl.h>
-#include <wx/textctrl.h>
 #include <wx/timer.h>
 
 #include "../widgets/KeyView.h"
@@ -28,6 +27,7 @@ class ShuttleGui;
 #include "PrefsPanel.h"
 
 class wxStaticText;
+class wxTextCtrl;
 struct NormalizedKeyString;
 
 class KeyConfigPrefs final : public PrefsPanel

src/prefs/QualityPrefs.h

@@ -16,10 +16,10 @@
 #include <wx/defs.h>
 
 #include <wx/choice.h>
-#include <wx/textctrl.h>
 
 #include "PrefsPanel.h"
 
+class wxTextCtrl;
 class ShuttleGui;
 enum sampleFormat : unsigned;
 enum DitherType : unsigned;

src/prefs/RecordingPrefs.h

@@ -13,10 +13,10 @@
 #define __AUDACITY_RECORDING_PREFS__
 
 #include <wx/defs.h>
-#include <wx/textctrl.h>
 
 #include "PrefsPanel.h"
 
+class wxTextCtrl;
 class ShuttleGui;
 
 class RecordingPrefs final : public PrefsPanel

src/widgets/NumericTextCtrl.h

@@ -23,7 +23,7 @@
 #include <wx/setup.h> // for wxUSE_* macros
 #include <wx/defs.h>
 #include <wx/panel.h>
-#include <wx/textctrl.h>
+#include <wx/control.h> // to inherit
 
 #include "../Internat.h"
 

src/widgets/valnum.h

@@ -17,7 +17,7 @@
 
 #if wxUSE_VALIDATORS
 
-#include <wx/textctrl.h>
+#include <wx/textctrl.h> // complete type needed in template function
 #include <wx/validate.h>
 
 #include <limits>