Commit Graph

9684 Commits

Author SHA1 Message Date
Leland Lucius 988e90ea54 Change to a KEY_DOWN event instead of CHAR event
This should prevent pasting and backspace as well.
2021-04-01 20:29:35 -05:00
Leland Lucius e47f27b106 Prevent keyboard navigation from being blocked on Mac
Readonly or non-editable text controls block keyboard navigation
on the Mac, so make them normal text controls, but block any edits.
2021-04-01 20:01:39 -05:00
Leland Lucius 7a55c90b9d Bug 2692 - Mac: VI users get trapped in radio buttons of Keyboard Preferences
This also corrects similar problems in other locations as well.
2021-04-01 20:00:12 -05:00
Leland Lucius 392a060389 Bug 2700 - "Failed to open the project database" 2021-04-01 01:13:15 -05:00
James Crook ae5e768023 Bug 2726 - Enh: Some preference changes are not written until Audacity exits
Also fixed a bug with GetPreferences, where uninitialised pointers
could be used that were only meant for use when editing values
(in which path they would be initialised).
2021-03-31 16:15:51 +01:00
James Crook 1f1f1d43f6 Add C number format option (disabled)
The option to force decimal point in numbers and not
use comma is an experiment to work around bug 2709

It's disabled, because wxWidgets checks for a mismatch
between locale and number format, and disallows it.  To get
it working correctly might require patching wxWidgets.

This change does get the option string into our source code
so that translators can translate it.
2021-03-30 15:46:27 +01:00
Dmitry Vedenko f1395ff621 Bug 2718 - improve the error message when opening a project in a read-only directory. 2021-03-29 18:40:40 +01:00
Leland Lucius 0a085daa92 Fix build 2021-03-29 00:05:44 -05:00
Leland Lucius 7ad50cb0ca Bug 2703 - Mac: EGAT preview dialog is hidden behind the EGAT dialog 2021-03-28 23:01:20 -05:00
Leland Lucius 895c527b6a Bug 2703 - Mac: EGAT preview dialog is hidden behind the EGAT dialo 2021-03-28 22:56:57 -05:00
Leland Lucius c9afd39845 Bug 2723 - VST_PATH environment variable fails for non-standard locations 2021-03-28 14:02:21 -05:00
JohnColket eb39642969
Bug 2663 - Audacity can make unwanted moves of toolbars (#776) 2021-03-28 09:16:09 +01:00
James Crook ab8fdeacae Don't translate empty string.
Gnu gettext complains, if you do.

"gettext("") returns the header entry with
meta information, not the empty string."
2021-03-27 23:29:32 +00:00
James Crook 3efd8e3ea0 Bug 2710 - Compressor with audio before T=0 crashes Audacity 2021-03-27 20:59:50 +00:00
Leland Lucius 125114cfe7 Bug 2700 - "Failed to open the project database"
Only information gathering changes...not a fix
2021-03-27 14:26:30 -05:00
James Crook 6908d37a90 Bug 2720 - Error message improvement.
The error message occurs whether or not the blockfiles
are 'orphan blockfiles', so change the wording.
2021-03-27 19:10:26 +00:00
James Crook e19d1f2340 Bug 2720 - Residual
Handling of failed to open.  Now if we fail, we abandon that connection,
rather than plough on.
2021-03-27 17:54:14 +00:00
James Crook 6435f595cc Bug 2720 - Cannot open project that's in a read only folder - error message vague.
The error message is now no longer vague, but 2720 can't be closed yet.
Audacity continues with a connection to an unusable project still open,
and then crashes later.
2021-03-27 17:19:19 +00:00
Leland Lucius fe3dfe6774 Bug 2716 - Cleared "Recent Files" are restored on next launch 2021-03-25 02:20:16 -05:00
Leland Lucius ffebbe064e Bug 2714 - (Japanese & Korean) "Unable to parse project information" 2021-03-25 00:19:11 -05:00
Leland Lucius 95a7fc6362 Bug 2707 - Opened projects not being removed from "audacity.cfg" 2021-03-23 12:43:46 -05:00
James Crook 5d28d6989e Bug 2699 - Cannot edit labels with emoji in them correctly.
Fixed on Windows 10.
Probably still broken on mac and linux.
2021-03-23 16:41:08 +00:00
James Crook be704db581 Move macro save button to RHS
This follows a request from QA to do so.
2021-03-23 12:15:09 +00:00
James Crook 55cf4ea95d Bug 2524 - Macros "Cancel" button is confusing - doesn't do "what it says on the tin" 2021-03-22 17:45:54 +00:00
James Crook 2e162adeff Bug 2702 - Enh: Build Info Improvements. (Part I)
Order of items rearranged so most important first.

Still to do:
- Gtk2/Gtk3 indicator
- GitIdent for wxWidgets.
2021-03-21 13:00:58 +00:00
James Crook 56ec133c77 Bug 2696 - Metadata Editor: changed size is not remembered/restored on next use
Reverting what looks like an unintended change
in TagsEditor introduced in fixing bug 2209.

428193920f
2021-03-21 12:35:23 +00:00
James Crook f5a69354e0 Bug 2701 - Progress dialog interferes with scripting.
Interference mattered for "PlayLooped".
No interference existed for an empty selection, a play until stopped.
2021-03-21 10:56:51 +00:00
Leland Lucius e37155b07c Use our versions of lrint and lrintf to ensure performance 2021-03-18 08:05:02 -05:00
Leland Lucius 1bbfd3db5e Bug 2697 - AUP3 projects not using the correct character size on "differently" configured wxWidgets 2021-03-18 08:03:36 -05:00
JohnColket 3d90f8074a
Audacity fails to compile with VS2019 16.9.0 (lrint, lrintf) (#750) 2021-03-17 15:50:24 +00:00
James Crook 173e3b3d66 Ready for 3.0.1 development. 2021-03-17 10:13:51 +00:00
James Crook d5d4c46a3f Set BUILD_LEVEL 2, in preparation for release. 2021-03-09 10:19:38 +00:00
Leland Lucius 2c47dc5ba1 Bug 2688 - Bad saves with Unicode project filenames 2021-03-08 12:42:09 -06:00
James Crook c08131b78f Bug 2689 - Ctrl+R to repeat an effect may show the dialog 2021-03-08 09:51:46 +00:00
Leland Lucius 9b67c5aeec Bug 2688 - Bad saves with Unicode project filenames 2021-03-07 16:27:16 -06:00
Leland Lucius 0f830b44d3 Bug 2687 - Compressor with selection to end of track can cause corruption 2021-03-05 21:27:28 -06:00
James Crook eb16476b31 Bug 2680 - Scale for Spectrogram changed unexpectedly.
This fixes the reported issue of a jump in the spectrogram
min frequency value when using half-wave collapsed and
generating silence.
2021-02-26 13:13:25 +00:00
Paul Licameli 8f0cec114c Bug2681 -- crash when generating into silence 2021-02-26 08:04:43 -05:00
James Crook eaaaf67fe4 Bug 2679 - aup that opens in 2.4.2. does not open in 3.0.0 2021-02-26 10:56:34 +00:00
Leland Lucius 15dcb343f3 Fix LV2 memory leaks 2021-02-26 00:53:18 -06:00
James Crook 803fe8ef04 Shorter (clearer) fix for Bug 2677 2021-02-25 16:28:46 +00:00
James Crook 15c862a836 Bug 2677 - Win/Mac: An AUP file can crash Audacity when opened in 3.0.0 2021-02-25 16:03:47 +00:00
James Crook cc9d53df04 Add Comments (for Bug 2673 fix)
Bug 2673 was an important multi-threading issue, and so I added
comments about the code.  Also a LogDebug to track cache use.

Bug 2673 was also a crash with no error message reported.
That is something to revisit later and deserved a comment.
It's believed that the underlying issue is fixed now.

The 'ANSWER-MEs' can be answered in 3.0.1.
2021-02-23 12:24:41 +00:00
Leland Lucius 53f7cacdb2 Bug 2673 - Win: Mixer Board problem on Windows - causes crash 2021-02-22 19:27:02 -06:00
James Crook b99a2e464f Bug 2668 - Residual: Help button on error dialog.
Bug 2668 is Audacity fails to report incompatible/future file versions
This change adds a help link on the error dialog to https://alphamanual.audacityteam.org/man/FAQ:Errors_opening_an_Audacity_project
2021-02-19 11:24:45 +00:00
Leland Lucius f3efee7ed5 Bug 2618 - Screenshot tool: Capture Window only does not just capture the Plot Spectrum window 2021-02-18 21:43:15 -06:00
Leland Lucius b1f6c988db Bug 2670 - Audacity 3.x crashes when you open a 1.2.6 AUP project 2021-02-18 20:37:05 -06:00
Leland Lucius 8fce1db1ae Bug 2669 - Win: Save As can be used to overwrite the existing project without warning 2021-02-18 19:35:11 -06:00
Leland Lucius db34fabb18 Bug 2323 - Win/Mac: Screenshot tool: success/completion dialog is hidden/obscured by the Screenshot dialog 2021-02-18 13:31:28 -06:00
Leland Lucius 5ddf6d0037 Bug 2323 - Win/Mac: Screenshot tool: success/completion dialog is hidden/obscured by the Screenshot dialog 2021-02-18 11:43:47 -06:00
Leland Lucius de6e65ffa3 Remove some unneeded debugging 2021-02-18 11:14:27 -06:00
Leland Lucius 9a0753d214 Change database version format and add comments 2021-02-18 02:05:07 -06:00
Leland Lucius 5357161238 Adding comments to explain the stack trace when using FileDialog 2021-02-17 14:28:08 -06:00
James Crook 449d0932fa Fix file version checking bug.
Opening a 1.2.4 Audacity version would previously
report an error, as being 'more recent' than 1.3.0.
Found by whitebox testing.
2021-02-17 15:30:56 +00:00
Leland Lucius 12f399984a Bug 2322 - Mac: Screenshot tool captures the screenshot dialog overlaying the required image 2021-02-17 02:53:46 -06:00
Leland Lucius 6ec6c9b8a8 Bug 2424 - Linx/Mac: Malformed choice widget in MIDI Device Preferences 2021-02-17 02:15:06 -06:00
Leland Lucius 471d5e9d25 Bug 353 - FFmpeg: Metadata - Artist tag not imported in WMA and APE files 2021-02-17 00:47:34 -06:00
Leland Lucius 98561ee0b2 Bug 2497 - Windows: text can be pasted into the project rate box 2021-02-16 22:18:23 -06:00
Leland Lucius 7cc1cf79ea Don't force preset directory 2021-02-16 17:28:51 -06:00
Leland Lucius 4339632e25 Bug 761 - Linux: VST presets correct extension no longer offered in file name/no longer added if omitted 2021-02-16 16:21:37 -06:00
Leland Lucius ade2cadaa6 A little remnant of the "tags" table expulsion. 2021-02-16 14:57:47 -06:00
Leland Lucius 37b36f5826 Bug 2120 - Spectral Selection Toolbar can be truncated when undocked 2021-02-16 02:17:50 -06:00
Leland Lucius 91b3389434 Ensure docked state is passed 2021-02-16 01:56:19 -06:00
Leland Lucius 672a69f24c Bug 1693 - Time selection issues in Selection Toolbar 2021-02-15 15:13:11 -06:00
Leland Lucius 182878caae Bug 2386 - Win/Linux: Toolbar grabber gets stuck pushed 2021-02-15 09:59:42 -06:00
Leland Lucius 3ecc5717ad Bug 2120 - Spectral Selection Toolbar can be truncated when undocked 2021-02-15 09:13:33 -06:00
Leland Lucius fd0f24e5ff Bug 761 - Linux: VST presets correct extension no longer offered in file name/no longer added if omitted 2021-02-15 02:24:21 -06:00
Leland Lucius 3f4fbd1c8c Bug 1572 - Dither not applied when exporting 24-bit WAV from 32-bit float 2021-02-14 17:53:45 -06:00
Leland Lucius 217ba2bbec Handle VEL_SLIDER in SliderDialog 2021-02-14 15:55:08 -06:00
Leland Lucius 7356c735ae Bug 1982 - Numeric entry in Play-at-Speed dialog allows entries not supported by the slider or the PAS functionality 2021-02-14 15:47:19 -06:00
Leland Lucius 379348898d Bug 2324 - Windows: Screenshot tool success/completion dialog is unnecessarily over-large 2021-02-14 12:29:13 -06:00
Leland Lucius 5f68102dc5 Revert "Bug 2547 - Shift + Click may select incorrect tracks"
This reverts commit 0c234359af.

Will need to find another way and have discussion as pointed out
in bug #2547.
2021-02-14 03:43:17 -06:00
Leland Lucius f1b43fd642 Fix build 2021-02-14 03:39:27 -06:00
Leland Lucius 63af846600 Reposition help button on Export dialog 2021-02-14 03:02:32 -06:00
Leland Lucius 57ce22e38a Bug 2432 - Linux/Mac: Bad placement of '?' (help) Icon 2021-02-14 01:41:11 -06:00
Leland Lucius 20ace313fa Bug 1872 - Most Non-Modal dialogs do not update buttons when language changed 2021-02-14 01:25:52 -06:00
Paul Licameli 56852ae4c1 Remove unused tags table from the database schema 2021-02-13 15:22:40 -05:00
Leland Lucius d21b13a8e1 Bug 2351 - Selection toolbar displays incorrect number of samples beyond 2^31 -1 2021-02-13 12:42:41 -06:00
Paul Licameli 8fdb18427e Less-incomplete Marathi support ...
... supplying some missing pieces of commit
a76b7ec295

See commit a37162ffca for the complete example of
Corsican.

Still missing are appropriate strings in Marathi for src/audacity.desktop.in and
win/Inno_Setup_Wizard/audacity.iss

Blank line change of locale/CMakeLists.txt to force reconfigure
2021-02-13 13:10:22 -05:00
James Crook 7428c61060 Bug 2565 - (Residual) Fix auto-scroll regression.
My fix for 2565 broke autoscroll.

Scrubbing can be 'paused' when it is not active!
This meant that paused scrubbing could stop autoscroll
of normal play.  The fix is to only suppress the autoscroll
if scrubbing is active and paused.
2021-02-13 10:49:52 +00:00
Leland Lucius b928e7e9f2 Add dump of active AUP3 XML doc to support data 2021-02-13 01:58:09 -06:00
Leland Lucius 5861ce3c66 Bug 2432 - Linux/Mac: Bad placement of '?' (help) Icon 2021-02-13 01:30:45 -06:00
Leland Lucius 598eb39484 Bug 2353 - Import RAW into empty project does not zoom to fit 2021-02-12 18:56:41 -06:00
Leland Lucius 7547de9f52 Bug 1398 - Metadata Editor tag fields emptied when field length stored in project exceeds a given length 2021-02-12 10:32:43 -06:00
Leland Lucius 0c234359af Bug 2547 - Shift + Click may select incorrect tracks 2021-02-12 10:12:08 -06:00
Leland Lucius 7392e8b619 Bug 621 - Metadata Editor: saved tags not displayed when importing MP2/MP3/FLAC/FFmpeg formats without metadata 2021-02-12 08:06:59 -06:00
Leland Lucius 0f58e8828d Bug 2433 - Importing MIDI into an empty project does not change the project name 2021-02-12 02:26:51 -06:00
Leland Lucius e178f63aec Bug 2097 - Mac: File list ignored at the command line 2021-02-12 02:03:34 -06:00
Leland Lucius 9940f1cf64 Bug 2571 - Linux: No digit highlight in Edit Label time / frequency controls 2021-02-12 01:50:05 -06:00
Leland Lucius 77f3cc5506 Bug 2416 - Mac: Grabbers of other toolbars get "pushed" when dragging another toolbar over them 2021-02-11 22:27:28 -06:00
Leland Lucius cd359768a6 Bug 2473 - Linux: Numbers on meters have opaque backgrounds 2021-02-11 19:48:32 -06:00
Leland Lucius e0096f7fc7 Fix Build 2021-02-11 17:08:54 -06:00
Leland Lucius 63c826ebed Bug 1986 - Linux: Unwanted messages in console. 2021-02-11 15:36:17 -06:00
Leland Lucius 9445393876 Bug 2527 - Reset Configuration does not reset Project rate or selection timers 2021-02-11 15:01:35 -06:00
Leland Lucius 11076f00e0 Bug 2446 - ENH: ultra-wide toolbars (Play-at-Speed & Mixer) with reticules and no numbers look far too sparse 2021-02-10 22:46:09 -06:00
Leland Lucius a7197d7d14 Bug 1901 - Status bar message does not update when Recording or Playback sliders are moved 2021-02-10 13:43:06 -06:00
Leland Lucius 52acaf6031 Bug 1927 - Help > Generate Support Data has very confusing behavior 2021-02-10 12:27:42 -06:00
Paul Licameli 907e830070 Fix build 2021-02-09 16:11:23 -05:00
Leland Lucius 68870710b9 Bug 2661 - Status bar not updated on language change 2021-02-09 13:47:48 -06:00
Leland Lucius f8765d9101 Bug 1779 - Linux: Sound Activation Level window unusable / malformed. High DPI 2021-02-09 13:07:23 -06:00
Leland Lucius 8a47799516 Add missing includes 2021-02-09 12:38:07 -06:00
Leland Lucius 407fa67a74 Bug 1927 - Help > Generate Support Data crashes Audacity 2021-02-09 12:31:04 -06:00
Leland Lucius 2002cd91dd Prevent "Could not transfer data..." message in Audaicty log 2021-02-07 20:49:11 -06:00
Paul Licameli 5c80f6f19f Specification of Preferences menu item simplified 2021-02-07 11:55:14 -05:00
Leland Lucius 0f810708bb Fix LV2 buffer size display in Settings 2021-02-06 13:07:52 -06:00
Paul Licameli e4eea36d0a Remove old duplicate test for end of MIDI playback...
... which, anyway, had errors introduced into it (realTime mistakenly used as a
duration)
2021-02-06 09:20:30 -05:00
Paul Licameli e47245bd8c Fix use of uninitialized data for meter when emulating volume 2021-02-06 09:20:30 -05:00
James Crook 0e20a0873f Bug 2656 - Cannot horizontal scroll when paused in play-at-speed. 2021-02-04 21:49:29 +00:00
Patriccollu a37162ffca Add Corsican language (co.po etc) 2021-02-04 17:14:02 +00:00
Paul Licameli 40682f834a Removed some unnecessary #include directives 2021-02-04 10:12:42 -05:00
Paul Licameli 175584cb51 Removed some unnecessary #include directives 2021-02-04 08:26:29 -05:00
Leland Lucius 521c2e0b58 Missed a file 2021-02-04 03:17:32 -06:00
Leland Lucius 773a86d66e Bug 2654 - Enh: Time tracks have no context menu for scale changes - inconsistent with audio track 2021-02-04 02:56:26 -06:00
Paul Licameli 3144f0120a WaveTrack did not need Spectrum.h 2021-02-03 23:06:53 -05:00
Paul Licameli 5fda4b959f Some command flags can be defined nearer their sole points of use 2021-02-03 17:05:27 -05:00
James Crook 9d800c8969 Bug 2655 - (Updated error msg and help link)
Following feedback from QA.
2021-02-03 18:50:52 +00:00
James Crook ab30778306 Bug 2655 - Import Audio command can import open projects and can import a project into itself 2021-02-03 16:41:28 +00:00
James Crook 67dff35a12 Bug 2640 - Plot Spectrum and Contrast analyzers are not "Repeatable"
Completing the update by John Colket.  The plan always was that
these new 'repeat' entries were optional commands bindable to
keyboard shortcuts by advanced users.

Users visiting the menus can re-select the item they want.
For these menu users it would be confusing/overload to list
these repeat commands in the menu.  Repeat last effect in the Effects
menu is more important.  It is there in the menu to signal to
users that there is the Ctrl+R key binding for it.
2021-02-03 11:40:21 +00:00
JohnColket a3d9f41fb4
Bug 2582 - Enh: Repeat last Process, Part 2 (#734) 2021-02-03 11:02:49 +00:00
Paul Licameli 92e36332f3 Reimplement importation of .aup3 file more simply...
... Breaking dependency of ProjectFileIO on on TimeTrack, and reusing the same
functions that implement cross-document copy and paste of tracks.

Also changing behavior, so that if a TimeTrack exists but another is imported,
then the import quietly replaces the existing completely.
2021-02-02 15:22:44 -05:00
Paul Licameli 15313a27f7 Define virtual Track::PasteInto to simplfy Paste...
... Also making EditMenus not dependent on TimeTrack
2021-02-02 15:01:51 -05:00
Paul Licameli 8543d2dd30 Also skip TimeTrack in some other commands with the flag 2021-02-02 14:56:52 -05:00
Paul Licameli 2842fa7d56 Don't cut or copy TimeTrack...
... Which was the intention in the flags enabling the commands
2021-02-02 14:44:28 -05:00
Paul Licameli badb1643fa New Track virtual eliminates a track_cast in CommonCommandFlags...
... Also a better name for one of the command flags

This allows removal of special mention of TimeTrack
2021-02-02 14:42:21 -05:00
Paul Licameli 89f572f798 Define Tags::Merge 2021-02-02 14:00:52 -05:00
Leland Lucius 392360a629 Bug 453 - Nyquist receives Unicode characters from Audacity producing platform-inconsistent behaviour 2021-02-02 03:01:00 -06:00
Leland Lucius 282bdfa5cc Bug 866 - FFmpeg: Audacity rejects FFmpeg in PATH/doesn't search PATH if invalid libs are in FFmpeg path 2021-02-02 00:37:52 -06:00
Leland Lucius 31c0196bb4 Bug 2636 - No thousands separator in Spectral Selection toolbar 2021-02-01 23:22:05 -06:00
Paul Licameli e89546d941 Keep EXPERIMENTAL_EFFECTS_RACK compilable 2021-02-01 20:20:04 -05:00
Leland Lucius 4f7affad3f Bug 2135 - Audacity crashes if launched with a locked pluginregistry.cfg file 2021-02-01 18:05:16 -06:00
Leland Lucius c0a8537880 Remove constraint in AUP importer for "h" attribute 2021-02-01 11:24:42 -06:00
Leland Lucius fcfca160c3 Remove unneeded include 2021-02-01 10:41:13 -06:00
Leland Lucius 5107c0f350 No longer need header replacement for sbsms.h 2021-02-01 10:35:52 -06:00
Leland Lucius a5609e44d0 Use version 2.1.0 of libsbsms
This is actually the exact code we already use, but Clayton has
set up a github repo for the release to make it available to
distros.
2021-02-01 10:12:06 -06:00
Yuri Chornoivan dd9998c855
Fix minor typo: coninue -> continue (#736) 2021-02-01 11:49:26 +00:00
Leland Lucius accd1770b4 Bug 2645 - FFmpeg library not filtered correctly in browse in Libraries preferences 2021-02-01 00:03:47 -06:00
Leland Lucius 005ceb31fc Add missing include 2021-01-31 23:43:44 -06:00
Leland Lucius b9eb3c3b0e Can now retry read protected configuration files
Allow us to have a single error dialog for all cases.
2021-01-31 21:57:18 -06:00
Leland Lucius 96a417c61a Better (not best) exit for locked config file 2021-01-31 20:04:58 -06:00
Leland Lucius da49fe63da Wrap overly long messages 2021-01-31 17:57:32 -06:00
Leland Lucius 8e93cac1be Bug 2652 - User is not warned if they launch Audacity with a locked pluginsettings.cfg file 2021-01-31 12:49:43 -06:00
Paul Licameli ef2c0fca9a Fix assertion violation on shutdown after commit 21296b0 2021-01-31 13:45:34 -05:00
Paul Licameli 3480317ecd Move FileConfig::Warn() into AudacityFileConfig as an override 2021-01-31 11:28:12 -05:00
Paul Licameli c853450ce0 Hide two-phase construction of AudacityFileConfig in factory function 2021-01-31 11:22:48 -05:00
Paul Licameli 2c5c0f9dfd Class AudacityPrefs renamed, moved, reused in PluginManager...
... And construction of the main instance is hoisted into AudacityApp
2021-01-31 11:11:03 -05:00
Paul Licameli 030ba78c5f Demote Get/SetVersionKeysInit from AudacityPrefs into FileConfig 2021-01-31 11:00:34 -05:00
Paul Licameli 05d5f2677c Fix comments, remove unnecessary #include 2021-01-31 08:51:31 -05:00
Leland Lucius 21296b0cf1 New wrapper for wxFileConfig to fix several bugs
Bug 2135 - Audacity crashes if launched with a locked pluginregistry.cfg file
Bug 2651 - If pluginregistry.cfg gets locked while Audacity is active the Plug-in Manager is blocked - with no help
Bug 2650 - Virgin launch fails with no pluginregistry.cfg file created
Bug 1264 - Writing to locked audacity.cfg not reported to user
Bug 2649 - Launching Audacity with a locked audacity.cfg file gives not one but three error messages - and no help
Bug 2652 - User is not warned if they launch Audacity with a locked pluginsettings.cfg file
2021-01-31 04:24:35 -06:00
Paul Licameli 78b6897f85 Remove unused function 2021-01-30 20:44:31 -05:00
Paul Licameli 8cc9bd9b57 Remove unnecessary call to Translation 2021-01-30 18:09:12 -05:00
Paul Licameli ce9f25bafe Keep some EXPERIMENTALs compilable 2021-01-30 13:30:42 -05:00
Paul Licameli 23f32a8319 Remove some unnecessary #include directives 2021-01-30 12:37:47 -05:00
Leland Lucius 7aa26482eb Bug 1806 - Extreme negative settings in Change Tempo cause an "apparent" hang/freeze 2021-01-30 04:56:53 -06:00
Leland Lucius 754838844d Bug 119 - Linux: Export Multiple: "*" and "?" in label or track name wrongly rejected 2021-01-30 04:13:56 -06:00
Leland Lucius ae3c89453f Bug 119 - Linux: Export Multiple: "*" and "?" in label or track name wrongly rejected 2021-01-30 03:55:59 -06:00
Leland Lucius 618106f1c3 Bug 619 - TwoPassSimpleMono converts to track bit format between passes, losing quality. 2021-01-30 01:16:32 -06:00
Leland Lucius 0576d8c945 Bug 1215 - Incorrect splits produced by Change Tempo with leading whitespace 2021-01-29 23:23:54 -06:00
David Bailes 6c44b4fdc0 Bug 2648: Grid accessibility: location can be incorrect.
The focus location provided to assistive technology by GridAx::GetLocation() does not take into account horizontal or vertical scrolling. So if there is any scrolling in either the Metadata or Labels editor, the focus location provided to assistive technology is not the same as the focus location shown by wxWidgets.
2021-01-29 16:25:26 +00:00
Leland Lucius 52bde299aa Revert "Bug 2508 - Macros: Export2 handles channels > 2 incorrectly"
This reverts commit 2ecc98225f.

This is the one I was supposed to revert.
2021-01-29 06:38:12 -06:00
Leland Lucius 76460c73da Bug 2366 - Macros: Run does "Select All" ignoring setting in Tracks Behaviors Preferences
Reverted the wrong commit...needed to add an include anyway.
2021-01-29 06:37:30 -06:00
Leland Lucius 90a1783779 Revert "Bug 2366 - Macros: Run does "Select All" ignoring setting in Tracks Behaviors Preferences"
This reverts commit 1478abf3d0.

Removing until some questions are answered.
2021-01-29 06:16:17 -06:00
Leland Lucius 2ecc98225f Bug 2508 - Macros: Export2 handles channels > 2 incorrectly 2021-01-29 06:00:36 -06:00
Leland Lucius 1478abf3d0 Bug 2366 - Macros: Run does "Select All" ignoring setting in Tracks Behaviors Preferences 2021-01-29 05:08:05 -06:00
Leland Lucius a7c1906bf5 A small change to accommodate new Nyquist version 2021-01-28 19:10:08 -06:00
Leland Lucius 9e5ec6d9cc Bug 2135 - Audacity crashes if launched with a locked pluginregistry.cfg file 2021-01-28 15:05:10 -06:00
Leland Lucius d84ce6d147 Bug 2647 - Audacity can import Word 2000 files as "audio" 2021-01-28 14:41:32 -06:00
Paul Licameli ae99e69af0 Fix #include guard 2021-01-28 12:13:50 -05:00
luzpaz 98d3e91452
Fix typos (user facing and non-user facing) (#733)
Found via `codespell`
2021-01-28 12:36:41 +00:00
luzpaz e050b0ecbb
Fix source typos (#732)
Coefficents->Coefficients
2021-01-28 12:35:23 +00:00
Leland Lucius f24d42d510 Update Audacity's Nyquist interface for r331 (r3.16+)
This includes converting some types to int64_t to be
compatible with Nyquist's improved 64-bit support.
2021-01-28 02:34:43 -06:00
Leland Lucius 5aa5b0df6d Bug 2435 - Some menu commands greyed out when playback paused 2021-01-27 16:05:45 -06:00
Leland Lucius 428193920f Bug 2209 - Nyquist: Audacity crashes when running seq-write-smf
Used upstream fix instead.  Really need to update to Nyquist
release 3.16 for many more 64-bit fixes/enhancements.
2021-01-27 10:38:10 -06:00
Leland Lucius 3e8e5aa1f5 Ensure selected cell in visible 2021-01-27 10:03:33 -06:00
Leland Lucius 058023f978 Bug 2564 - Metadata: Artist and Year tags missing on M4A(AAC) exports 2021-01-27 02:34:06 -06:00
Leland Lucius aa89805fd2 Bug 2523 - Audacity may suggest installing FFmpeg even when FFmpeg is installed 2021-01-27 01:19:59 -06:00
Leland Lucius dd58db4097 Bug 2534 - Change Speed merges selected clip with adjacent clips 2021-01-26 23:25:48 -06:00
Leland Lucius 6841919d94 Bug 2644 - Clearing the entries in Extended Import leaves behind a residual list of file formats 2021-01-26 13:36:34 -06:00
Leland Lucius e5bb95d6f2 Bug 2083 - Labels Editor has confusing selection interface - can cause wrong labels to be deleted 2021-01-26 12:18:51 -06:00
James Crook f59ba86faf Wording fixes (minor) 2021-01-26 12:13:54 +00:00
Paul Licameli 35e9afe34d Remove unnecessary parts of fix for bug 2501...
... Don't need to put the project in a strange state where Undo commands are
ignored until labels are de-selected
2021-01-26 04:23:45 -05:00
Leland Lucius c9d37675f7 First stab at responding to whitebox review
In some cases, I've simply left the REVIEW: in and
responded to it. In other cases, I've resolved what
was mentioned in the review.
2021-01-26 02:21:12 -06:00
Leland Lucius 3d632d397d Ensure row selection mode is used in grids 2021-01-25 12:57:33 -06:00
Paul Licameli 197ebc2994 Bug2583 residual: Re-placement of cutlines when generating sound 2021-01-25 12:06:24 -05:00
Leland Lucius 0fcf9ffb52 Bug 2083 - Labels Editor has confusing selection interface - can cause wrong labels to be deleted 2021-01-25 01:13:02 -06:00
Leland Lucius a03a6abb4b Bug 2501 - Undo for label edit results in a blank label 2021-01-24 23:27:50 -06:00
Leland Lucius a2cee50c01 Bug 2217 - Metadata: When exporting to FLAC the "Comment" field is ignored and not exported with the audio file
I don't know how I lost the original changes, but here they are again.
2021-01-24 09:52:56 -06:00
luzpaz 7a3bdcf3f2
Fix typos (user facing and non-user facing) (#727)
Found via `codespell v2.1.dev0`  
`codespell -q 3 -S *.po,./lib-src -L parm,parms,toke`
2021-01-24 09:46:08 +00:00
Leland Lucius 4b07fbaa8a Bug 2642 - Metadata Editor: Cut and paste does not work 2021-01-23 17:27:31 -06:00
Leland Lucius 4e6d11fe0c Don't clear tags until after loading to guard against bad XML file 2021-01-23 16:05:27 -06:00
Leland Lucius 82014bacd9 Prevent pasting into Hotkey box in keybinding prefs
Reported by AKa on Quality list.
2021-01-23 15:48:30 -06:00
Paul Licameli 0df8fbcc74 Bug2583: Re-placement of splits after paste 2021-01-23 14:38:36 -05:00
Leland Lucius 37a7583306 Bug 2578 - Linux/Windows: Export 24-bit AIFF exports as 16-bit 2021-01-23 13:13:52 -06:00
James Crook 42a105ee0a Review DB/Data safety.
I've added the comment 'REVIEW:' where I have some concern that
the database and our copy of it could get out of step, or simply that
we fail to report a problem to the user.

I'd like these reviewed and turned into comments that make it
easier to check for correctness, for example saying where an
error is reported, or why it is OK to do no further recovery action.
2021-01-23 19:00:36 +00:00
Leland Lucius 81da0ef1f7 Bug 2217 - Metadata: When exporting to FLAC the "Comment" field is ignored and not exported with the audio file 2021-01-23 04:02:10 -06:00
Leland Lucius af0fdda8f6 Add missing include 2021-01-23 02:42:57 -06:00
Leland Lucius e9d4a8e538 Bug 2517 - Mix Stereo To Mono incorrectly changes sample rate to Project Rate without resampling - it should resample to the project rate 2021-01-23 01:45:32 -06:00
Leland Lucius 7427653ef6 Bug 2578 - Linux/Windows: Export 24-bit AIFF exports as 16-bit 2021-01-23 01:08:58 -06:00
Leland Lucius f509d9c0bd Bugs 1592 and 2639
Sound activated record is now decoupled from the input meter.
2021-01-22 23:43:01 -06:00
Leland Lucius 50e803a974 Rework of commit b4a0be9
See comments 6-9 in bug #2642 for the problem it caused.
2021-01-22 15:16:38 -06:00
Leland Lucius 4e6e3c2089 Swapped cut/copy IDs 2021-01-22 09:23:36 -06:00
Leland Lucius 0123a3e3fb Bug 666 - Mac: Cannot "Open" audio files named with "\" using File>Open 2021-01-22 01:05:22 -06:00
Leland Lucius b4a0be99cd Bug 1579 - Mac: Cut/Copy from file save dialogs using shortcuts does not work
And Bug 1300 - Mac: COMMAND + V paste limitations in standard file save dialogs
2021-01-21 18:45:01 -06:00
Leland Lucius b5ee77f737 Bug 2632 - Original project isn't compacted when doing Save As 2021-01-20 22:39:19 -06:00
Leland Lucius e67fcd6aba Bug 2625 - Nyquist plug-ins Presets fail for plug-ins with "time" widgets 2021-01-20 16:20:36 -06:00
Leland Lucius e8b2602473 Bug 2616 - Labelled Audio Cut and Delete disabled by Sync-Lock 2021-01-20 12:32:09 -06:00
Leland Lucius 235cc242e4 Bug 2616 - Labelled Audio Cut and Delete disabled by Sync-Lock 2021-01-20 10:46:30 -06:00
Leland Lucius b6ceff9b2a Bug 2625 - Nyquist plug-ins Presets fail for plug-ins with "time" widgets 2021-01-20 10:45:13 -06:00
Leland Lucius 26d8fcad66 Bug 2616 - Labelled Audio Cut and Delete disabled by Sync-Lock 2021-01-19 15:31:06 -06:00
Paul Licameli 4668e351a5 Rename enum value to eWinFuncHann 2021-01-17 12:24:38 -05:00
Paul Licameli cccc7a7c4e Keep !defined(MIDI_THREAD) branch compilable...
... The break was caused by ffa67d2 which split the base class AudioIoCallback
out of AudioIO.

This change only demotes some member declarations from AudioIO into
AudioIoCallback, and changes the qualified names of function definitions.

So now you can eliminate #define MIDI_THREAD in AudioIO.h and rebuild.
2021-01-16 14:34:22 -05:00
Paul Licameli 6b42c92651 Small correction to commit 549dacf 2021-01-16 13:32:59 -05:00
Paul Licameli 43574553fc Break dependency cycle introduced at 50f3321...
... This only cuts and pastes some functions from FileNames to another new file
and namespace, and changes namespace qualifiers where they are called.

The cycle resulted because of the need to include widgets/ErrorDialog.h
2021-01-16 13:28:37 -05:00
Leland Lucius 086cacad76 Bug 2616 - Labelled Audio Cut and Delete disabled by Sync-Lock
This is only for information gathering. I don't believe that
simply allowing the use of these two menu items is sufficient.
I believe more work will need to be done, but I wanted to get
it in the QA hands.
2021-01-16 02:26:35 -06:00
JohnColket 549dacf054
2582 enh repeat last process (#722)
* Enhancement: Add Repeat Last Process

* add include UndoManager.h
2021-01-15 14:22:38 +00:00
Leland Lucius 8aaecdc596 Bug 2631 - Silent crash during "discard selected" processing from Recovery dialog. 2021-01-14 21:30:10 -06:00
Leland Lucius 9e53df0c47 Fix handling of Unicode when decoding project blob
If a TAG with Unicode characters outside the normal ASCII
range were saved to an AUP3, you would not be able to reopen
it and you'd receive the following error:

   Unable to parse project information.
2021-01-14 01:09:21 -06:00
Leland Lucius 171d8cf26c Bug 2613 - Selection bar sample display incorrect in German
This changes the way the decimal point is specified in the
PO files...uses '<' for "," and ">" for ".".

By doing this the translator is free to use "." or "," in the
digits fields as their language requires.
2021-01-12 19:19:44 -06:00
Paul Licameli 88f059fcf1 dropQuickly branch always consumes just as many samples as the other 2021-01-12 08:41:36 -05:00
Paul Licameli bf6d94ce57 Remove unused AudioIoCallback::mAudioCallbackClockTime 2021-01-12 08:40:21 -05:00
Paul Licameli 7b513ce0c4 Start backward scrub, sometimes play head move a little forward; fix 2021-01-12 08:39:54 -05:00
Paul Licameli 510c5683d9 Increase time queue allocation by one entry...
... guarantee the gap between producer and consumer is more than one grain, so
that the consumed entry is not still being produced.

Fixes small errors in positioning of the green play head line.
2021-01-12 08:36:05 -05:00
Paul Licameli 20d72ee745 fix a comment 2021-01-12 08:08:14 -05:00
freddii 534359de6c
Fix minor typos (#720)
Co-authored-by: freddii <https://freddii@github.com>
2021-01-12 11:56:09 +00:00
Yuri Chornoivan 85f333a31f
Fix minor typo (#719) 2021-01-12 10:36:43 +00:00
freddii 2593a84d56 Fix some spelling mistakes. 2021-01-12 09:55:31 +00:00
Leland Lucius c13407d692 Bug 2628 - Linux: FAT/FAT32 drives can wrongly have projects saved to them 2021-01-12 02:25:15 -06:00
Leland Lucius e093ed1846 Bug 2624 - Win: large projects saved to slow USB drive when aborted yield error on reopening 2021-01-12 01:53:19 -06:00
Leland Lucius 98e00c92ad Detect temp dir FAT drive change while Audacity is active 2021-01-11 13:12:59 -06:00
Leland Lucius ac55e228ce Remove experimental attempt at FAT detection
We'll just have to address each instance individually.
2021-01-11 12:24:14 -06:00
Leland Lucius c7a8b824a1 Reset temp directory if found to be on FAT drive 2021-01-11 11:09:34 -06:00
Leland Lucius 28a286c656 Experimental commit for testing more FAT exclusion 2021-01-11 08:51:17 -06:00
Leland Lucius 60ebe7919a Bug 2610 - Backup Project only fails when it has actually run out of disk space (unlike Save Project)
This may not be a complete fix...needs more testing.
2021-01-11 01:04:16 -06:00
Leland Lucius c961d6236b Bug 2626 - Mac: Temporary files directory on exFAT makes Audacity fail at launch 2021-01-11 00:56:30 -06:00
SteveDaulton 7e6842c1f9 Remove Silence Finder plug-in
as discussed between QA and RM.
2021-01-09 20:20:42 +00:00
Leland Lucius 69a98669bf Remove anchor from help URLs 2021-01-06 22:11:49 -06:00
SteveDaulton f57e69cfca Replace Sound Finder with Label Sounds
also fixes bug 2352:
Sound / Silence Finder fail silently on selection > 2^31 -1
2021-01-06 16:52:39 +00:00
James Crook 44b191ff42 Bug 2622 - Track name overlay is opaque
Somewhere along the line the 'rect' passed in to DrawTrackName()changed
from being for the track area to being for the name area.  Accordingly
the track rect now has to be explicitly accessed from the track to get
its height, from which the transparency is then derived.
2021-01-06 15:57:54 +00:00
Leland Lucius a49cf61033 Don't crash during Auto Recovery
Steps:

1)	New project
2)	Generate chirp
3)	New Project
4)	Generate chirp
5)	Kill Audacity
6)	Restart Audacity
7)	Unselect the 2nd item
8)	Click "Discard Selected"
9)	Click "Yes" to confirm
10)     Click "Recovery Selected"

Crash...
2021-01-06 01:13:09 -06:00
Leland Lucius 8fa0b13432 Ensure error dialog is displayed in a couple more instances 2021-01-06 01:12:29 -06:00
Leland Lucius 6a5d4fdbc0 Update FAT filesystem messages 2021-01-05 13:28:04 -06:00
Leland Lucius bd4cab5e93 Bug 2621 - Windows: the use of exFAT formatted dives is prohibited for saves and temp directory 2021-01-05 13:00:55 -06:00
Leland Lucius fd774c0de4 Second try to fix github build 2021-01-05 03:24:15 -06:00
Leland Lucius 636ecc3dc5 Fix github build. 2021-01-05 02:37:34 -06:00
Leland Lucius 50f3321154 Bug 2576 - FAT formatted disks can readily run out of space with multiple edits - wrong error message can be displayed 2021-01-05 01:32:03 -06:00
Leland Lucius 8e333e1fae Fix statfs() call for OSX 2021-01-04 13:23:14 -06:00
Leland Lucius 56c8bdcd24 Bug 2609 - Save Project when disk is full gives a second disk-full message 2021-01-03 19:22:22 -06:00
Leland Lucius 84c60beab6 Bug 2603 - Backing up a >4GB project to a FAT drive fails with an incorrect misleading error message 2021-01-03 16:33:05 -06:00
Leland Lucius 375a6a8803 Bug 2604 - Saving a 4 hour stereo chirp to FAT fails and with an inappropriate error message 2021-01-03 16:02:43 -06:00
James Crook 7143df28cc Bug 2617 - Audacity not responding after switching to Envelope tool
This was caused by endless refreshing.
Disabling one refresh might have caused the screen not to refresh
at some point when it should, but I could not find such a case, and
this seems better than 'beachball' mode.
2021-01-01 15:12:50 +00:00
James Crook 05c6d62f78 Bug 2566 - Spectrogram view: changing algorithm to Pitch (EAC) turns off "Enable Spectral Selection"
Made defaults consistent again.
The spectral selection was off by default in some places, on by default
in others.
2021-01-01 13:50:24 +00:00